[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-03-18 Thread David Barth
New version of the patch:
 * supports the new hints x-canonical-* returned and used by notify-osd; 
should fix bug #338515
 * new support for the NEXT  PREV media keys


** Attachment added: 16_use_synchronous_notifications.patch
   http://launchpadlibrarian.net/24040258/16_use_synchronous_notifications.patch

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-03-18 Thread Sebastien Bacher
thank you for your work on the updated change, don't forget to reopen
bugs when you have new changes though or open a new bug next time

** Changed in: gnome-settings-daemon (Ubuntu)
   Status: Fix Released = Triaged

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-03-18 Thread Sebastien Bacher
some comments

* your change does:

-+g_debug (the service does not support the 
'x-canonical-private-synchronous' capability);
++g_debug (the service does not support the 'synchronous' 
capability);

is that expected?

running the new version the eject action still don't use notify-osd do I
need a new notify-osd codebase?

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-03-18 Thread Sebastien Bacher
the eject action works now after updating notify-osd I will sponsor the
change

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-03-18 Thread Launchpad Bug Tracker
This bug was fixed in the package gnome-settings-daemon -
2.25.92-0ubuntu7

---
gnome-settings-daemon (2.25.92-0ubuntu7) jaunty; urgency=low

  * debian/patches/16_use_synchronous_notifications.patch:
- updated version by David Barth to fix other capability naming issues
  (lp: #329245)

 -- Sebastien Bacher seb...@ubuntu.com   Wed, 18 Mar 2009 13:21:35
+0100

** Changed in: gnome-settings-daemon (Ubuntu)
   Status: Triaged = Fix Released

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-03-03 Thread David Barth
Updated version of the patch, to adjust for hints changes in notify-
osd-0.9 + improvements to the rendering.


** Attachment added: 16_use_synchronous_notifications.patch
   http://launchpadlibrarian.net/23353784/16_use_synchronous_notifications.patch

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-03-03 Thread Martin Pitt
** Changed in: gnome-settings-daemon (Ubuntu)
   Status: Fix Released = Fix Committed

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-03-03 Thread David Barth
re-opening with the patch update

** Changed in: gnome-settings-daemon (Ubuntu)
   Status: Fix Committed = In Progress

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-03-03 Thread Launchpad Bug Tracker
This bug was fixed in the package gnome-settings-daemon -
2.25.92-0ubuntu3

---
gnome-settings-daemon (2.25.92-0ubuntu3) jaunty; urgency=low

  * 16_use_synchronous_notifications.patch: Update for new hint names and
eject key. Patch by David Barth. (LP: #329245)

 -- Martin Pitt martin.p...@ubuntu.com   Tue, 03 Mar 2009 14:58:19
+0100

** Changed in: gnome-settings-daemon (Ubuntu)
   Status: In Progress = Fix Released

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-02-19 Thread David Barth
Additional patch (to apply on top of the other one), so that the daemon
uses the right icon names. This patch also adjusts the icon depending on
the value of the volume.

** Attachment added: gsd-volume-icon.patch
   http://launchpadlibrarian.net/22877002/gsd-volume-icon.patch

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-02-19 Thread Martin Pitt
Uploaded Davids' patch as solution to bug 331311.

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-02-17 Thread Martin Pitt
Seb, can you please review this?

** Changed in: gnome-settings-daemon (Ubuntu)
 Assignee: (unassigned) = Sebastien Bacher (seb128)

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-02-17 Thread Sebastien Bacher
I've some comments about the code:

+   if (! notify_get_server_info (name, vendor, version,
specver))

you leak those references

the init function is also not complicated since it only call another
function which you could call directly

could you fix those and update the change?

** Changed in: gnome-settings-daemon (Ubuntu)
   Importance: Undecided = Wishlist
   Status: New = Confirmed

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-02-17 Thread Launchpad Bug Tracker
This bug was fixed in the package gnome-settings-daemon -
2.25.90-0ubuntu2

---
gnome-settings-daemon (2.25.90-0ubuntu2) jaunty; urgency=low

  * debian/control.in:
- build-depends on libnotify-dev
  * debian/patches/16_use_synchronous_notifications.patch:
- use synchronous notifications when they are supported
  thanks to the dx-team and James Westby for their work (lp: #329245)

 -- Sebastien Bacher seb...@ubuntu.com   Tue, 17 Feb 2009 16:39:26
+0100

** Changed in: gnome-settings-daemon (Ubuntu)
   Status: Confirmed = Fix Released

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-02-16 Thread James Westby
Hi,

Here's a debdiff that applies against the current jaunty package. After 
applying it you
need to regenerate the 90_autoreconf patch.

+if (!strcmp(cap, canonical-private-1)) {

this is obviously not great, is there any effort to get this capability added 
to the spec with
a well-known name?

Thanks,

James

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-02-16 Thread James Westby

** Attachment added: gsd.diff
   http://launchpadlibrarian.net/22673486/gsd.diff

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 329245] Re: gnome-settings-daemon could use the new notification service

2009-02-13 Thread David Barth

** Attachment added: 00_notification.patch
   http://launchpadlibrarian.net/22592589/00_notification.patch

** Tags added: dxteam

** Tags added: dx-team

** Tags removed: dxteam

** Tags added: dxteam

** Tags removed: dx-team

-- 
gnome-settings-daemon could use the new notification service
https://bugs.launchpad.net/bugs/329245
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-settings-daemon in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs