[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
Marking this as "Fix released" for glib and LibreOffice in Ubuntu as there are Ubuntu releases where this is fixed. A SRU for Ubuntu 12.04 would need a series target. But that is theoretical as the amount of rebuilds needed for that are way too high risk and it will get closed WontFix anyway. ** Changed in: gvfs (Ubuntu) Status: Confirmed => Fix Released ** Changed in: libreoffice (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1214352 Title: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
Bug is confirmed with the newest LibreOffice 5.0 (1:5.0.0~rc5-0ubuntu1~precise1). Could anybody suggest a full list of packages to be rebuilt for fixing this bug on Precise? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1214352 Title: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: libreoffice (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1214352 Title: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: gvfs (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1214352 Title: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
I fully agree that rebuilding only a few packages is no suitable general solution. But so is the recommendation to upgrade to 14.04. There is a reason that corporate environments do not upgrade so often, and even 2 years is a very short time in this context. I have only recently upgraded a few smaller networks from Windows XP to Windows 7, and I am pretty sure these will stick with it until 2020. Thats why we highly appreciated the announcement that Ubuntu 12.04 would get 5 years of LTS support, so we decided to skip 14.04 entirely and target 16.04 as the next upgrade. We cannot change that plan just because of this bug. It took us several hundreds of hours of manpower to evaluate and test the upgrade from 10.04 to 12.04, and it took the complete lifespan of 10.04 until it was done. We worked out around 50 fixes and workarounds for all sorts of weird bugs and shortcomings which are still not fixed, and I cannot count how often I have read that this and that bug will not be fixed in the current version, despite it being an LTS release. Just two recent examples, #949468 and #886327. They're both not as critical as this one, but still annoying. We are a non-profit and as such cannot afford paid support like RHEL or SuSE Enterprise. We decided to try and contribute back instead, wherever we can. I still feel comfortable with that. But sometimes I get frustrated because it seems that some people behind Ubuntu think a shiny new tablet running Ubuntu is more important than people being able to get their work done. I would be happy to help testing if you decided to go the hard way and rebuild the rdeps. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1214352 Title: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
Hi Andreas, I guess you can (at your own risk) create a ppa, upload the fix and upload the rdeps there. you will fix your problem, without affecting the whole distro. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1214352 Title: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
Just quickly: Of course its insane to rebuild all rdeps. However, this is what would be the only way to fix this properly. A. Heinlein in comment 70 only rebuild the packages between glib and LibreOffice, which fixes the immediate problem, but might cause unforseeable and hard to debug/triage problems with all the other packages depending on glib that were _not_ rebuild. As such it is not recommendable in an production environment. So: upgrading to 14.04 still is the recommended action. @Adam Conrad: Possibly this bug in 12.04 should have a target for 12.04 and be Wont Fix there, just to make this more explicit. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1214352 Title: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
Thank you, guys! I understand that doing massive rebuild may cause unexpected regressions. Please let me know if you find other reasonable method. As temporary solution I downgraded LibreOffice to 3.5.7.2 from precise-updates. But what is interesting - I can't open files from Samba share (r/w of course, nautilus-share or smb.conf). I ran into other bug (Document in Use = bug 1430531 ). It affects LibreOffice 3.5.7.2 and more modern versions from PPA. Modern versions of Ubuntu (as client) are affected too. I can't understand why this standard functionality does not work as expected. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1214352 Title: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
Hi Adam, yes, I missed the rdeps thing. Deleting from my ppa and unsubscribing sponsors. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1214352 Title: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
thanks Norbert, I missed that :) https://launchpad.net/~costamagnagianfranco/+archive/ubuntu /locutusofborg-ppa package with the fix above uploaded here, can you please test it? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1214352 Title: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
** Attachment added: debdiff https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1214352/+attachment/4338685/+files/debdiff -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1214352 Title: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
Dear LocutusOfBorg! Thank you for your patched packages! This Glib fix is very important, it should be SRUed. I tested your packages with libreoffice packages from PPA (4.4.1~rc2-0ubuntu1~precise1, 4.3.6~rc2-0ubuntu1~precise1). But what is interesting - the bug is not fixed. I can't understand why - you rebuild package, *.so files are new, they would be dynamically linked to other applications. Is is possible to rebuild main rdepends too, as mentioned in comment 70 ( https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1214352/comments/70 )? Dear Andreas Heinlein, could you please consult us on the method? Björn Michaelsen have recommended to rebuild all dependencies too ( https://bugs.documentfoundation.org/show_bug.cgi?id=67527#c71 ). -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1214352 Title: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
We are not going to be rebuilding all of glib's rdeps for this in an SRU. That's insanity. I'm going to look at this later to see if there's anything we can do that looks like a sensible and targeted fix, but it does look like this is just a poor SRU candidate, due to the regression potential being worse than the fix, and people who really care deeply should perhaps just upgrade to 14.04. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1214352 Title: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
@ Norbert I'm unsuscribing the Ubuntu Bug Control team from this bug. If you think there's a good reason for the team to be subscribed, please email me. Thanks. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1214352 Title: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
Hi Norbert, did you try to download glib 2.24.1-0ubuntu2 and try to apply the patch? I tried, but the file is completely different, so you need to ask somebody to rebase the patch if you really want the bug fixed in lucid. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1214352 Title: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
Dear LocutusOfBorg (costamagnagianfranco)! I'm on Ubuntu 12.04.5 (Precise Pangolin) LTS, not on 10.04 (Lucid Lynx) LTS. I tried to apply patch locally on my 12.04.5, but got into dependency problems. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to glib2.0 in Ubuntu. https://bugs.launchpad.net/bugs/1214352 Title: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1214352] Re: [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
** Summary changed: - GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses + [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses ** Description changed: + [Impact] + * This bug affects Glib-dependent packages, one of them is modern version of LibreOffice 4.x from PPA (https://launchpad.net/~libreoffice/+archive/ubuntu/ppa). + * LibreOffice is very important software. Modern versions are more functional. Without them Ubuntu is nothing, it is a toy. + + [Test Case] + 1. Place OpenDocument file (for example 'test.odt') on SMB/CIFS server (Samba on GNU/Linux, or from Windows). Make this share available for read-write. + 2a.1. Open Nautilus, navigate it to 'smb://server_name/share_name/', wait the share to be mounted with GVFS. + 2a.2. Double click on 'test.odt' + 3. Get error message from LibreOffice: + The file 'test.odt' is corrupt and therefore cannot be opened. + LibreOffice can try to repair the file. + + The corruption could be the result of document manipulation or of + structural document damage due to data transmission. + We recommend that you do not trust the content of the repaired document. + Execution of macros is disabled for this document. + + Should LibreOffice repair the file? + + Yes No + 4a. If I click 'Yes', the file is opened, but the title of the document + is Untitled 1 (repaired document), not original name. + 4b. If I click 'No', the dialog 'LibreOffice 4.4' is opened with text: + The file 'test.odt' could not be repaired and therefore cannot be opened. + OK + + I click 'OK' here, the next window LibreOffice 4.4.1.2 is opened with text: + General Error. + General input/output error. + + OK + + If I click OK here - no files are opened. + + While step 3 gvfsd-smb process eats CPU then terminates with error. This + error is caused by bug in Glib (wrong type conversion in macros). + + [Regression Potential] + + * This functionality is essential. Please fix this bug. + I (and you) can't tell Windows users, that they should not open office files from network shares in GNU/Linux. + + * The patch has two lines + (https://git.gnome.org/browse/glib/commit/?id=255c65f83c1515a7e3fc4609b36e72acc08a79e4) + and well-tested at upstream. + + * This bug may cause potential loss of data. + + [Other Info] + + * Corresponding links to LibO bugs are: +https://bugs.freedesktop.org/show_bug.cgi?id=67527 +https://bugs.documentfoundation.org/show_bug.cgi?id=72337 + + + [Original description] On 12.04 LTS precise GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses, causing trouble down the stack in gvfs and LibreOffice (and possibly in lots of obscure bugs elsewhere). There is a patch available, but as this touches the header, it needs a full recompile of rdepends. see: https://lists.fedoraproject.org/pipermail/devel/2013-March/180302.html ff. for details ** Description changed: - [Impact] - * This bug affects Glib-dependent packages, one of them is modern version of LibreOffice 4.x from PPA (https://launchpad.net/~libreoffice/+archive/ubuntu/ppa). + [Impact] + * This bug affects Glib-dependent packages, one of them is modern version of LibreOffice 4.x from PPA (https://launchpad.net/~libreoffice/+archive/ubuntu/ppa). * LibreOffice is very important software. Modern versions are more functional. Without them Ubuntu is nothing, it is a toy. [Test Case] - 1. Place OpenDocument file (for example 'test.odt') on SMB/CIFS server (Samba on GNU/Linux, or from Windows). Make this share available for read-write. - 2a.1. Open Nautilus, navigate it to 'smb://server_name/share_name/', wait the share to be mounted with GVFS. - 2a.2. Double click on 'test.odt' - 3. Get error message from LibreOffice: - The file 'test.odt' is corrupt and therefore cannot be opened. - LibreOffice can try to repair the file. - - The corruption could be the result of document manipulation or of - structural document damage due to data transmission. - We recommend that you do not trust the content of the repaired document. - Execution of macros is disabled for this document. + 1. Place OpenDocument file (for example 'test.odt') on SMB/CIFS server (Samba on GNU/Linux, or from Windows). Make this share available for read-write. + 2a.1. Open Nautilus, navigate it to 'smb://server_name/share_name/', wait the share to be mounted with GVFS. + 2a.2. Double click on 'test.odt' + 2b. Launch terminal and send 'libreoffice smb://server_name/share_name/test.odt' command. + 3. Get error message from LibreOffice: + The file 'test.odt' is corrupt and therefore cannot be opened. + LibreOffice can try to repair the file. - Should LibreOffice repair the file? + The corruption could be the result of document
