[Bug 1411584] Re: correctly return error and emit warning
Thank you! -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to liboobs in Ubuntu. https://bugs.launchpad.net/bugs/1411584 Title: correctly return error and emit warning To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/liboobs/+bug/1411584/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1411584] Re: correctly return error and emit warning
This bug was fixed in the package liboobs - 3.0.0-1ubuntu0.14.04.1 --- liboobs (3.0.0-1ubuntu0.14.04.1) trusty; urgency=medium [ Vlad Orlov ] * 01-return-error-code.patch: new patch. Correctly return error code on unknown dbus errors. (LP: #1411584) * 02-proper-warning.patch: new patch. Emit the unknown error warning only when dbus error is really unknown. (LP: #1411584) -- Brian Murray br...@ubuntu.com Fri, 23 Jan 2015 09:11:56 -0800 ** Changed in: liboobs (Ubuntu Trusty) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to liboobs in Ubuntu. https://bugs.launchpad.net/bugs/1411584 Title: correctly return error and emit warning To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/liboobs/+bug/1411584/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1411584] Re: correctly return error and emit warning
This bug was fixed in the package liboobs - 3.0.0-1ubuntu0.14.10.1 --- liboobs (3.0.0-1ubuntu0.14.10.1) utopic; urgency=medium [ Vlad Orlov ] * 01-return-error-code.patch: new patch. Correctly return error code on unknown dbus errors. (LP: #1411584) * 02-proper-warning.patch: new patch. Emit the unknown error warning only when dbus error is really unknown. (LP: #1411584) -- Brian Murray br...@ubuntu.com Fri, 23 Jan 2015 09:11:56 -0800 ** Changed in: liboobs (Ubuntu Utopic) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to liboobs in Ubuntu. https://bugs.launchpad.net/bugs/1411584 Title: correctly return error and emit warning To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/liboobs/+bug/1411584/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1411584] Re: correctly return error and emit warning
Brian, I've tested the packages in both Trusty and Utopic, looks good to me. ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to liboobs in Ubuntu. https://bugs.launchpad.net/bugs/1411584 Title: correctly return error and emit warning To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/liboobs/+bug/1411584/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1411584] Re: correctly return error and emit warning
Hello Monsta, or anyone else affected, Accepted liboobs into utopic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/liboobs/3.0.0-1ubuntu0.14.10.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: liboobs (Ubuntu Utopic) Status: In Progress = Fix Committed ** Tags added: verification-needed ** Changed in: liboobs (Ubuntu Trusty) Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to liboobs in Ubuntu. https://bugs.launchpad.net/bugs/1411584 Title: correctly return error and emit warning To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/liboobs/+bug/1411584/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1411584] Re: correctly return error and emit warning
** Branch linked: lp:ubuntu/trusty-proposed/liboobs ** Branch linked: lp:~ubuntu-branches/ubuntu/utopic/liboobs/utopic- proposed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to liboobs in Ubuntu. https://bugs.launchpad.net/bugs/1411584 Title: correctly return error and emit warning To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/liboobs/+bug/1411584/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1411584] Re: correctly return error and emit warning
Thanks, I've uploaded new versions of liboobs with your patches to the Trusty and Utopic queues for review by the Ubuntu SRU team. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to liboobs in Ubuntu. https://bugs.launchpad.net/bugs/1411584 Title: correctly return error and emit warning To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/liboobs/+bug/1411584/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1411584] Re: correctly return error and emit warning
** Changed in: liboobs (Ubuntu Trusty) Assignee: (unassigned) = Brian Murray (brian-murray) ** Changed in: liboobs (Ubuntu Utopic) Assignee: (unassigned) = Brian Murray (brian-murray) ** Changed in: liboobs (Ubuntu Trusty) Status: Triaged = In Progress ** Changed in: liboobs (Ubuntu Utopic) Status: Triaged = In Progress -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to liboobs in Ubuntu. https://bugs.launchpad.net/bugs/1411584 Title: correctly return error and emit warning To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/liboobs/+bug/1411584/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1411584] Re: correctly return error and emit warning
Brian, I've changed the description to match SRU Bug Template. ** Description changed: - Two issues in liboobs are already fixed in Debian and Ubuntu 15.04, but - the package remains unpatched in 14.04 and 14.10. + [Impact] + When a user tries to change his full name via users-admin or mate-users-admin, and some error happens in the backends (either liboobs or system-tools-backends), the error message isn't shown in the GUI. Moreover, the new full name will appear in the GUI, as if it has been successfully changed (when it's not so). - The patches are in the attachments. Please add them in 14.04 and 14.10. + The issues are already fixed in Debian and Ubuntu 15.04, but the package + remains unpatched in 14.04 and 14.10. - Thanks in advance. + The attached patches make users-admin (and mate-users-admin) show the + error message dialog when the mentioned error happens, and also show the + unchanged full name in this case. + + [Test Case] + You'll need the unpatched version of system-tools-backends (2.10.2-1ubuntu1) installed. + Run users-admin or mate-users-admin from the terminal. Click on the button for changing your full name, change the name to something else and click OK. + You'll see a warning message in the terminal: + + Liboobs-WARNING **: There was an unknown error communicating with the + backends: Launch helper exited with unknown return code 255 + + No error message dialog will appear though. + Also the full name in the GUI will be changed to the name you entered. This is not correct because some error happened in the backends, and the name hasn't been actually changed. You can see that for yourself by simply restarting users-admin or mate-users-admin - it will show the old name then. + + [Regression Potential] + + I consider the regression risk to be low here. The patches have been + already tested by me and liboobs maintainer in Debian (see the + corresponding Debian bug report). ** Description changed: [Impact] - When a user tries to change his full name via users-admin or mate-users-admin, and some error happens in the backends (either liboobs or system-tools-backends), the error message isn't shown in the GUI. Moreover, the new full name will appear in the GUI, as if it has been successfully changed (when it's not so). + + When a user tries to change his full name via users-admin or mate-users- + admin, and some error happens in the backends (either liboobs or system- + tools-backends), the error message isn't shown in the GUI. Moreover, the + new full name will appear in the GUI, as if it has been successfully + changed (when it's not so). The issues are already fixed in Debian and Ubuntu 15.04, but the package remains unpatched in 14.04 and 14.10. The attached patches make users-admin (and mate-users-admin) show the error message dialog when the mentioned error happens, and also show the unchanged full name in this case. [Test Case] + You'll need the unpatched version of system-tools-backends (2.10.2-1ubuntu1) installed. Run users-admin or mate-users-admin from the terminal. Click on the button for changing your full name, change the name to something else and click OK. You'll see a warning message in the terminal: Liboobs-WARNING **: There was an unknown error communicating with the backends: Launch helper exited with unknown return code 255 No error message dialog will appear though. Also the full name in the GUI will be changed to the name you entered. This is not correct because some error happened in the backends, and the name hasn't been actually changed. You can see that for yourself by simply restarting users-admin or mate-users-admin - it will show the old name then. [Regression Potential] I consider the regression risk to be low here. The patches have been already tested by me and liboobs maintainer in Debian (see the corresponding Debian bug report). -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to liboobs in Ubuntu. https://bugs.launchpad.net/bugs/1411584 Title: correctly return error and emit warning To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/liboobs/+bug/1411584/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1411584] Re: correctly return error and emit warning
Could you add this information to the bug report so that we can proceed with fixing this in Utopic and Trusty? Thanks! https://wiki.ubuntu.com/StableReleaseUpdates/#SRU_Bug_Template ** Summary changed: - patches - correctly return error and emit warning + correctly return error and emit warning ** Changed in: liboobs (Ubuntu) Status: New = Fix Released ** Also affects: liboobs (Ubuntu Utopic) Importance: Undecided Status: New ** Also affects: liboobs (Ubuntu Trusty) Importance: Undecided Status: New ** Changed in: liboobs (Ubuntu Trusty) Status: New = Triaged ** Changed in: liboobs (Ubuntu Utopic) Status: New = Triaged ** Changed in: liboobs (Ubuntu Trusty) Importance: Undecided = Medium ** Changed in: liboobs (Ubuntu Utopic) Importance: Undecided = Medium -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to liboobs in Ubuntu. https://bugs.launchpad.net/bugs/1411584 Title: correctly return error and emit warning To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/liboobs/+bug/1411584/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1411584] Re: correctly return error and emit warning
** Changed in: liboobs (Ubuntu) Assignee: (unassigned) = The ubuntu geek's (the-ubuntu-geek) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to liboobs in Ubuntu. https://bugs.launchpad.net/bugs/1411584 Title: correctly return error and emit warning To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/liboobs/+bug/1411584/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
