Re: GitLab mirror considered harmful

2019-04-19 Thread Mike Gorse
If I understand correctly, a large part of the rationale for the github mirror was that it was supposed to result in additional code contributors,, since people who already contributed to other github projects would be more likely to check out the GNOME code if it was mirrored on github. What h

Re: GitLab mirror considered harmful

2019-02-04 Thread Michael Gratton
On Tue, 5 Feb, 2019 at 4:12 PM, Michael Gratton wrote: If one of the reasons that the mirror is there to promote contributions, but there's been no or few successful contributions made and only negative reactions, then it's clearly failing at that. *If* there's been no or few... -- ⊨ Michael

Re: GitLab mirror considered harmful

2019-02-04 Thread Michael Gratton
On Tue, 5 Feb, 2019 at 3:58 AM, Philip Chimento via desktop-devel-list wrote: Does anyone have any success stories to share? If it is actually helping other maintainers, then maybe we should just overhaul the bot a little (see suggestion below.) This is what I was wondering as well. If one of

Re: GitLab mirror considered harmful

2019-02-04 Thread Philip Chimento via desktop-devel-list
On Mon, Feb 4, 2019 at 12:39 PM Alexandre Franke wrote: > On Mon, Feb 4, 2019 at 5:58 PM Philip Chimento wrote: > > Could we take it all the way and just push the PR branch to > "$github_user_name/$branch_name" > > in the main repository on GitLab, and open a merge request > automatically, then i

Re: GitLab mirror considered harmful

2019-02-04 Thread William Jon McCann via desktop-devel-list
On Sun, Feb 3, 2019 at 9:55 PM Jan Tojnar via desktop-devel-list wrote: > 3. GitLab does not support any references from gitrevisions(7) other > than commit hash, compare > https://github.com/GNOME/gnome-shell/commit/af34b7c25e39e727f7dbd6e3dae0e7c5fe60f141%5E > and > https://gitlab.gnome.org/GNOM

Re: GitLab mirror considered harmful

2019-02-04 Thread Alexandre Franke
On Mon, Feb 4, 2019 at 5:58 PM Philip Chimento wrote: > Could we take it all the way and just push the PR branch to > "$github_user_name/$branch_name" > in the main repository on GitLab, and open a merge request automatically, > then instruct the > auto-close bot to direct the person to GitLab, p

Re: GitLab mirror considered harmful

2019-02-04 Thread mcatanzaro
FWIW I only use our GitHub mirrors when our GitLab is running slow. But that happens often enough On Mon, Feb 4, 2019 at 10:58 AM, philip.chime...@gmail.com wrote: Could we take it all the way and just push the PR branch to "$github_user_name/$branch_name" in the main repository on GitLab,

Re: GitLab mirror considered harmful

2019-02-04 Thread Philip Chimento via desktop-devel-list
On Mon, Feb 4, 2019 at 6:37 AM Alberto Ruiz wrote: > I agree with Michael here, > > I think a lot of people just default to github and being there has value > in itself. The Pull Request is indeed a not so great situation and I think > we should think hard about making it easy for people who took

Re: GitLab mirror considered harmful

2019-02-04 Thread Christopher Davis via desktop-devel-list
In some cases, the mirror shows up before our hosting in search engines like Google and DuckDuckGo. I've been frustrated by that before. Regards, Chris On Mon, Feb 4, 2019 at 9:51 AM, Milan Crha via desktop-devel-list wrote: On Mon, 2019-02-04 at 14:36 +, Alberto Ruiz wrote: Maybe open

Re: GitLab mirror considered harmful

2019-02-04 Thread Milan Crha via desktop-devel-list
On Mon, 2019-02-04 at 14:36 +, Alberto Ruiz wrote: > Maybe opening an issue in GitLab that points to the original PR so > that the maintainer can persuade the original PR author? Is this > something maintainers would find acceptable? Hi, apart of duplicated space and work, that won't w

Re: GitLab mirror considered harmful

2019-02-04 Thread Alberto Ruiz
I agree with Michael here, I think a lot of people just default to github and being there has value in itself. The Pull Request is indeed a not so great situation and I think we should think hard about making it easy for people who took the time to contribute. For as long as GitHub does not suppo

Re: GitLab mirror considered harmful

2019-02-04 Thread mcatanzaro
On Sun, Feb 3, 2019 at 8:59 PM, Christopher Davis via desktop-devel-list wrote: If we keep the mirrors around, then we should at the very least ensure that pull requests aren't able to be opened at all on the repos. GitHub doesn't allow disabling pull requests, that's why we have the auto-cl

Re: GitLab mirror considered harmful

2019-02-03 Thread Christopher Davis via desktop-devel-list
If we keep the mirrors around, then we should at the very least ensure that pull requests aren't able to be opened at all on the repos. In general though, I would be in favor of getting rid of the mirror because it can cause frustration or confusion on the part of new contributors. This is showca

Re: GitLab mirror considered harmful

2019-02-03 Thread Jan Tojnar via desktop-devel-list
In my opinion, GitHub is still superior for viewing code: 1. It is much faster. Code loads with the page instead of having to wait for AJAX request. 2. GitHub offers a feature to jump to blame from parent commit of the change: https://gitlab.com/gitlab-org/gitlab-ce/issues/30749 3. GitLab d

GitLab mirror considered harmful

2019-02-03 Thread Michael Gratton
Hi all, While the GitHub mirror may have been useful back before GitLab, it actually discourages contributions because PRs aren't accepted there. I've not seen from any positive outcomes from it that I can remember, only negative ones. As such I think it should be deleted. Because of this I