Re: git and trailing whitespace

2009-05-08 Thread Lennart Poettering
On Fri, 08.05.09 11:31, Davyd Madeley (da...@madeley.id.au) wrote: On Wed, 2009-05-06 at 00:01 +0200, Vincent Untz wrote: Are there places where trailing whitespaces are valid (ie, we want them)? Or are the checks only looking at code files? It's a bit of an edge-case, but Markdown

Re: git and trailing whitespace

2009-05-08 Thread Gian Mario Tagliaretti
On Fri, May 8, 2009 at 3:12 PM, Lennart Poettering mzta...@0pointer.de wrote: On Fri, 08.05.09 11:31, Davyd Madeley (da...@madeley.id.au) wrote: It's a bit of an edge-case, but Markdown files give trailing-double-space a meaning. Really? Just grepped through the spec, couldn't find any

Re: git and trailing whitespace

2009-05-08 Thread Wouter Bolsterlee
2009-05-05 klockan 23:00 skrev Lennart Poettering: Then there is the question about editors. emacs has stuff like this: http://www.splode.com/~friedman/software/emacs-lisp/src/whitespace.el. vim has something similar I heard. Not sure if other editors do. If you put the following lines in

Re: git and trailing whitespace

2009-05-08 Thread Wouter Bolsterlee
2009-05-06 klockan 00:39 skrev Lennart Poettering: On Wed, 06.05.09 00:01, Vincent Untz (vu...@gnome.org) wrote: Are there places where trailing whitespaces are valid (ie, we want them)? Or are the checks only looking at code files? I was wondering about that too myself, and have asked quite

Re: git and trailing whitespace

2009-05-08 Thread Lennart Poettering
On Tue, 05.05.09 23:00, Lennart Poettering (mzta...@0pointer.de) wrote: Heya! Trailing whitespace sucks. git is only half as much fun when people have trailing whitespace in their code. diffs get cluttered up by changes that actually aren't changes. Many other project these days enforce

Re: git and trailing whitespace

2009-05-07 Thread Davyd Madeley
On Wed, 2009-05-06 at 00:01 +0200, Vincent Untz wrote: Are there places where trailing whitespaces are valid (ie, we want them)? Or are the checks only looking at code files? It's a bit of an edge-case, but Markdown files give trailing-double-space a meaning. There might be others. --d --

Re: git and trailing whitespace

2009-05-06 Thread Loïc Minier
On Wed, May 06, 2009, Lennart Poettering wrote: I just have these lines in my ~/.emacs: (autoload 'nuke-trailing-whitespace nuke-trailing-whitespace nil t) (add-hook 'write-file-hooks 'nuke-trailing-whitespace) This sounds like it would remove all trailing whitespace in any file you touch;

Re: git and trailing whitespace

2009-05-06 Thread Bastien Nocera
On Wed, 2009-05-06 at 11:18 +0200, Loïc Minier wrote: On Wed, May 06, 2009, Lennart Poettering wrote: I just have these lines in my ~/.emacs: (autoload 'nuke-trailing-whitespace nuke-trailing-whitespace nil t) (add-hook 'write-file-hooks 'nuke-trailing-whitespace) This sounds like it

Re: git and trailing whitespace

2009-05-06 Thread Germán Póo-Caamaño
On Wed, 2009-05-06 at 10:40 +0100, Bastien Nocera wrote: On Wed, 2009-05-06 at 11:18 +0200, Loïc Minier wrote: On Wed, May 06, 2009, Lennart Poettering wrote: I just have these lines in my ~/.emacs: (autoload 'nuke-trailing-whitespace nuke-trailing-whitespace nil t) (add-hook

Re: git and trailing whitespace

2009-05-06 Thread Stefan Kost
Behdad Esfahbod schrieb: On 05/05/2009 05:59 PM, Zeeshan Ali (Khattak) wrote: On Wed, May 6, 2009 at 12:06 AM, Behdad Esfahbodbeh...@behdad.org wrote: On 05/05/2009 05:00 PM, Lennart Poettering wrote: Anyway, Owen said he didn't want to fight this fight. I guess I can understand that, and

git and trailing whitespace

2009-05-05 Thread Lennart Poettering
Heya! Trailing whitespace sucks. git is only half as much fun when people have trailing whitespace in their code. diffs get cluttered up by changes that actually aren't changes. Many other project these days enforce pretty rigid whitespace regimes and I wonder if that would be something

Re: git and trailing whitespace

2009-05-05 Thread Behdad Esfahbod
On 05/05/2009 05:00 PM, Lennart Poettering wrote: Anyway, Owen said he didn't want to fight this fight. I guess I can understand that, and I don't really want to fight this fight either. Nonetheless I think this would be good to have and the least I can do is mentioning this on desktop-devel

Re: git and trailing whitespace

2009-05-05 Thread Zeeshan Ali (Khattak)
On Wed, May 6, 2009 at 12:06 AM, Behdad Esfahbod beh...@behdad.org wrote: On 05/05/2009 05:00 PM, Lennart Poettering wrote: Anyway, Owen said he didn't want to fight this fight. I guess I can understand that, and I don't really want to fight this fight either. Nonetheless I think this would

Re: git and trailing whitespace

2009-05-05 Thread Behdad Esfahbod
On 05/05/2009 05:59 PM, Zeeshan Ali (Khattak) wrote: On Wed, May 6, 2009 at 12:06 AM, Behdad Esfahbodbeh...@behdad.org wrote: On 05/05/2009 05:00 PM, Lennart Poettering wrote: Anyway, Owen said he didn't want to fight this fight. I guess I can understand that, and I don't really want to

Re: git and trailing whitespace

2009-05-05 Thread Adam Schreiber
On Tue, May 5, 2009 at 5:06 PM, Behdad Esfahbod beh...@behdad.org wrote: I personally always do a git diff before commit, and look for red-background blocks that represent trailing whitespace and fix them myself. Have your gnome terminal/bash preferences been tweaked? I did a test with git

Re: git and trailing whitespace

2009-05-05 Thread Vincent Untz
Le mardi 05 mai 2009, à 23:00 +0200, Lennart Poettering a écrit : Heya! Trailing whitespace sucks. git is only half as much fun when people have trailing whitespace in their code. diffs get cluttered up by changes that actually aren't changes. Many other project these days enforce pretty

Re: git and trailing whitespace

2009-05-05 Thread Zeeshan Ali (Khattak)
On Wed, May 6, 2009 at 1:02 AM, Behdad Esfahbod beh...@behdad.org wrote: On 05/05/2009 05:59 PM, Zeeshan Ali (Khattak) wrote: On Wed, May 6, 2009 at 12:06 AM, Behdad Esfahbodbeh...@behdad.org  wrote: On 05/05/2009 05:00 PM, Lennart Poettering wrote: Anyway, Owen said he didn't want to

Re: git and trailing whitespace

2009-05-05 Thread Behdad Esfahbod
On 05/05/2009 06:05 PM, Adam Schreiber wrote: On Tue, May 5, 2009 at 5:06 PM, Behdad Esfahbodbeh...@behdad.org wrote: I personally always do a git diff before commit, and look for red-background blocks that represent trailing whitespace and fix them myself. Have your gnome terminal/bash

Re: git and trailing whitespace

2009-05-05 Thread Lennart Poettering
On Tue, 05.05.09 17:06, Behdad Esfahbod (beh...@behdad.org) wrote: On 05/05/2009 05:00 PM, Lennart Poettering wrote: Anyway, Owen said he didn't want to fight this fight. I guess I can understand that, and I don't really want to fight this fight either. Nonetheless I think this would be