Re: Do not use -Werror by default in your modules without joining #testable

2017-04-03 Thread Emmanuele Bassi 
On 3 April 2017 at 19:38, Nicolas Dufresne  wrote:
> Le dimanche 02 avril 2017 à 14:59 +0100, Emmanuele Bassi a écrit :
>> Yes, I know: this would be slightly more easier if Continuous warned
>> about build breakages via email (though I'm pretty sure email would
>> still be a high latency medium that tends to be ignored);
>> nevertheless, joining the #testable IRC channel *today* to get a
>> notification of build failure is *not* a heavy burden — especially
>> now
>> that we have the Matrix bridge and you don't even need an IRC client
>> running at all times.
>
> Is this important for projects that already have their own CI system ?
> (notably GStreamer). It does seems like an overhead to track two CI, I
> do believe that build breakage due to warning should be quite rare in
> GStreamer case. Please let us know.

If you have your own CI then, by all means: keep watching your own CI. :-)

GStreamer is fairly well-behaved, and it's rare that I have to hunt
down people on IRC, or file a bug for it.

Ciao,
 Emmanuele.

-- 
https://www.bassi.io
[@] ebassi [@gmail.com]
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

Re: Do not use -Werror by default in your modules without joining #testable

2017-04-03 Thread Nicolas Dufresne 
Le dimanche 02 avril 2017 à 14:59 +0100, Emmanuele Bassi a écrit :
> Yes, I know: this would be slightly more easier if Continuous warned
> about build breakages via email (though I'm pretty sure email would
> still be a high latency medium that tends to be ignored);
> nevertheless, joining the #testable IRC channel *today* to get a
> notification of build failure is *not* a heavy burden — especially
> now
> that we have the Matrix bridge and you don't even need an IRC client
> running at all times.

Is this important for projects that already have their own CI system ?
(notably GStreamer). It does seems like an overhead to track two CI, I
do believe that build breakage due to warning should be quite rare in
GStreamer case. Please let us know.

Nicolas 


signature.asc
Description: This is a digitally signed message part
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

Re: Do not use -Werror by default in your modules without joining #testable

2017-04-03 Thread Michael Catanzaro 
On Sun, 2017-04-02 at 20:22 +0200, Sébastien Wilmet wrote:
> To disable -Werror by default it's better to set the IS-RELEASE
> parameter of AX_COMPILER_FLAGS to "yes":
> 
> AX_COMPILER_FLAGS([WARN_CFLAGS], [WARN_LDFLAGS], [yes])

Yeah I think you're right, that's what Emmanuele wants... OTOH, this
seems almost like abuse of the macro.

Michael
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

Re: Do not use -Werror by default in your modules without joining #testable

2017-04-03 Thread Michael Catanzaro 
On Mon, 2017-04-03 at 06:42 +0200, Sébastien Wilmet wrote:
> Maybe this works:
> module_autogenargs['epiphany'] = '--enable-Werror'

Actually it does work. No clue what I was doing wrong when I tested
this previously. :)

module_autogenargs['epiphany'] = 'CFLAGS="-Werror"' works too. I didn't
try messing with makeargs as that doesn't seem right.

Michael
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list