[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-02-17 Thread Egmont Koblinger
Re "cat" (which should rather be "ls -1") with LTR vs. autodetected directionality: Let's use the convention here that uppercase letters are fake Arabic, e.g. imagine that the word [written as LTR here] "ARABIC" is a valid Arabic word which is supposed to visually appear as "CIBARA". Let's have

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-02-17 Thread Egmont Koblinger
Re "nano" with LTR vs. autodetected directionality: The LTR screenshot is more obviously "broken" (or at least undesireable). The autodetected directionality's brokenness is less obvious, maybe no breakage is visible in this particular screenshot, but is still broken. Maybe it looks pretty much

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-02-16 Thread Egmont Koblinger
Hi M.Hanny, Thanks a lot for spreading the word about BiDi support in VTE! Really no need to apologize about your English! I'm not a native English speaker either, and your English is at least as good as mine. We have no communication issues at all! --- > Ideally, there shouldn't be a text in

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-02-15 Thread Gunnar Hjalmarsson
Thanks for the latest test, M.Hanny Sabbagh. A rewritten patch is now on its way to the coming Ubuntu 23.04. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-terminal in Ubuntu. https://bugs.launchpad.net/bugs/2002290 Title: Poor

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-02-15 Thread M.Hanny Sabbagh
@Egmont: Thank you for the valuable feedback. First I would like to ask you to forgive me if some of my words are not clear or vague; I am not a native English speaker so it is a little bit hard when I write long responses like this. I hope I am correctly delivering my ideas to you and others.

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-02-15 Thread M.Hanny Sabbagh
** Attachment added: "nano output with autodetect.png" https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/2002290/+attachment/5647494/+files/nano%20output%20with%20autodetect.png -- You received this bug notification because you are a member of Desktop Packages, which is

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-02-15 Thread M.Hanny Sabbagh
** Attachment added: "cat output with autodetect.png" https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/2002290/+attachment/5647491/+files/cat%20output%20with%20autodetect.png -- You received this bug notification because you are a member of Desktop Packages, which is subscribed

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-02-15 Thread M.Hanny Sabbagh
** Attachment added: "cat output with LTR.png" https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/2002290/+attachment/5647492/+files/cat%20output%20with%20LTR.png -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-02-15 Thread M.Hanny Sabbagh
** Attachment added: "nano output with LTR.png" https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/2002290/+attachment/5647493/+files/nano%20output%20with%20LTR.png -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-02-15 Thread M.Hanny Sabbagh
@Gunnar: Thank you for the continous help. I have tested the new update and indeed it now respects the font size of Monospace font in GNOME Tweaks (image attached). Thanks again! ** Attachment added: "gnome-terminal new monospace.png"

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-02-12 Thread Egmont Koblinger
> The only thing that remains is related to bug 2 and the RTL text auto- detection in VTE. I am yet to hear from Egmont on anything we can do in this regard. Both the autodetection "on" and "off" values have pros and cons. I don't think either one is better per se than the other. One is better in

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-02-05 Thread Gunnar Hjalmarsson
On 2023-02-03 10:46, Gunnar Hjalmarsson wrote: > https://salsa.debian.org/gnome-team/gnome-terminal/-/blob/e832a65a/debian/patches/Use-DejaVu-as-system-font-if-LANG-is-Arabic.patch I got more feedback, this time in the form of a code review, and it resulted in yet another version:

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-02-03 Thread Gunnar Hjalmarsson
Hi M.Hanny Sabbagh! Even if bug 1 is fixed, I have rewritten the patch after feedback from one of the Debian developers. Currently it looks like this: https://salsa.debian.org/gnome-team/gnome- terminal/-/blob/e832a65a/debian/patches/Use-DejaVu-as-system-font-if- LANG-is-Arabic.patch One change

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-02-01 Thread M.Hanny Sabbagh
Thank you Gunnar for fixing the font issue in gnome terminal. So now, we can say that bug 1 is fixed. The only thing that remains is related to bug 2 and the RTL text auto-detection in VTE. I am yet to hear from Egmont on anything we can do in this regard. I hope we can find a solution to use

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-26 Thread Launchpad Bug Tracker
This bug was fixed in the package gnome-terminal - 3.46.7-1ubuntu2 --- gnome-terminal (3.46.7-1ubuntu2) lunar; urgency=medium * Use DejaVu as system font if LANG is Arabic (LP: #2002290) -- Gunnar Hjalmarsson Wed, 25 Jan 2023 20:14:38 +0100 ** Changed in: gnome-terminal

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-25 Thread Gunnar Hjalmarsson
Thanks for testing and confirming! I have uploaded the gnome-terminal change to lunar. ** Changed in: gnome-terminal (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-terminal in

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-25 Thread M.Hanny Sabbagh
Thank you Gunnar, for the help! Indeed it works well on my testing (image attached); GNOME Terminal's custom font option is disabled (so it is using the default font), and Ubuntu Mono is still used in GNOME Tweaks, and still the GNOME Terminal now uses Monospace font by default, making the first

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-25 Thread Gunnar Hjalmarsson
I have submitted a merge request, which changes the default font for GNOME Terminal from Ubuntu Mono to DejaVu Sans Mono if the user has selected Arabic as the display language: https://salsa.debian.org/gnome-team/gnome-terminal/-/merge_requests/8 A version of gnome-terminal for jammy with that

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-15 Thread M.Hanny Sabbagh
Hi Egmond. Thank you for the info. About lam-alif: Yes, you are right. It indeed is displayed like a U in my screenshot, although it should have been similar to a "y", but as you said, it is not that terribly bad and can be read without an issue. Perhaps we can improve it in a future work!

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-15 Thread M.Hanny Sabbagh
** Attachment added: "VTE BiDi LTR base.png" https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/2002290/+attachment/5641433/+files/VTE%20BiDi%20LTR%20base.png -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-terminal

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-15 Thread M.Hanny Sabbagh
** Attachment added: "VTE BiDi RTL base.png" https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/2002290/+attachment/5641432/+files/VTE%20BiDi%20RTL%20base.png -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-terminal

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-15 Thread M.Hanny Sabbagh
** Attachment added: "VTE BiDi autodetect.png" https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/2002290/+attachment/5641431/+files/VTE%20BiDi%20autodetect.png -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-13 Thread Egmont Koblinger
** Package changed: vte (Ubuntu) => vte2.91 (Ubuntu) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-terminal in Ubuntu. https://bugs.launchpad.net/bugs/2002290 Title: Poor Arabic rendering in VTE Status in gnome-terminal

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-12 Thread Egmont Koblinger
Hi M.Hanny, I'm so glad that you're way more familiar with fontconfig quirks as well as Ubuntu processes than me. I wish you good luck in getting some better config accepted and made default in Ubuntu! - Re lam-alif: As far as I remember, and

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-12 Thread M.Hanny Sabbagh
Hi Egmont. For bug 1, yes, fontconfig can be used for this. We even have a special configuration file at /etc/fonts/conf.d/56-language-selector-ar.conf to use a different font when the system language is Arabic (Noto Sans Arabic). I believe it can be tweaked to use a custom Monospace font when

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-12 Thread M.Hanny Sabbagh
** Attachment added: "VTE with RTL enabled.png" https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/2002290/+attachment/5640984/+files/VTE%20with%20RTL%20enabled.png -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-12 Thread M.Hanny Sabbagh
** Attachment added: "lam-alif ligature in GNOME Terminal (without, with).png" https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/2002290/+attachment/5640983/+files/lam-alif%20ligature%20in%20GNOME%20Terminal%20%28without%2C%20with%29.png -- You received this bug notification

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-10 Thread Egmont Koblinger
Hi M.Hanny, Re bug 1 (rendering): Thanks for attaching screenshots, I was lazy to do that. Indeed this is also how the letters look to me. It would indeed be great if Ubuntu could change its default font choice, at least for Arabic locales. I don't know what would be the best place to bring it

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-10 Thread M.Hanny Sabbagh
Also I found the default Monospace used in Ubuntu. It is DejaVu Sans Mono: mhsabbagh@ubuntu2204:/$ fc-match monospace DejaVuSansMono.ttf: "DejaVu Sans Mono" "Book" -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-terminal in

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-10 Thread M.Hanny Sabbagh
** Attachment added: "apt output in gedit.png" https://bugs.launchpad.net/ubuntu/+source/vte/+bug/2002290/+attachment/5640503/+files/apt%20output%20in%20gedit.png -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-terminal in

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-10 Thread M.Hanny Sabbagh
Hello Egmont. Thank you for the detailed reply and for fixing my understanding about these issues. I also highly appreciate your work and help! I was using the default font in Ubuntu, but when I changed it to Monospace 9 (or even 12) as you suggested, the spaces issues disappeared and the text

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-10 Thread M.Hanny Sabbagh
** Attachment added: "apt output in the browser with RTL.png" https://bugs.launchpad.net/ubuntu/+source/vte/+bug/2002290/+attachment/5640502/+files/apt%20output%20in%20the%20browser%20with%20RTL.png -- You received this bug notification because you are a member of Desktop Packages, which is

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-10 Thread M.Hanny Sabbagh
** Attachment added: "apt output in gnome terminal.png" https://bugs.launchpad.net/ubuntu/+source/vte/+bug/2002290/+attachment/5640501/+files/apt%20output%20in%20gnome%20terminal.png -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-10 Thread M.Hanny Sabbagh
** Attachment added: "gnome terminal with Monospace 12.png" https://bugs.launchpad.net/ubuntu/+source/vte/+bug/2002290/+attachment/5640500/+files/gnome%20terminal%20with%20Monospace%2012.png -- You received this bug notification because you are a member of Desktop Packages, which is

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-10 Thread M.Hanny Sabbagh
** Attachment added: "gnome terminal with Monospace 9 font.png" https://bugs.launchpad.net/ubuntu/+source/vte/+bug/2002290/+attachment/5640499/+files/gnome%20terminal%20with%20Monospace%209%20font.png -- You received this bug notification because you are a member of Desktop Packages, which

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-10 Thread Egmont Koblinger
To be absolutely fair, I have to add this: One thing, namely the handling of BiDi _control_ characters at the very beginning of a paragraph (logical line), remains as a TODO item both in the spec and in VTE's implementation (both of which are really nontrivial). I just ran out of motivation and

[Desktop-packages] [Bug 2002290] Re: Poor Arabic rendering in VTE

2023-01-10 Thread Egmont Koblinger
(I am the one who designed [1] and implemented RTL (right-to-left) and BiDi (bidirectional) text support in VTE.) The two issues you report here are totally independent. Re bug 1: Terminal emulators, by their very nature and their legacy of maybe ~50 years, _have to_ operate in a strict