Upstream bug showing "RESOLVED FIXED" on 2015-12-23
Checked functionality exists Thunderbird 60.2.1
Closing by marking "Fix Released"
** Changed in: thunderbird (Ubuntu)
Status: Triaged => Fix Released
--
You received this bug notification because you are a member of Desktop
Packages,
** Changed in: thunderbird
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the "From" field for the current email
** Changed in: thunderbird
Status: Confirmed = In Progress
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the From field for the current email only
(In reply to Ben Bucksch from comment #146)
Please note that there's a minor UI glitch here: We have 2 dropdown arrows,
as you can see in the screenshot. They both have the same effect. When
clicking the right one, the left one even shows a pressed state.
OK, so this is to do with the changes
Created attachment 8583150
Revised patch
Now resets the From address correctly when you select the current
identity from the drop-down, adds a one-time warning dialog, and removes
the Linux/OSX CSS because that wasn't working in its current state.
--
You received this bug notification because
So, top of the dropdown then?
No, the bottom is fine. We don't want this to be prominent.
Furthermore, the end makes sense, because this should only be used when none of
the other From addresses are OK. It's kind of a more option.
*All* the options in the dropdown change the textfield value.
(In reply to Thomas D. from comment #151)
Clicking at the low end of a dropdown to
edit the current entry at the top is bad UX imo.
So, top of the dropdown then? Or do you prefer attachment 8574154?
(In reply to Ben Bucksch from comment #147)
when I select the same identity that I originally
(In reply to Ben Bucksch (:BenB) from comment #147)
When I select an identity, click Customize From Address, and edit it, I
then can still select other identities, and they will apply. That's good.
But when I select the same identity that I originally selected, I do not
return to the original
I still think that the current UI for this is wrong because it's
disjunct/dislocated.
If we allow to edit the currently selected sender, then the control to start
that should be near that sender. Clicking at the low end of a dropdown to edit
the current entry at the top is bad UX imo.
Also,
UX input: I definitely want this feature pref'ed off. This is very
advanced stuff, and quite hazardous when used wrongly (users might not
notice, or too late, that their important emails haven't been sent by
server because they mis-tweaked their sender address). Just warning once
imo is not
Last but not least, we should probably add a one-time warning dialog,
like proposed in comment 142.
Aside from this (and reviews of course), this works very well, it's good
UI, and I think it's ready to land. The UI interaction is fairly natural
and very intuitive.
--
You received this bug
When I select an identity, click Customize From Address, and edit it, I then
can still select other identities, and they will apply. That's good.
But when I select the same identity that I originally selected, I do not return
to the original From address, but my edited one stays. That's odd. I'd
Created attachment 8581307
Screenshot of editable field (Linux)
After clicking on the last entry of the dropdown, labeled Customize
From Address, the field is editable (it's now a combobox).
When changing the value, it continues to use the identity that was
selected before, but uses the entered
Created attachment 8581305
Screenshot of normal dropdown (Linux)
This shows the dropdown when it's not yet editable. I can select
identities like before.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
Created attachment 8574154
Screenshot showing the moved menuitem
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the From field for the current email only
Comment on attachment 8572084
Possible patch
Review of attachment 8572084:
-
Options menu is the wrong place for this. If a checkbox, it should be in
Account Settings.
--
You received this bug notification because you are a member
(In reply to Ben Bucksch from comment #129)
* If you really want to pref this feature away, I think the best way would
be a checkbox in Account Settings... | Manage Identities
So, the presence of the customize option would depend on which
identity you had selected?
No, I'd make it so
Given the questioning about the nature of this, why is this being promoted as
a
core feature instead of as an addon? It seems to me this is exactly why we
have addons.
Please. You have to stop questioning features *after* they are
implemented. This bug is almost 14 years (!) old, and
FWIW, this is why I financed this patch and paid Neil to implement it,
in core TB.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the From field for the
I see no addon by the name of Virtual Identity...
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the From field for the current email only (as text, not
(In reply to n...@parkwaycc.co.uk from comment #133)
Created attachment 8572084
Possible patch
I hid the option in the Options menu where it might be less discoverable.
Screenshot would be nice.
(In reply to Thomas D. from comment #132)
- allow editing only after double-click on sender
https://www.absorb.it/virtual-id
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the From field for the current email only (as text, not
dropdown)
Status
Created attachment 8572084
Possible patch
I hid the option in the Options menu where it might be less
discoverable.
(In reply to Thomas D. from comment #132)
- allow editing only after double-click on sender (plus first-time warning)
Probably not possible because the popup code gets in the way.
(In reply to Ben Bucksch (:BenB) from comment #129)
(In reply to Josiah Bruner [:JosiahOne] (needinfo CC) from comment #125)
UI-Review:
- Customize From Address is confusing. “Enter a custom address” perhaps?
Customize From Address|Edit Sender vs. Enter a custom address are two
different
There is a fine addon out there called Virtual Identity which works well
(most of the time).
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the From field
I'm wary of anything that can't be found through Mozilla's directory...
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the From field for the current email
Given the questioning about the nature of this, why is this being
promoted as a core feature instead of as an addon? It seems to me this
is exactly why we have addons.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in
(In reply to Josiah Bruner from comment #128)
The backend changes in this patch causes it to not apply, that's all I was
noting. :)
Sure, but they'll get merged out when I update anyway.
What platform have you tested this on?
Windows and Linux.
(In reply to Ben Bucksch from comment #129)
*
(In reply to n...@parkwaycc.co.uk from comment #127)
(In reply to Josiah Bruner from comment #125)
- Customize From Address is confusing. “Enter a custom address” perhaps?
OK (but see below)
- If you choose a custom address (which focuses the field), and then you
deselect the field, and
that's when we're all whacking our heads on our desks
This could be solved with a one-time (i.e.: [ ] Show this again)
message dialog explaining the feature with a simple 4-line text.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to
(In reply to Josiah Bruner [:JosiahOne] (needinfo CC) from comment #125)
UI-Review:
- Customize From Address is confusing. “Enter a custom address” perhaps?
Agreed.
- What if users try to use it as a separate address and they don’t actually
have the account added to TB. Any replies to it
(In reply to Josiah Bruner from comment #125)
- Customize From Address is confusing. “Enter a custom address” perhaps?
OK (but see below)
- If you choose a custom address (which focuses the field), and then you
deselect the field, and click it again, we should show the drop down (don't
keep
I don't think we need to worry much about abuse, it's really easy to do already
if you're inclined to do so.
I do think servers these days are pickier than they used to so often it's not
allowed to use an alias, or (e.g. gmail) they fix the sender if it's not one
they accept. It would be good
Comment on attachment 8553148
Possible patch
Review of attachment 8553148:
-
Sorry for the delayed review!
UI-Review:
Minor Nits:
- Customize From Address is confusing. “Enter a custom address” perhaps?
- If you choose
Created attachment 8562431
Fixed fix
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the From field for the current email only (as text, not
dropdown)
Comment on attachment 8562431
Fixed fix
https://hg.mozilla.org/comm-central/rev/c3bf5c52ce41
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the From field
Comment on attachment 8561373
Test fix
Review of attachment 8561373:
-
::: mailnews/compose/test/unit/test_messageHeaders.js
@@ +91,5 @@
fields.organization = World Salvation Committee;
fields.subject = This is an obscure
Created attachment 8561373
Test fix
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the From field for the current email only (as text, not
dropdown)
Comment on attachment 8551328
Backend changes
https://hg.mozilla.org/comm-central/rev/6fe2526c838f
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the From
(In reply to Joshua Cranmer from comment #118)
+ from = MimeHeaders_get(mdd-headers, HEADER_FROM, false, false);
This hunk seems unnecessary?
I accidentally already checked it in without review, so this is post-
facto review, so to speak.
--
You received this bug notification
Comment on attachment 8551328
Backend changes
Review of attachment 8551328:
-
::: mailnews/mime/src/mimedrft.cpp
@@ +1203,5 @@
}
}
else
{
+ from = MimeHeaders_get(mdd-headers, HEADER_FROM, false,
Created attachment 8553148
Possible patch
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the From field for the current email only (as text, not
dropdown)
Created attachment 8551328
Backend changes
While you bikeshed over the UI, let me get the backend changes reviewed
(or post-facto reviewed in the case of the second hunk).
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in
FWIW: I (as original reporter of the bug on Launchpad) am using Virtual
Identity (https://www.absorb.it/virtual-id) since a long time already,
and it works great. It also provides a lot of advanced features which a
core implementation of this feature would not do.
--
You received this bug
(In reply to Josiah Bruner [:JosiahOne] (needinfo CC) from comment #109)
Created attachment 8544150
Example sketch.
I'm not sure if the sketch UI will work out well as presented; imo it
might easily create confusion and wrong assumptions about this feature.
From selector in compose UI of
UX-error-prevention / Pref
1) General interest and usefulness of this feature seem to have
declinied: Last duplicate of this bug filed 2006, 8 years ago. Only 4
supportive comments since 2005. As we speak, many common email-providers
do no longer allow defining random From values, to prevent
I think it's a reasonable idea to default this feature to off. If the
pref is hidden, maybe a double-click on the From should ask if user
wants to enable the pref? This would be a context-sensitive way to
expose this feature, which defaults to off.
Another use-case for this feature is adding a
Comment on attachment 8525381
Possible patch
Review of attachment 8525381:
-
Okay, I do like that addresses can be edited, and don't really have an
issue with it. However, it showing up when clicking the label isn't very
intuitive.
(In reply to Josiah Bruner from comment #109)
It would also be preferable to allow clicking the drop down icon to always
bring up the list, regardless of the field's current state.
It does on sane platforms, thus the original version always had the
field editable.
Just to make sure that we're
Created attachment 8544150
Example sketch.
Here's the example. In addition, if the user deselects the field without
inputting any text, we should revert the field back to being selectable
(with the options).
It would also be preferable to allow clicking the drop down icon to
always bring up the
(In reply to comment #111)
It does on sane platforms
OK that was a bit harsh but I can't reproduce your problems on Windows.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
(In reply to Josiah Bruner from comment #108)
+ from = MimeHeaders_get(mdd-headers, HEADER_FROM, false, false);
This is obsolete now (and the patch fails to apply because of it).
Whoops I accidentally checked that line in as part of bug 11039.
--
You received this bug notification
(In reply to Ben Bucksch (:BenB) from comment #104)
josiah: Ping
The patch still doesn't work properly. On my machine absolute nothing changes.
I pinged Neil about this on IRC today.(In reply to Ben Bucksch (:BenB) from
comment #105)
As for UX, I agree with Neil: Most common action would be
Josiah, sorry, I mis-attributed. I agree with your comment 102.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the From field for the current email only (as
josiah: Ping
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the From field for the current email only (as text, not
dropdown)
Status in Mozilla
As for UX, I agree with Neil: Most common action would be to select from
the dropdown, so that should be the big click target (most of the
widget), and the free edit should be an smaller Edit button.
--
You received this bug notification because you are a member of Desktop
Packages, which is
Created attachment 8525381
Possible patch
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the From field for the current email only (as text, not
dropdown)
(In reply to n...@parkwaycc.co.uk from comment #100)
Created attachment 8507858
87987.png
This is what I get locally... are you not seeing this?
No, hovering over the dropmarker doesn't do anything for me.
--
You received this bug notification because you are a member of Desktop
Packages,
Comment on attachment 8507858
87987.png
Ignoring the fact that the patch doesn't function properly for me, I'm
still not convinced this is the right approach.
I like that we're enabling custom editing, and am not against the
purpose of the bug, but I think this idea is putting too much emphasis
Created attachment 8507858
87987.png
This is what I get locally... are you not seeing this?
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864
Title:
Editing the From field
Although now the address can be edited (via keyboard), I can no longer
click on the header to select from my existing accounts as you can
currently.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
(In reply to Josiah Bruner from comment #97)
This completely removes the ability to choose from your accounts
It wasn't supposed to... what are you seeing?
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
Hmm... This completely removes the ability to choose from your accounts
though, and I don't think that's a good idea. This is significantly
harder to use. Was that your intent?
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird
Created attachment 8491619
Possible patch
This seems to work, it even remembers the address you entered if you
save a draft and reopen it later.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
(In reply to Launchpad from comment #94)
Use Virtual Identity: https://www.absorb.it/virtual-id/
It is very good, lots of options (too complicated at times) and it's
upadted on a regular basis (though not via the official addons site
[1]). It currently has a problem with TB 13 but I'm sure the
Do the same as in Kmail, please. I moved form Thunderbird to Kmail/1 in
2008 because Kmail/1 IMAP performance was magnitudes faster. I
reconsidered and moved back to Thunderbird a few months ago because
Kmail/1 has been replaced by Kmail/2 with degraded (understatment [1])
IMAP performance and
66 matches
Mail list logo
