[Desktop-packages] [Bug 434476]
We want to inhibit the screensaver when video is playing, not when *fullscreen* video is playing. It looks like the patch above is trying to only inhibit the screensaver for fullscreen video. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/434476 Title: screensaver starts while playing HTML5 videos Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Confirmed Status in “firefox-3.5” package in Ubuntu: Triaged Bug description: Binary package hint: firefox-3.5 karmic alpha6 + updates - click on a .ogv video link - after watching some time, screensaver starts. ProblemType: Bug Architecture: amd64 Date: Tue Sep 22 08:45:53 2009 DistroRelease: Ubuntu 9.10 NonfreeKernelModules: nvidia Package: firefox 3.5.3+build1+nobinonly-0ubuntu2 PackageArchitecture: all ProcEnviron: LANG=de_AT.UTF-8 SHELL=/bin/bash ProcVersionSignature: Ubuntu 2.6.31-10.34-generic SourcePackage: firefox-3.5 Uname: Linux 2.6.31-10-generic x86_64 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/434476/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 434476]
I think you want the screen topic, and the locked-foreground state to denote when to disable the screen saver. HTMLMediaElement should already manage only disabling the screen saver when media is playing and in a foreground tab, and bug 1022669 is being worked on right now to ensure that we don't take a screen wake lock for audio-only media. Edwin's point is that we shouldn't be taking non-screen wakelocks on desktop, they're meant for battery constrained mobile devices; for example the cpu wakelock code in HTMLMediaElement.cpp should really be behind b2g and android include guards. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/434476 Title: screensaver starts while playing HTML5 videos Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Confirmed Status in “firefox-3.5” package in Ubuntu: Triaged Bug description: Binary package hint: firefox-3.5 karmic alpha6 + updates - click on a .ogv video link - after watching some time, screensaver starts. ProblemType: Bug Architecture: amd64 Date: Tue Sep 22 08:45:53 2009 DistroRelease: Ubuntu 9.10 NonfreeKernelModules: nvidia Package: firefox 3.5.3+build1+nobinonly-0ubuntu2 PackageArchitecture: all ProcEnviron: LANG=de_AT.UTF-8 SHELL=/bin/bash ProcVersionSignature: Ubuntu 2.6.31-10.34-generic SourcePackage: firefox-3.5 Uname: Linux 2.6.31-10-generic x86_64 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/434476/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 434476]
Because opinions differ. ;) We also want non-fullscreen video and webrtc chats to disable the screensaver. I, for one, find it very annoying when I'm watching a non- fullscreen video and the screensaver kicks in. FYI, there's code in HTMLMediaElement to ensure the screensaver is only disabled when the video is actually in a visible region of the webpage, in a foreground tab. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/434476 Title: screensaver starts while playing HTML5 videos Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Confirmed Status in “firefox-3.5” package in Ubuntu: Triaged Bug description: Binary package hint: firefox-3.5 karmic alpha6 + updates - click on a .ogv video link - after watching some time, screensaver starts. ProblemType: Bug Architecture: amd64 Date: Tue Sep 22 08:45:53 2009 DistroRelease: Ubuntu 9.10 NonfreeKernelModules: nvidia Package: firefox 3.5.3+build1+nobinonly-0ubuntu2 PackageArchitecture: all ProcEnviron: LANG=de_AT.UTF-8 SHELL=/bin/bash ProcVersionSignature: Ubuntu 2.6.31-10.34-generic SourcePackage: firefox-3.5 Uname: Linux 2.6.31-10-generic x86_64 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/434476/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 434476]
Comment on attachment 8401684
Implement WakeLockListener on Linux to disable screensaver while video is
playing
Review of attachment 8401684:
-
This is the behaviour we want (locking video irrespective of whether
we're fullscreen or not), but someone who has a clue about Linux should
also review this. Karl?
::: widget/gtk/nsAppShell.cpp
@@ +93,5 @@
+ FREEDESKTOP_SCREENSAVER_OBJECT,
+ FREEDESKTOP_SCREENSAVER_INTERFACE,
+ p_method);
+}
+else {
} else {
@@ +120,5 @@
+ DBUS_TYPE_STRING, application,
+ DBUS_TYPE_STRING, reason,
+ DBUS_TYPE_INVALID);
+}
+else {
} else {
@@ +391,1 @@
return nsBaseAppShell::Init();
You should probably remove the listener during shutdown too.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while playing HTML5 videos
Status in The Mozilla Firefox Browser:
Confirmed
Status in “firefox” package in Ubuntu:
Confirmed
Status in “firefox-3.5” package in Ubuntu:
Triaged
Bug description:
Binary package hint: firefox-3.5
karmic alpha6 + updates
- click on a .ogv video link
- after watching some time, screensaver starts.
ProblemType: Bug
Architecture: amd64
Date: Tue Sep 22 08:45:53 2009
DistroRelease: Ubuntu 9.10
NonfreeKernelModules: nvidia
Package: firefox 3.5.3+build1+nobinonly-0ubuntu2
PackageArchitecture: all
ProcEnviron:
LANG=de_AT.UTF-8
SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.34-generic
SourcePackage: firefox-3.5
Uname: Linux 2.6.31-10-generic x86_64
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/434476/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 434476]
(In reply to Lawrence Mandel [:lmandel] from comment #40) I discussed this issue with the desktop team (Chad, Madhava, Gavin). This is not a high priority for them right now. As such, dropping the tracking flag. From comment 36 I take it that this has already been fixed on Windows in another bug. (Bug ref?) Windows: bug 968603. If that is correct, are there other follow up bugs for the other platforms? Is there work to do in this bug? Linux: bug 811261 B2G: Already fixed by some unknown bug MacOSX: Bug 772347 Android: fixed in bug 739542 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/434476 Title: screensaver starts while playing HTML5 videos Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: New Status in “firefox-3.5” package in Ubuntu: Triaged Bug description: Binary package hint: firefox-3.5 karmic alpha6 + updates - click on a .ogv video link - after watching some time, screensaver starts. ProblemType: Bug Architecture: amd64 Date: Tue Sep 22 08:45:53 2009 DistroRelease: Ubuntu 9.10 NonfreeKernelModules: nvidia Package: firefox 3.5.3+build1+nobinonly-0ubuntu2 PackageArchitecture: all ProcEnviron: LANG=de_AT.UTF-8 SHELL=/bin/bash ProcVersionSignature: Ubuntu 2.6.31-10.34-generic SourcePackage: firefox-3.5 Uname: Linux 2.6.31-10-generic x86_64 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/434476/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 434476]
The fix for this will ship on Windows in Firefox 30. Other platforms hopefully will make by Firefox 30 or soon after. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/434476 Title: screensaver starts while playing HTML5 videos Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: New Status in “firefox-3.5” package in Ubuntu: Triaged Bug description: Binary package hint: firefox-3.5 karmic alpha6 + updates - click on a .ogv video link - after watching some time, screensaver starts. ProblemType: Bug Architecture: amd64 Date: Tue Sep 22 08:45:53 2009 DistroRelease: Ubuntu 9.10 NonfreeKernelModules: nvidia Package: firefox 3.5.3+build1+nobinonly-0ubuntu2 PackageArchitecture: all ProcEnviron: LANG=de_AT.UTF-8 SHELL=/bin/bash ProcVersionSignature: Ubuntu 2.6.31-10.34-generic SourcePackage: firefox-3.5 Uname: Linux 2.6.31-10-generic x86_64 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/434476/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 434476]
We should disable the screen save for non-fullscreen playback too. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/434476 Title: screensaver starts while playing HTML5 videos Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: New Status in “firefox-3.5” package in Ubuntu: Triaged Bug description: Binary package hint: firefox-3.5 karmic alpha6 + updates - click on a .ogv video link - after watching some time, screensaver starts. ProblemType: Bug Architecture: amd64 Date: Tue Sep 22 08:45:53 2009 DistroRelease: Ubuntu 9.10 NonfreeKernelModules: nvidia Package: firefox 3.5.3+build1+nobinonly-0ubuntu2 PackageArchitecture: all ProcEnviron: LANG=de_AT.UTF-8 SHELL=/bin/bash ProcVersionSignature: Ubuntu 2.6.31-10.34-generic SourcePackage: firefox-3.5 Uname: Linux 2.6.31-10-generic x86_64 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/434476/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 434476]
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness, emailacopolypse) from comment #29) (In reply to comment #28) We should disable the screen save for non-fullscreen playback too. Why? Some websites use video as an element in their design these days (for example, as the page background.) It seems counter intuitive for such a website to disable the screen saver! Because sometimes you want to watch a video non-fullscreen with duration longer than your screensaver's timeout? I certainly don't fullscreen all the videos I watch. I think it would be hard to programmatically distinguish between the non fullscreen foreground case and all permutations of the video-as-page- background use case you describe. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/434476 Title: screensaver starts while playing HTML5 videos Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: New Status in “firefox-3.5” package in Ubuntu: Triaged Bug description: Binary package hint: firefox-3.5 karmic alpha6 + updates - click on a .ogv video link - after watching some time, screensaver starts. ProblemType: Bug Architecture: amd64 Date: Tue Sep 22 08:45:53 2009 DistroRelease: Ubuntu 9.10 NonfreeKernelModules: nvidia Package: firefox 3.5.3+build1+nobinonly-0ubuntu2 PackageArchitecture: all ProcEnviron: LANG=de_AT.UTF-8 SHELL=/bin/bash ProcVersionSignature: Ubuntu 2.6.31-10.34-generic SourcePackage: firefox-3.5 Uname: Linux 2.6.31-10-generic x86_64 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/434476/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 434476]
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness, emailacopolypse) from comment #32) Can we at least do that for videos which have started playback as a result of a user action? Sure, that sounds like a good idea. Reasonable even. We may need to wait for bug 966493 to be fixed first, otherwise nsEventStateManager::IsHandlingUserInput() won't count touch events as user generated, and we may regress disabling the screensaver on B2G. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/434476 Title: screensaver starts while playing HTML5 videos Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: New Status in “firefox-3.5” package in Ubuntu: Triaged Bug description: Binary package hint: firefox-3.5 karmic alpha6 + updates - click on a .ogv video link - after watching some time, screensaver starts. ProblemType: Bug Architecture: amd64 Date: Tue Sep 22 08:45:53 2009 DistroRelease: Ubuntu 9.10 NonfreeKernelModules: nvidia Package: firefox 3.5.3+build1+nobinonly-0ubuntu2 PackageArchitecture: all ProcEnviron: LANG=de_AT.UTF-8 SHELL=/bin/bash ProcVersionSignature: Ubuntu 2.6.31-10.34-generic SourcePackage: firefox-3.5 Uname: Linux 2.6.31-10-generic x86_64 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/434476/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 434476]
We already use the power manager service to create a screen wake lock to disable the screen saver in HTMLVideoElement::WakeLockUpdate(), but the wake lock listener that actually disables the screen saver is only implemented for B2G and I think Android, but not on other platforms. I have a patch in Bug 968603 to implement a wake lock listener on Windows, so we'll disable the screensaver on Windows during video playback. To fix this on other platforms, we'll need to add wake lock listeners for them too. I suggest we use this bug to track when support for Mac, Linux, and Windows (and Android if it hasn't already) have all landed. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/434476 Title: screensaver starts while playing HTML5 videos Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: New Status in “firefox-3.5” package in Ubuntu: Triaged Bug description: Binary package hint: firefox-3.5 karmic alpha6 + updates - click on a .ogv video link - after watching some time, screensaver starts. ProblemType: Bug Architecture: amd64 Date: Tue Sep 22 08:45:53 2009 DistroRelease: Ubuntu 9.10 NonfreeKernelModules: nvidia Package: firefox 3.5.3+build1+nobinonly-0ubuntu2 PackageArchitecture: all ProcEnviron: LANG=de_AT.UTF-8 SHELL=/bin/bash ProcVersionSignature: Ubuntu 2.6.31-10.34-generic SourcePackage: firefox-3.5 Uname: Linux 2.6.31-10-generic x86_64 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/434476/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
Comment on attachment 765205 Better error message Review of attachment 765205: - A build peer should review this. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “iceweasel” package in Debian: Confirmed Status in “firefox” package in Fedora: Unknown Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
Excellent, thanks Ralph. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “iceweasel” package in Debian: Confirmed Status in “firefox” package in Fedora: Unknown Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
Comment on attachment 763014
Enable gstreamer by default, preffed off
Review of attachment 763014:
-
r=cpearce for the changes other than those in configure.in. I'll leave
that to khuey.
::: configure.in
@@ +5754,5 @@
dnl
dnl = Enable GStreamer
dnl
+
+if test $OS_TARGET = Linux; then
Doesn't this mean you're turning on building GStreamer on Linux, but not
providing a way to disable it since you only have an --enable-gstreamer
option? You should have way to disable gstreamer support, for Linux
systems without GStreamer, or those who choose to not have it.
::: content/media/DecoderTraits.cpp
@@ +326,5 @@
result = CANPLAY_YES;
}
#endif
#ifdef MOZ_GSTREAMER
+ if (MediaDecoder::IsGStreamerEnabled()
Put the MediaDecoder::IsGStreamerEnabled() check inside
GStreamerDecoder::CanHandleMediaType(). It can't handle anything if it's
disabled right?
::: content/media/test/manifest.js
@@ +680,3 @@
var oldOpus = undefined;
try {
+oldGStreamer = branch.getBoolPref(gstreamer.enabled);
IIRC getBoolPref throws if a pref isn't found. Meaning that we won't
check the defaults for the other prefs, if say gstreamer.enabled isn't
defined on the platform the test is running on (i.e. Windows).
Please put each of these get*Pref calls inside their own try{}catch(){}
block.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1051559
Title:
Build Firefox with GStreamer support
Status in The Mozilla Firefox Browser:
Confirmed
Status in “firefox” package in Ubuntu:
Triaged
Status in “iceweasel” package in Debian:
Confirmed
Status in “firefox” package in Fedora:
Unknown
Bug description:
Building Firefox with GStreamer support would provide support for a lot of
websites that use h264.
To build Firefox with GStreamer support you should use the
--enable-gstreamer option.
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
(In reply to Alessandro Decina from comment #56)
(In reply to Chris Pearce (:cpearce) from comment #54)
I built latest trunk on my Fedora box this morning with --enable-gstreamer,
and I still get the following test failure in
content/media/test/test_buffered.html:
TEST-UNEXPECTED-FAIL| unknown test url | owl.mp3: First range end should be
media end - got 3.368, expected 3.3698
I will look into this, but isn't the resolution we're checking a bit too
high?
Some consumers of the audio content may rely on the duration being
accurate, like web apps using the decoded file via WebAudio or
MediaStreams API for example.
Do all the backends report exactly that duration or is it just that
the test written against a specific backend?
Hmm... The Windows Media Foundation backend is reporting a duration of
3.343673 or that file, and content/media/test/manifest.js lists its
duration as 3.29. :{
Anyway, the test that's failing is:
http://mxr.mozilla.org/mozilla-central/source/content/media/test/test_buffered.html?force=1#34
This is checking if video.buffered.end(0)==video.duration
I think you can make this test pass by changing GStreamerReader::GetBuffered()
to cap the range end time to the media duration here:
http://mxr.mozilla.org/mozilla-central/source/content/media/gstreamer/GStreamerReader.cpp#601
I see that GStreamerReader::GetBuffered() is using
gst_element_query_convert()... Does gst_element_query_convert() just do
a byteoffset/length*duration estimation, or is it using some deeper
understanding of the stream in order to get more accurate byte-to-
timestamp mappings?
If gst_element_query_convert() is just doing an estimation, you could
just use GetEstimatedBufferedTimeRanges() [http://mxr.mozilla.org
/mozilla-central/source/content/media/VideoUtils.h#142] instead, it's
used in other backends already to estimate the buffered ranges, and caps
the end time of the buffered ranges to the duration.
I tested this, I removed by gstreamer plugins and
test_can_play_type_mpeg.html fails across the board.
Is it failing in the expected way?
Yep.
Yes 3gpp was copied there from the list of codecs supported by GONK i think.
I'll remove it.
Great, thanks!
And we should also refuse to play the file if either the audio or video
stream are present but of unsupported formats as well... Does our GStreamer
backend already do this?
Attachment #72711 [details] [diff] does this, although i'm not sure the
behaviour is 100% right.
Thanks! I will test this patch's behaviour.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1051559
Title:
Build Firefox with GStreamer support
Status in The Mozilla Firefox Browser:
Confirmed
Status in “firefox” package in Ubuntu:
Triaged
Status in “iceweasel” package in Debian:
New
Status in “firefox” package in Fedora:
Unknown
Bug description:
Building Firefox with GStreamer support would provide support for a lot of
websites that use h264.
To build Firefox with GStreamer support you should use the
--enable-gstreamer option.
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
Comment on attachment 727111
gst codec whitelist
That looks fine, it behaves as expected and stops playback of the 3GPP
container in particular.
Mochitests timeout in test_buffered for me now though, and the fix I
suggested of clamping the buffered ranges at duration didn't seem to fix
the test_buffered failure either. :{
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1051559
Title:
Build Firefox with GStreamer support
Status in The Mozilla Firefox Browser:
Confirmed
Status in “firefox” package in Ubuntu:
Triaged
Status in “iceweasel” package in Debian:
New
Status in “firefox” package in Fedora:
Unknown
Bug description:
Building Firefox with GStreamer support would provide support for a lot of
websites that use h264.
To build Firefox with GStreamer support you should use the
--enable-gstreamer option.
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
(In reply to Alessandro Decina from comment #55) Created attachment 727111 gst codec whitelist This patch makes the gst backend stop in ReadMetadata if the stream being decoded includes unsupported codecs. I'm not sure it's stopping in the right place, it makes playing http://www.tools4movies.com/dvd_catalyst_profile_samples/ Harold%20Kumar%203%20Christmas%20bionic%20fast.mp4 fail with a video has stopped playing since the file is corrupt message. This is the same behaviour that we have on Windows. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “iceweasel” package in Debian: New Status in “firefox” package in Fedora: Unknown Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
I built latest trunk on my Fedora box this morning with --enable- gstreamer, and I still get the following test failure in content/media/test/test_buffered.html: TEST-UNEXPECTED-FAIL| unknown test url | owl.mp3: First range end should be media end - got 3.368, expected 3.3698 (In reply to Henri Sivonen (:hsivonen) from comment #5) (In reply to Chris Double (:doublec) from comment #3) I think we should enable GStreamer in Linux builds even if we don't support H.264 in the other platforms yet. Things to be resolved before we can do this though: 1) Get the mochitest media tests passing. There's a H.264 video file in the tests already. Almost there. 2) Ensure Firefox still runs on Linux distributions that don't have GStreamer or have older versions. I haven't done this. 3) Check that we have new enough GStreamer libraries on build machines. We don't have any GStreamer libs on our build machines. We should get our regression tests running, even if we're not shipping builds with GStreamer enabled ourselves. 4) Check that when MP4, H.264 and AAC support is present, canPlayType() behaves as in other H.264 and AAC-supporting browsers. See bug 760140. This is tested by our mochitest content/media/test/test_can_play_type_mpeg.html I checked and this test is passing, so we're reporting that we can at least all the things that we should. 5) Test that when both H.264 and AAC decoders are absent, canPlayType() behaves like in Firefox today even if an MP4 demuxer is present. I tested this, I removed by gstreamer plugins and test_can_play_type_mpeg.html fails across the board. 6) Test that MPEG4 Visual, MPEG2 or other non-H.264, non-AAC encumbered codecs do not get exposed to the Web as a side effect. I'm not sure that this is the case. I see that 3gpp is listed in GStreamerFormatHelper::mCodecs, we don't want that being exposed in canPlayType or for it to be playable. It's also doesn't look like the GStreamer backend is whitelisting only the codecs that we want to support though. We'd want to only support H264, AAC and MP3, so as to prevent further format proliferation. For example this video plays with GStreamer, but shouldn't: http://www.tools4movies.com/dvd_catalyst_profile_samples/Harold%20Kumar%203%20Christmas%20bionic%20fast.mp4 The video stream here is MPEG-4 part 2. No other browsers play that file; we can but refuse to in the Windows Media Foudation backend (bug 839055). And we should also refuse to play the file if either the audio or video stream are present but of unsupported formats as well... Does our GStreamer backend already do this? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “iceweasel” package in Debian: New Status in “firefox” package in Fedora: Unknown Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
(In reply to Alessandro Decina from comment #46) In addition to that, we could potentially consider importing the ogg/webm/h264 gst plugins in m-c so there's even more control over those. I'd rather keep our existing backends/libraries for decoding Ogg and WebM unless there's a compelling reason to switch to using GStreamer for those formats. Our Ogg and WebM libraries have been fuzzed pretty hard over the years, and our backends using those libraries have been well tested and are known to be robust and work well. We don't really want to redo all that robustification work for Ogg and WebM, we won't gain much by doing that now. Keeping our existing libraries also ensures Firefox's media playback behaviour is more likely to remain consistent across all platforms. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “iceweasel” package in Debian: New Status in “firefox” package in Fedora: Unknown Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
You can already set the pref media.prefer-gstreamer to true if you want to play WebM and Ogg with GStreamer in Firefox. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “iceweasel” package in Debian: New Status in “firefox” package in Fedora: Unknown Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
(In reply to Chris Pearce (:cpearce) from comment #31) One of the reasons I am interested in this bug is due to what seems to be much better video acceleration code in gStreamer vs Firefox. At least could it be be made an about:config option, pass all to gstreamer? Sure, I will do this, it's a good idea. I'm doing this in bug 803287. Just landed this change. I also renamed the pref to enable gstreamer, and nsHTMLMediaElement's gstreamer related functions, from .*H264.* to .*GStreamer.*, since we'll have other backends which also provide H.264 playback on other platforms. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
(In reply to Chris Pearce (:cpearce) from comment #27) This decision also motivated by the fact that we know our built in decoders work reliably, and we know that the GStreamer backend has some problems; it fails our unit tests, so we know there are bugs either in GStreamer or in our use of it. Some of the test failures with GStreamer were due to the test file having the wrong duration listed in its manifest, I fixed that in bug 803427. I'm going to change our decoder creation code in bug 799344 to not use GStreamer for Ogg and WebM. One of the reasons I am interested in this bug is due to what seems to be much better video acceleration code in gStreamer vs Firefox. At least could it be be made an about:config option, pass all to gstreamer? Sure, I will do this, it's a good idea. I'm doing this in bug 803287. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
(In reply to Bryan Quigley from comment #24) (In reply to Chris Pearce (:cpearce) from comment #19) We talked about this in Auckland, and we'd prefer to use our existing built-in backends for Ogg and WebM, since they've been fuzz tested and we know they're reliable. Maybe I'm misunderstanding this, but are there outstanding exploits that Mozilla found that haven't made it upstream yet to Ogg, WebM? If it is gStreamer specific, but not the codecs, then all someone would need to do is use H264 to exploit it. We apply several patches on top of our libvpx, and a couple on top of the Xiph Ogg libraries. I don't know if these have been fixed upstream yet. Possibly some or all of these patches have been upstreamed and our libraries are behind current-stable versions. This decision also motivated by the fact that we know our built in decoders work reliably, and we know that the GStreamer backend has some problems; it fails our unit tests, so we know there are bugs either in GStreamer or in our use of it. I'm going to change our decoder creation code in bug 799344 to not use GStreamer for Ogg and WebM. One of the reasons I am interested in this bug is due to what seems to be much better video acceleration code in gStreamer vs Firefox. At least could it be be made an about:config option, pass all to gstreamer? Sure, I will do this, it's a good idea. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
We talked about this in Auckland, and we'd prefer to use our existing built-in backends for Ogg and WebM, since they've been fuzz tested and we know they're reliable. I'm going to change our decoder creation code in bug 799344 to not use GStreamer for Ogg and WebM. (And my GStreamer is whatever is the current up-to-date version in Ubuntu 12.04. I don't think we should rely on users having a newer version.) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
Created attachment 670672 GStreamer backend mochitest failures (with GStreamer only playing H.264, not Ogg or WebM) Additionally, the mochitests fail with the GStreamer backend enabled. Currently the GStreamer backend takes over playback of Ogg and WebM resources when it's enabled, and Firefox times out trying to run test_buffered because GStreamer can't handle playing Opus in Ogg. test_a4_tone also fails. If I change our code to use our existing Ogg/WebM backends for Ogg/WebM when the GStreamer backend is enabled (so GStreamer only plays H.264, not Ogg or WebM), the test run completes but with test failures and a shutdown hang with the decode thread stuck in nsGStreamerReader::WaitForDecodedData(). The unexpected test failures from the mochitest run's log are attached. Looks like mostly problems with duration calculation. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 412647]
(In reply to Sid from comment #298) Just in case, SDK is out. http://gstreamer.com/ In the Windows installation instructions they recommend removing the client app's dependency on MSVC2010's runtime DLL and using the “basic” C runtime which comes in every Windows system since Windows XP, and is named MSVCRT.DLL. See: Removing the dependency with the Visual Studio runtime http://docs.gstreamer.com/display/GstSDK/Installing+on+Windows We apparently ship with the MSVC 2010's RT, and switching runtimes makes me nervous... Were we to ship this on Windows, we may be best to build the SDK ourselves with MSVCRT2010 or get Collabora to build one with MSVCRT2010. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/412647 Title: Firefox is not able to play mp4 video tags Status in The Mozilla Firefox Browser: Fix Released Status in “firefox” package in Ubuntu: Triaged Bug description: Binary package hint: firefox With firefox 3.5 html5 was introduced. However only ogg is supported as it seems. The html5-preview on youtube.com (http://www.youtube.com/html5) doesn't work at all, but it does play in safari and epiphany-webkit. Please make firefox able to install video codecs or use the ones avaible through gstreamer. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/412647/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
