[Desktop-packages] [Bug 1008344] Re: checks "admin" group membership instead of querying polkit

2018-08-22 Thread Bug Watch Updater
** Changed in: policykit Status: Confirmed => Unknown -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to language-selector in Ubuntu. https://bugs.launchpad.net/bugs/1008344 Title: checks "admin" group membership instead of

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2014-07-08 Thread Launchpad Bug Tracker
This bug was fixed in the package language-selector - 0.129.1 --- language-selector (0.129.1) trusty-proposed; urgency=low * LanguageSelector/gtk/GtkLanguageSelector.py, help/C/index.docbook: - Make the Apply System-Wide and Install / Remove Languages... buttons sensitive

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2014-07-01 Thread Gunnar Hjalmarsson
I have installed language-selector-gnome 0.129.1 from trusty-proposed and - unlike before - when logged in as a standard user, the buttons in question are sensitive and I'm able to make system wide changes if providing an admin password. ** Tags removed: verification-needed ** Tags added:

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2014-07-01 Thread Chris J Arges
Hello Philipp, or anyone else affected, Accepted language-selector into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/language- selector/0.129.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package.

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2014-06-26 Thread Gunnar Hjalmarsson
Hi Philipp! Right, the language-selector UI will live longer than we thought, and nothing has happened with Martin's freedesktop bug about PolicyKit. I have made a change that I think is a reasonable way to deal with this issue. You won't be prompted to install possible missing language support

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2014-06-26 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/language-selector -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to language-selector in Ubuntu. https://bugs.launchpad.net/bugs/1008344 Title: checks admin group membership instead of querying polkit Status

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2014-06-26 Thread Gunnar Hjalmarsson
** Changed in: language-selector (Ubuntu Trusty) Importance: Undecided = Medium ** Changed in: language-selector (Ubuntu Trusty) Status: New = In Progress ** Changed in: language-selector (Ubuntu Trusty) Assignee: (unassigned) = Gunnar Hjalmarsson (gunnarhj) -- You received this

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2014-06-26 Thread Launchpad Bug Tracker
This bug was fixed in the package language-selector - 0.131 --- language-selector (0.131) utopic; urgency=low * LanguageSelector/gtk/GtkLanguageSelector.py, help/C/index.docbook: - Make the Apply System-Wide and Install / Remove Languages... buttons sensitive also for

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2014-05-09 Thread Philipp Wendler
Now the S development cycle has passed, and I installed Ubuntu 14.04 and there is still the same dialog, and it has still the same problem. Is there now a chance that this gets revisited? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2013-02-04 Thread Gunnar Hjalmarsson
Philipp, Maybe the solution you propose is easy to implement if you know how to do it. I for one don't. Please feel free to provide code. The language-selector UI is planned to be replaced in the standard Ubuntu distribution by the corresponding UI in gnome-control-center. It will probably

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2013-01-31 Thread Gunnar Hjalmarsson
I'm disinclined to propose that the is_admin check is dropped, since it would degenerate the UI for a lot of (non-admin) users. I think that the check for missing langpacks would make that route especially bad, and personally I'd prefer to leave the bug open for the time being. Martin, what's

Re: [Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2013-01-31 Thread Martin Pitt
Gunnar Hjalmarsson [2013-02-01 0:49 -]: Martin, what's your estimate of how long it will take before the polkit people deal with your bug? Really hard to say, it depends on the available time and mood of the polkit authors. Could be anything from a few days to many weeks; we should at

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2013-01-31 Thread Philipp Wendler
Please, drop the is_admin check completely. I said it already: you cannot know whether the user knows the password of an admin account if you do not ask for it. If you try guessing, you will inevitable guess wrong sometimes and frustrate the user. This is also true if polkit does the guessing.

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2013-01-30 Thread Gunnar Hjalmarsson
Thanks, Martin. Unfortunately I can't reproduce your Not authorized. case: $ pkcheck --action-id com.ubuntu.languageselector.setsystemdefaultlanguage --process $$ polkit\56retains_authorization_after_challenge=1 Authorization requires authentication and -u wasn't passed. $ groups test-std $ cat

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2013-01-30 Thread Martin Pitt
I previously just tried this under su, but I fell into the trap that this looks at allow_inactive, not allow_active. Sorry about that. I filed an upstream polkit bug to get access to this information, as this is IMHO the only clean way of fixing this. Until then, I suggest to either leave that

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2013-01-30 Thread Bug Watch Updater
Launchpad has imported 1 comments from the remote bug at https://bugs.freedesktop.org/show_bug.cgi?id=60103. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2013-01-29 Thread Martin Pitt
The problem is that polkit responds with no, but you can authenticate (or something like it) also for standard users. Hm, I get a different error message depending whether or not the user is an admin: for my user (which is an admin): $ pkcheck --action-id

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2013-01-27 Thread Gunnar Hjalmarsson
Trying to summarize the suggestions so far: * Ask polkit I failed to make polkit provide the info we would need. If somebody knows how to do that, it would probably be the best and easiest solution. The code in the linked branch may or may not be useful as a starting point. * Drop the is_admin

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2013-01-02 Thread Philipp Wendler
I would get rid of greying out these buttons completely. You will never know whether the user is able to authenticate as admin, because you cannot know whether the user knows the password of an admin account if you do not ask for it. In all cases where the buttons are greyed out, but the user

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2013-01-02 Thread Nikki VonHollen
philw85: I completely agree. The time settings dialog is a great example for how this should work. I think it's also fine to just let PolicyKit prompt when it needs to without telling the user beforehand. Average Ubuntu users are going to be admins on their single-user systems, and where users

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2013-01-01 Thread Gunnar Hjalmarsson
On 2012-12-31 20:54, Steve Langasek wrote: On Mon, Dec 31, 2012 at 06:16:40PM -, Gunnar Hjalmarsson wrote: Seems like it says no, but you can authenticate by providing the credentials for an admin user. And that's not what we want to know, is it? Yes, it is. That's how polkit works

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2012-12-31 Thread Gunnar Hjalmarsson
If we can't make polkit provide the desired information without real authentication attempts, and since this is a GUI issue and not a security issue, maybe a gsettings key could be a sufficient solution to this bug. try: gsettings_value = subprocess.check_output( ['gsettings', 'get',

Re: [Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2012-12-31 Thread Martin Pitt
Gunnar Hjalmarsson [2012-12-31 14:27 -]: If we can't make polkit provide the desired information without real authentication attempts This is possible. The polkit API has a flag to enable/disable interactivity, depending on which you either get a no, but you can authenticate, or a yes

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2012-12-31 Thread Gunnar Hjalmarsson
On 2012-12-31 15:51, Martin Pitt wrote: Gunnar Hjalmarsson [2012-12-31 14:27 -]: If we can't make polkit provide the desired information without real authentication attempts This is possible. The polkit API has a flag to enable/disable interactivity, depending on which you either get a

Re: [Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2012-12-31 Thread Steve Langasek
On Mon, Dec 31, 2012 at 06:16:40PM -, Gunnar Hjalmarsson wrote: The problem is that polkit responds with no, but you can authenticate (or something like it) also for standard users. Seems like it says no, but you can authenticate by providing the credentials for an admin user. And that's

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2012-12-29 Thread Gunnar Hjalmarsson
Thanks for the hints, Martin. I gave up on ls-dbus-backend, discovered gir1.2-polkit-1.0 and wrote a new function in utils.py. Now the code runs, but there is a tiny problem: AdminPrivileges() always returns True. :( On 2012-12-23 10:56, Martin Pitt wrote: But with polkit we can probably just

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2012-12-23 Thread Martin Pitt
I'm not sure why this doesn't work, as other parts of the code do the same. However, this is not what you want anyway: This check would already authenticate, i. e. you would get a password prompt right at the startup of l-s just for checking if you are an administrator. Instead, this should query

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2012-12-21 Thread Gunnar Hjalmarsson
** Branch linked: lp:~desktop-bugs/ubuntu/raring/language-selector/auth -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to language-selector in Ubuntu. https://bugs.launchpad.net/bugs/1008344 Title: checks admin group membership instead

[Desktop-packages] [Bug 1008344] Re: checks admin group membership instead of querying polkit

2012-12-21 Thread Gunnar Hjalmarsson
I linked an experimental branch to this bug, where I show a first attempt to change language-selector in this respect. It doesn't work, though. This line (144): obj = bus.get_object('com.ubuntu.LanguageSelector','/') results in the error: Could not get owner of name 'com.ubuntu.LanguageSelector'