** Changed in: inkscape (Ubuntu)
Status: Triaged = Fix Released
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to inkscape in Ubuntu.
https://bugs.launchpad.net/bugs/773288
Title:
border on top and border shadow options are still
** Changed in: inkscape
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to inkscape in Ubuntu.
https://bugs.launchpad.net/bugs/773288
Title:
border on top and border shadow options are still
** Tags removed: patch
** Tags added: patch-accepted-upstream
** Changed in: inkscape (Ubuntu)
Status: Confirmed = Triaged
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to inkscape in Ubuntu.
https://bugs.launchpad.net/bugs/773288
Fix committed revision 11863.
The whole function (and not only your changes, that after all were quite
consistent with the rest) needed some coding style changes to improve
readability.
demicoder, thanks for your patch!
** Changed in: inkscape
Status: In Progress = Fix Committed
**
Patch to the bug.
** Patch added: 7773288-disable-page-border-options_Version3.diff
https://bugs.launchpad.net/inkscape/+bug/773288/+attachment/3414210/+files/7773288-disable-page-border-options_Version3.diff
--
You received this bug notification because you are a member of Desktop
Final bug patch.
Goals achieved:
1.) 'Border On Top' and 'Show Page Border' are grayed out when 'Show Page
Border' is unchecked.
2.) 'Border On Top' and 'Show Page Border' are indented right just enough to
give an intuitive feel that these are suboptions of 'Show Border'.
** Patch added:
Patch '7773288-disable-page-border-options_Version4.diff' tested successfully
with Inkscape 0.48+devel r11829 on OS X 10.7.4:
- GTK+/X11 2.24.13, gtkmm 2.24.2
- GTK+/Quartz 2.24.13, gtkmm 2.24.2
- GTK+/X11 3.4.4, gtkmm 3.4.0
- GTK+/Quartz 3.6.1, gtkmm 3.6.0
(Note: Default Gnome theme 'Adwaita'
Tested successfully on Ubuntu 11.04, Inkscape trunk revision 11829.
Just a note on the coding style: the patch doesn't follow the coding
recommendations (see http://inkscape.org/doc/coding_style.php), and
shows braces and indentation issues. Would you be willing to fix it?
--
You received this
Attaching a screenshot to illustrate the first point described in comment #6:
- A new default document, which renders the page border as well as shows the
page border shadow.
- 'Document properties Page Border' settings which has '[ ] Show border
shadow' not checked, despite it being shown.
To
Attaching a screenshot to illustrate the second item described in comment #6:
- A custom document created and saved with unpatched Inkscape: renders page
border, but no border shadow
- 'Document properties Page Border' has '[ ] Show border shadow'
insensitive (i.e. cannot be changed)
To me
** Attachment added: 773288-custom-document-without-shadow-1.png
https://bugs.launchpad.net/ubuntu/+source/inkscape/+bug/773288/+attachment/3378657/+files/773288-custom-document-without-shadow-1.png
--
You received this bug notification because you are a member of Desktop
Packages, which is
To clarify - detailed steps taken for the screenshots:
first one:
1) launch inkscape with default preferences
(opens a new document based on default template)
2) open 'File Document Properties'
3) take screenshot
second one:
1) launch inkscape with default preferences
2) open existing file
** Changed in: inkscape
Status: Triaged = Confirmed
** Changed in: inkscape (Ubuntu)
Status: Triaged = Confirmed
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to inkscape in Ubuntu.
https://bugs.launchpad.net/bugs/773288
Here's a patch to the bug.
** Patch added: 773288-disable-page-border-options.diff
https://bugs.launchpad.net/ubuntu/+source/inkscape/+bug/773288/+attachment/3348617/+files/773288-disable-page-border-options.diff
--
You received this bug notification because you are a member of Desktop
A patch to the problem.
The indentation of the two sub-options is of one column. The sub-options are
greyed out when the parent option Show Border is unchecked.
** Patch added: 773288-disable-page-border-options.diff
patch to the problem.
** Patch added: 773288-disable-page-border-options.diff
https://bugs.launchpad.net/ubuntu/+source/inkscape/+bug/773288/+attachment/3348686/+files/773288-disable-page-border-options.diff
--
You received this bug notification because you are a member of Desktop
The attachment 773288-disable-page-border-options.diff of this bug
report has been identified as being a patch. The ubuntu-reviewers team
has been subscribed to the bug report so that they can review the patch.
In the event that this is in fact not a patch you can resolve this
situation by
Testing patch with r11709 on OS X 10.7.4 with GTK+/X11 2.24.10 and
GTK+/Quartz 2.24.13:
The logic to detect settings from existing documents seems wrong:
- 'Show border shadow' is not checked ([x]) even if the document shows page
border shadows.
- 'Show border shadow' is insensitive if it had
Patch to the bug.
** Patch added: 773288-disable-page-border-options.diff
https://bugs.launchpad.net/inkscape/+bug/773288/+attachment/3349016/+files/773288-disable-page-border-options.diff
--
You received this bug notification because you are a member of Desktop
Packages, which is
** Changed in: inkscape
Status: Confirmed = In Progress
** Changed in: inkscape
Assignee: (unassigned) = demicoder (moduli16)
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to inkscape in Ubuntu.
The latest patch added (after my earlier comment) is identical from the
one attached earlier (and still seems to have broken logic reading
settings from the current document). It would be helpful if you could
add version tags to patches you attach in the future (e.g. 773288
21 matches
Mail list logo
