Re: 551 JIRA Tickets Over 2 Years Old

2014-04-21 Thread Bill Havanki
+1 to using Won't Fix. Won't can mean won't anytime soon. Labeling as someday or wishlist or something sounds great to me. The tickets remain in JIRA, so they can be resurrected if we change our minds or if an eager contributor comes along. Nothing is lost. I'll look into getting our ASF wiki

Re: [VOTE] Accumulo Blog

2014-04-21 Thread Bill Havanki
Sure thing! It doesn't appear that you have a blog account, so you need to file an INFRA ticket with your Apache ID and requesting access to the Accumulo blog. I'll make sure you're on the admin list after it's done. http://www.apache.org/dev/project-blogs#blogusers Bill H On Fri, Apr 18, 2014

Re: increasing balancing problems to WARN

2014-04-21 Thread Mike Drob
Can you elaborate a bit more on this, Bill? On Sat, Apr 19, 2014 at 12:03 AM, William Slacum wilhelm.von.cl...@accumulo.net wrote: We could consider the use of markers to throw in more metadata about the relevance of a particular log message. On Fri, Apr 18, 2014 at 10:46 PM, Sean Busbey

Re: increasing balancing problems to WARN

2014-04-21 Thread Eric Newton
Eric, do those all sound reasonable? I want to make sure we have a common basis before I get into the specifics of this case. Yes, this is a reasonable list. Do I seem so disagreeable that this was necessary? To be clear, I am against raising the log message Did not balance because a tablet

Re: Review Request 20467: ACCUMULO-2654 updates for 1.6 branch

2014-04-21 Thread Bill Havanki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20467/#review40878 --- Ship it! I'm not an expert in this area, but I don't see any

Re: Review Request 20422: ACCUMULO-1834 - Review Board guidelines

2014-04-21 Thread Bill Havanki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20422/ --- (Updated April 21, 2014, 10:50 a.m.) Review request for accumulo. Changes

Re: Review Request 20422: ACCUMULO-1834 - Review Board guidelines

2014-04-21 Thread Bill Havanki
On April 16, 2014, 2:24 p.m., Christopher Tubbs wrote: docs/src/main/resources/RB.md, line 39 https://reviews.apache.org/r/20422/diff/1/?file=561011#file561011line39 A link to the Review in RB should also be added to the JIRA issue (More - Link - Web Link), to help visitors to

Re: 551 JIRA Tickets Over 2 Years Old

2014-04-21 Thread John Vines
what about just changing them from being improvements to wishes? On Mon, Apr 21, 2014 at 9:26 AM, Bill Havanki bhava...@clouderagovt.comwrote: +1 to using Won't Fix. Won't can mean won't anytime soon. Labeling as someday or wishlist or something sounds great to me. The tickets remain in

Re: 551 JIRA Tickets Over 2 Years Old

2014-04-21 Thread Corey Nolet
+1 On Apr 21, 2014 11:47 AM, John Vines vi...@apache.org wrote: what about just changing them from being improvements to wishes? On Mon, Apr 21, 2014 at 9:26 AM, Bill Havanki bhava...@clouderagovt.com wrote: +1 to using Won't Fix. Won't can mean won't anytime soon. Labeling as someday

Re: 551 JIRA Tickets Over 2 Years Old

2014-04-21 Thread Corey Nolet
+1 I thought proposal would be good enough to convey the message. Wont fix is confusing and I could see possible contributors being starred away by it. On Apr 21, 2014 1:04 PM, cjno...@gmail.com wrote: +1 On Apr 21, 2014 11:47 AM, John Vines vi...@apache.org wrote: what about just changing

Re: 551 JIRA Tickets Over 2 Years Old

2014-04-21 Thread Sean Busbey
On Mon, Apr 21, 2014 at 12:07 PM, Corey Nolet cjno...@gmail.com wrote: +1 I thought proposal would be good enough to convey the message. Wont fix is confusing and I could see possible contributors being starred away by it. What about with a final comment that says something like:

Re: 551 JIRA Tickets Over 2 Years Old

2014-04-21 Thread Christopher
Perhaps (hence my caveat with regard to whether the fact of a ticket being open is problematic). Since it's reversible, Won't Fix can easily be interpreted as Won't Fix at this time. It could always be reopened, if we decide there's more value in not having open tickets. To avoid possibly

Review Request 20523: Initial refactoring, just structural updates.

2014-04-21 Thread Eric Newton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/ --- Review request for accumulo, Bill Havanki and kturner. Bugs: ACCUMULO-2041

Review Request 20524: ACCUMULO-2702 Create separate MR Client Opts

2014-04-21 Thread Mike Drob
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20524/ --- Review request for accumulo and Sean Busbey. Bugs: ACCUMULO-2702

Re: Review Request 20523: Initial refactoring, just structural updates.

2014-04-21 Thread Mike Drob
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/#review40898 ---

Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.

2014-04-21 Thread Sean Busbey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/ --- Review request for accumulo, Eric Newton and Mike Drob. Bugs: ACCUMULO-2694

Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.

2014-04-21 Thread Mike Drob
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/#review40907 ---

Re: Review Request 20524: ACCUMULO-2702 Create separate MR Client Opts

2014-04-21 Thread Sean Busbey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20524/#review40906 ---

Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.

2014-04-21 Thread Sean Busbey
On April 21, 2014, 6:20 p.m., Mike Drob wrote: src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java, line 317 https://reviews.apache.org/r/20525/diff/1/?file=563229#file563229line317 Can this cause a lot of unnecessary logs? When

Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.

2014-04-21 Thread Sean Busbey
On April 21, 2014, 6:20 p.m., Mike Drob wrote: src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java, line 317 https://reviews.apache.org/r/20525/diff/1/?file=563229#file563229line317 Can this cause a lot of unnecessary logs? Sean Busbey

Re: Review Request 20523: Initial refactoring, just structural updates.

2014-04-21 Thread Eric Newton
On April 21, 2014, 6 p.m., Mike Drob wrote: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanOptions.java, line 39 https://reviews.apache.org/r/20523/diff/1/?file=563129#file563129line39 Builder. I don't know what it would accomplish. It's a read-only record

Re: Review Request 20524: ACCUMULO-2702 Create separate MR Client Opts

2014-04-21 Thread Mike Drob
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20524/ --- (Updated April 21, 2014, 6:59 p.m.) Review request for accumulo and Sean

Re: Review Request 20523: Initial refactoring, just structural updates.

2014-04-21 Thread Mike Drob
On April 21, 2014, 6 p.m., Mike Drob wrote: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanOptions.java, line 39 https://reviews.apache.org/r/20523/diff/1/?file=563129#file563129line39 Builder. Eric Newton wrote: I don't know what it would accomplish.

Re: Review Request 20523: Initial refactoring, just structural updates.

2014-04-21 Thread Eric Newton
On April 21, 2014, 6:45 p.m., Bill Havanki wrote: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java, line 50 https://reviews.apache.org/r/20523/diff/1/?file=563123#file563123line50 This should be tablet.minorCompactionStarted(). Good catch!

Re: Review Request 20523: ACCUMULO-2041 Initial refactoring, just structural updates.

2014-04-21 Thread Eric Newton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/ --- (Updated April 21, 2014, 7:31 p.m.) Review request for accumulo, Bill Havanki

Re: Review Request 20523: ACCUMULO-2041 Initial refactoring, just structural updates.

2014-04-21 Thread Bill Havanki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/#review40921 ---

Re: Review Request 20523: ACCUMULO-2041 Initial refactoring, just structural updates.

2014-04-21 Thread Eric Newton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/#review40933 ---

Re: Review Request 20523: ACCUMULO-2041 Initial refactoring, just structural updates.

2014-04-21 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/#review40939 --- Ship it! For the new files, it would be nice to run the formatter

Re: Review Request 20422: ACCUMULO-1834 - Review Board guidelines

2014-04-21 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20422/#review40940 --- docs/src/main/resources/RB.md

Re: Review Request 20422: ACCUMULO-1834 - Review Board guidelines

2014-04-21 Thread Sean Busbey
On April 21, 2014, 8:56 p.m., Josh Elser wrote: docs/src/main/resources/RB.md, line 73 https://reviews.apache.org/r/20422/diff/2/?file=563069#file563069line73 It seems odd to me to specify rules for a passing review and duration length when they're not required. I think use your

Re: Review Request 20523: ACCUMULO-2041 Initial refactoring, just structural updates.

2014-04-21 Thread Eric Newton
On April 21, 2014, 8:39 p.m., Josh Elser wrote: For the new files, it would be nice to run the formatter over them to fix up whitespace. Looks like your editor also put in empty class level javadocs in some classes which would be nice to clean up (else Christopher will find himself

Re: Review Request 20465: ACCUMULO-2343 - AsyncSocketAppender

2014-04-21 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20465/#review40942 --- Did you also verify that you can run an instance using only the

Re: Review Request 20467: ACCUMULO-2654 updates for 1.6 branch

2014-04-21 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20467/#review40947 --- Ship it!

Re: Review Request 20524: ACCUMULO-2702 Create separate MR Client Opts

2014-04-21 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20524/#review40948 --- Ship it! Ship It! - Josh Elser On April 21, 2014, 6:59 p.m.,

Re: [VOTE] Accumulo 1.6.0-RC2

2014-04-21 Thread Christopher
In the interest of documentation, this vote failed with: -6, +2 -- Christopher L Tubbs II http://gravatar.com/ctubbsii On Fri, Apr 18, 2014 at 11:13 PM, Bill Havanki bhava...@clouderagovt.com wrote: And for proper form: -1 due to ACCUMULO-2700. On Fri, Apr 18, 2014 at 11:12 PM, Bill Havanki

Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.

2014-04-21 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/#review40950 ---

Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.

2014-04-21 Thread Sean Busbey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/ --- (Updated April 21, 2014, 9:32 p.m.) Review request for accumulo, Eric Newton

Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.

2014-04-21 Thread Sean Busbey
On April 21, 2014, 6:20 p.m., Mike Drob wrote: src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java, line 317 https://reviews.apache.org/r/20525/diff/1/?file=563229#file563229line317 Can this cause a lot of unnecessary logs? Sean Busbey

Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.

2014-04-21 Thread Sean Busbey
On April 21, 2014, 9:22 p.m., Josh Elser wrote: src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java, line 321 https://reviews.apache.org/r/20525/diff/1/?file=563229#file563229line321 Seems like this could get rather spammy. If we have no

[VOTE] Accumulo 1.6.0-RC3

2014-04-21 Thread Christopher
Accumulo Developers, Please consider the following candidate for Accumulo 1.6.0. Git Commit: 901c35857ce982f2e4a6f609590a04a7b5a1a815 Branch: 1.6.0-RC3 Staging repo: https://repository.apache.org/content/repositories/orgapacheaccumulo-1009 Source:

Re: Review Request 20467: ACCUMULO-2654 updates for 1.6 branch

2014-04-21 Thread Sean Busbey
On April 21, 2014, 9:13 p.m., Josh Elser wrote: test/src/test/java/org/apache/accumulo/test/functional/RecoveryWithEmptyRFileIT.java, line 128 https://reviews.apache.org/r/20467/diff/1/?file=561799#file561799line128 speeling fixed locally prior to push. - Sean