[GitHub] activemq-artemis pull request #839: ARTEMIS-793 Improvement to OSGi integrat...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/839#discussion_r83347252 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/storage/FileStorageConfiguration.java --- @@ -29,7 +29,7 @@

[GitHub] activemq-artemis pull request #844: ARTEMIS-799 Fix issues with the AMQP Dur...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/844 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #843: ARTEMIS-800: Add + pattern to the MQTT pubsub e...

Github user atoulme commented on the issue: https://github.com/apache/activemq-artemis/pull/843 Thanks for rerunning the build! The build shows success: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: Questions around contribution via pull request

Thank you, I will file a JIRA. > On Oct 13, 2016, at 1:09 PM, Martyn Taylor wrote: > > Hi Antoine, > > We try to ensure there's a JIRA for each commit (unless it's a trivial > change), the JIRA number is usually added at the beginning of every commit > message, you can see

[GitHub] activemq-artemis pull request #837: ARTEMIS-792 Add additional tests for AMQ...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/837 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Questions around contribution via pull request

Hi Antoine, We try to ensure there's a JIRA for each commit (unless it's a trivial change), the JIRA number is usually added at the beginning of every commit message, you can see the git log for examples of this. To get started we have a hacking guide with some information:

Questions around contribution via pull request

Pardon me as this is my first attempted contribution to the project. I am trying to contribute a small change to the example showing pub/sub with MQTT. I would like to know more about the contribution process and if I broke any rules. I also saw that the jenkins build testing my change timed

[GitHub] activemq-artemis issue #843: Example showing how to use + in topics

Github user atoulme commented on the issue: https://github.com/apache/activemq-artemis/pull/843 The check was aborted. I will reach out to the Apache ActiveMQ maintainers on the mailing list. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] activemq-artemis pull request #844: ARTEMIS-799 Fix issues with the AMQP Dur...

GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/844 ARTEMIS-799 Fix issues with the AMQP Durable Topic Subscription model Fixes several issues found in the handling of durable topic subscriptions (test cases added). You can merge

[GitHub] activemq-artemis pull request #842: NPE fixes

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/842 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #839: ARTEMIS-793 Improvement to OSGi integrat...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/839#discussion_r83230546 --- Diff: artemis-server-osgi/src/main/java/org/apache/activemq/artemis/osgi/OsgiBroker.java --- @@ -1,223 +1,252 @@ -/* - *