Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

Just a late night thought. What about bumping the major versions for both to indicate the incompatibility? It gives volunteers the option to back port features if needed to the current release lines. On Oct 19, 2016 17:10, "John D. Ament" wrote: Well, I think the

[GitHub] activemq-artemis issue #850: [ARTEMIS-802] Broker does not throw exception o...

Github user bayern39 commented on the issue: https://github.com/apache/activemq-artemis/pull/850 @jbertram OK,I will take it next time! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] activemq-artemis issue #851: [ARTEMIS-708] Incorrect ConcurrentHashSet.remov...

Github user bayern39 commented on the issue: https://github.com/apache/activemq-artemis/pull/851 @clebertsuconic It looks good for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

For artemis: I have used JDK 1.8 last release I built. I believe Martyn also used 1.8 on the releases he deployed. All the apache CIs for Artemis are using JDK 1.8 afaik. (will double check later) I have some internal CIs on my dev env that are also using 1.8. The only thing we didn't do is the

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/839 @graben I have merged, after I reverted some of the bad code I made you do. Can you check please? And sorry about that.. I really thought the ProtocolTracker was externally

[GitHub] activemq-artemis pull request #839: ARTEMIS-793 Improvement to OSGi integrat...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/839 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #851: [ARTEMIS-708] Incorrect ConcurrentHashSet.remov...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/851 @bayern39 I have added a commit on top of yours.. take a look please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/839 @clebertsuconic That's fine with me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/839 @graben I actually just asked this on the dev-list --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/839 @graben I thought ProtocolTracker was part of the API. it's for internal use only. We could have renamed it as much as we wanted. Since I'm the one who messed up I will fix

[GitHub] activemq-artemis pull request #850: [ARTEMIS-802] Broker does not throw exce...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/850 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #851: [ARTEMIS-708] Incorrect ConcurrentHashSe...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/851 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #850: [ARTEMIS-802] Broker does not throw exception o...

Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/850 Just for consistency's sake, can you remove the square brackets from around the JIRA? Back in the old days those were required for tracking commits, but they aren't needed with current

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

But then no one can claim Artemis is 6.x...  On Oct 19, 2016 15:17, "Clebert Suconic" wrote: > ok, lets do it then. +1 > > On Wed, Oct 19, 2016 at 2:55 PM, Christopher Shannon > wrote: > > Well we do need 1.8 so we can use Camel 2.18

[GitHub] activemq-artemis issue #780: ARTEMIS-735 Refactoring of JUnit Tests in artem...

Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/780 Any update on this PR? It not only needs to be squashed, but the commit message needs to be amended to follow the 50/72 pattern discussed in the [Hacking

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

Well we do need 1.8 so we can use Camel 2.18 and fix OSGi stuff in 5.15. And I figured it would be a bit odd if 5.x upgraded but Artemis didn't upgrade. On Wed, Oct 19, 2016 at 1:28 PM, Clebert Suconic wrote: > man... I'm messed up today.. wrong thread ... (on my

[GitHub] activemq-artemis pull request #849: ARTEMIS-805 old JMS clients failing on n...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/849 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

Actually, this was originally written by @CSchneider :) ... On Wed, Oct 19, 2016 at 8:44 AM, Christopher Shannon wrote: > With the release of Camel 2.18 I thought now was a good time to propose > this. I think for the ActiveMQ 5.15 release we should bump the

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

man... I'm messed up today.. wrong thread ... (on my previous message) anyways... If we can keep 1.7 for now and move it when we need it? I'm already using JDK 1.8 for dev, and I believe everybody is... all the CIs are on JDK 1.8, but from time to time I check on 1.7 just to be sure. My main

Re: artemis-server-osgi/ProtocolTracker

actually.. @CShneider (Christian Schneider)... On Wed, Oct 19, 2016 at 1:11 PM, Clebert Suconic wrote: > @Cshanon: The class ProtocolTrackerCallback on artemis-server-osgi, is > it part of an API or it's for internal usage only? > > > There's an open PR around OSGI*

artemis-server-osgi/ProtocolTracker

@Cshanon: The class ProtocolTrackerCallback on artemis-server-osgi, is it part of an API or it's for internal usage only? There's an open PR around OSGI* and I asked a few changed because it would "break" the APi.. but it seems this is intentionally just for the OsgiBroker itself, being internal

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

+1 for 8. On Wed, Oct 19, 2016, 6:54 AM Timothy Bish wrote: > +1 time to move on to 8 > > On 10/19/2016 08:44 AM, Christopher Shannon wrote: > > With the release of Camel 2.18 I thought now was a good time to propose > > this. I think for the ActiveMQ 5.15 release we

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

+1 time to move on to 8 On 10/19/2016 08:44 AM, Christopher Shannon wrote: With the release of Camel 2.18 I thought now was a good time to propose this. I think for the ActiveMQ 5.15 release we should bump the required Java version to Java 8 as this will allow us to use Camel 2.18 so we can

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

+1 sounds good. On Oct 19, 2016 09:49, "Claus Ibsen" wrote: > +1 to upgrade to Java 8 > > On Wed, Oct 19, 2016 at 2:44 PM, Christopher Shannon > wrote: > > With the release of Camel 2.18 I thought now was a good time to propose > > this.

Openwire: New line character in message

Hello, I am using openwire. When I receive FIX message, I am getting new line character in beginning and end of the message from ActiveMQ broker. Is there anyway to avoid these chr(10): Message received: Whole message [

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

+1 to upgrade to Java 8 On Wed, Oct 19, 2016 at 2:44 PM, Christopher Shannon wrote: > With the release of Camel 2.18 I thought now was a good time to propose > this. I think for the ActiveMQ 5.15 release we should bump the required > Java version to Java 8 as

[DISCUSS] Require Java 8 for 5.15 and Artemis

With the release of Camel 2.18 I thought now was a good time to propose this. I think for the ActiveMQ 5.15 release we should bump the required Java version to Java 8 as this will allow us to use Camel 2.18 so we can finally fix our OSGi module and drop the deprecated Spring DM entirely. This

[GitHub] activemq-artemis pull request #849: ARTEMIS-805 old JMS clients failing on n...

Github user TomasHofman commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/849#discussion_r84056887 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -290,9

[GitHub] activemq-artemis pull request #849: ARTEMIS-805 old JMS clients failing on n...

Github user TomasHofman commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/849#discussion_r84055604 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -290,9

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/839 I love checkstyle. :) I thought about the actual implementation and did some small refactorings. Now I think it fits best. But we may think about synchronizing in callback as they are

[GitHub] activemq-artemis pull request #851: [ARTEMIS-708] Incorrect ConcurrentHashSe...

GitHub user bayern39 opened a pull request: https://github.com/apache/activemq-artemis/pull/851 [ARTEMIS-708] Incorrect ConcurrentHashSet.remove call in QueueImpl.DelayedAddRedistributor.run https://issues.apache.org/jira/browse/ARTEMIS-708 You can merge this pull request into a

[GitHub] activemq-artemis issue #847: ARTEMIS-808 use privileges to stop executor

Github user jmesnil commented on the issue: https://github.com/apache/activemq-artemis/pull/847 @jbertram thanks, I checked that with that changes our tests with security manager pass again. --- If your project is set up for it, you can reply to this email and have your reply appear