[GitHub] activemq-artemis issue #871: ARTEMIS-332 avoid shutting down the server afte...

2016-10-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/871 It wasn't rebased against master. I fixed it and merged it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] activemq-artemis issue #871: ARTEMIS-332 avoid shutting down the server afte...

2016-10-28 Thread rvsoni
Github user rvsoni commented on the issue: https://github.com/apache/activemq-artemis/pull/871 Before code check in, I did run mvn -Pdev install -DskipTests=true and compile code with out any checkstyle error/warn message. Ravi --- If your project is set up for it, you can

[GitHub] activemq-artemis issue #871: ARTEMIS-332 avoid shutting down the server afte...

2016-10-28 Thread rvsoni
Github user rvsoni commented on the issue: https://github.com/apache/activemq-artemis/pull/871 We ware having some issue in NFS server used as shared store for journals and largemessage store, so write to large file got interrupted due to client close connection. class

Re: Many old open PRs

2016-10-28 Thread John D. Ament
Interesting, that used to work at least. I wonder if github has changed something recently. John On Fri, Oct 28, 2016 at 4:46 PM Clebert Suconic wrote: > https://github.com/apache/activemq-artemis/pull/873 > > ^^ didn't work > > On Fri, Oct 28, 2016 at 4:46 PM,

Re: Many old open PRs

2016-10-28 Thread Clebert Suconic
https://github.com/apache/activemq-artemis/pull/873 ^^ didn't work On Fri, Oct 28, 2016 at 4:46 PM, Clebert Suconic wrote: > I just tried the tmp branch approach and it didn't work: > > I guess it must be on master, otherwise the apache bot won't see it. > Unless we

Re: Many old open PRs

2016-10-28 Thread Clebert Suconic
I just tried the tmp branch approach and it didn't work: I guess it must be on master, otherwise the apache bot won't see it. Unless we ask Infra to tweak the bot. On Tue, Oct 25, 2016 at 6:22 AM, Christopher Shannon wrote: > +1 for using a temporary branch and

[GitHub] activemq-artemis pull request #870: NO-JIRA removing OIO references, since N...

2016-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/870 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #871: ARTEMIS-332 avoid shutting down the serv...

2016-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/871 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #873: ARTEMIS-830 Remove cyclic dependencies from art...

2016-10-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/873 do you mind closing this PR, it would be superseded by #872 where I already fixed the checkstyle and imported your commit there. --- If your project is set up for it, you can reply

[GitHub] activemq-artemis issue #873: ARTEMIS-830 Remove cyclic dependencies from art...

2016-10-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/873 ``` [INFO] --- maven-bundle-plugin:3.0.0:install (default-install) @ artemis-hqclient-protocol --- [INFO] Starting audit...

[GitHub] activemq-artemis pull request #874: NO-JIRA: Fix checkstyle false friend

2016-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/874 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #874: NO-JIRA: Fix checkstyle false friend

2016-10-28 Thread graben
GitHub user graben opened a pull request: https://github.com/apache/activemq-artemis/pull/874 NO-JIRA: Fix checkstyle false friend You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq-artemis master Alternatively you

Re: [DISCUSS] removing aerogear / vertx module

2016-10-28 Thread Clebert Suconic
Ok, I will remove only vertx for now then. On Fri, Oct 28, 2016 at 10:09 AM, Martyn Taylor wrote: > The AeroGear Connector Service is a useful component, if it's not working > then let's fix it up. It's a convenient way for users to integrate > traditional messaging systems

[GitHub] activemq-artemis issue #872: A few fixes before the release around journal /...

2016-10-28 Thread barreiro
Github user barreiro commented on the issue: https://github.com/apache/activemq-artemis/pull/872 It's good. I also support the removal of the defaultAddress 'optimization'. @clebertsuconic Thanks for taking care of the loose ends! --- If your project is set up for it, you

[GitHub] activemq-artemis pull request #548: Executor in JournalImpl for append opera...

2016-10-28 Thread barreiro
Github user barreiro closed the pull request at: https://github.com/apache/activemq-artemis/pull/548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-10-28 Thread barreiro
Github user barreiro commented on the issue: https://github.com/apache/activemq-artemis/pull/548 Superseded by #872 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Re: [DISCUSS] removing aerogear / vertx module

2016-10-28 Thread Martyn Taylor
The AeroGear Connector Service is a useful component, if it's not working then let's fix it up. It's a convenient way for users to integrate traditional messaging systems with mobile applications. On Fri, Oct 28, 2016 at 2:53 PM, Francesco Nigro wrote: > Good idea! > > Il

Re: [DISCUSS] removing aerogear / vertx module

2016-10-28 Thread Francesco Nigro
Good idea! Il ven 28 ott 2016, 15:37 Robbie Gemmell ha scritto: > On 28 October 2016 at 05:56, Clebert Suconic > wrote: > > There are a few modules on Artemis that I feel are a bit defunct. I > > don't really think anyone will be using it: >

Re: [DISCUSS] removing aerogear / vertx module

2016-10-28 Thread Robbie Gemmell
On 28 October 2016 at 05:56, Clebert Suconic wrote: > There are a few modules on Artemis that I feel are a bit defunct. I > don't really think anyone will be using it: > > - aerogear: > * It's not working > * I am not sure about the status of Aerogear > *

Re: [DISCUSS] removing aerogear / vertx module

2016-10-28 Thread Christopher Shannon
+1, no reason to keep broken stuff around. On Fri, Oct 28, 2016 at 3:21 AM, Jean-Baptiste Onofré wrote: > +1 > > Regards > JB > > ⁣​ > > On Oct 28, 2016, 09:19, at 09:19, Claus Ibsen > wrote: > >+1 > > > >On Fri, Oct 28, 2016 at 6:56 AM, Clebert

[GitHub] activemq-artemis pull request #873: ARTEMIS-830 Remove cyclic dependencies

2016-10-28 Thread bennetelli
GitHub user bennetelli opened a pull request: https://github.com/apache/activemq-artemis/pull/873 ARTEMIS-830 Remove cyclic dependencies Removes cyclic dependencies between classes and packages in the artemis-jdbc-store projetct by moving classes and methods to other locations and

Re: [DISCUSS] removing aerogear / vertx module

2016-10-28 Thread Jean-Baptiste Onofré
+1 Regards JB ⁣​ On Oct 28, 2016, 09:19, at 09:19, Claus Ibsen wrote: >+1 > >On Fri, Oct 28, 2016 at 6:56 AM, Clebert Suconic > wrote: >> There are a few modules on Artemis that I feel are a bit defunct. I >> don't really think anyone will be

Re: [DISCUSS] removing aerogear / vertx module

2016-10-28 Thread Claus Ibsen
+1 On Fri, Oct 28, 2016 at 6:56 AM, Clebert Suconic wrote: > There are a few modules on Artemis that I feel are a bit defunct. I > don't really think anyone will be using it: > > - aerogear: > * It's not working > * I am not sure about the status of Aerogear >