Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1659
The serialisation change was actually needed for the fix, this is some of
the actual issue.
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1659#discussion_r151617383
--- Diff:
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/referenceable/SerializableObjectRefAddr.java
---
@@ -14,7 +14,7 @@
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1659
The serialisation change was actually needed for the fix, this is some of
the actual issue.
> On 17 Nov 2017, at 04:17, clebertsuconic wrote:
>
> The test
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1659#discussion_r151612327
--- Diff:
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/referenceable/ActiveMQRAConnectionFactoryObjectFactory.java
---
@@ -
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1659#discussion_r151612267
--- Diff:
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/referenceable/SerializableObjectRefAddr.java
---
@@ -14,7 +14,7 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1659#discussion_r151612096
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java
---
@@ -88,20 +83,6 @
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1659
The test failure is so weird. if you run the whole thing in Idea it fails..
individually it's passing.
I can see it's missing a property.. but I'm not sure what changed
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1659#discussion_r151581604
--- Diff:
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/referenceable/SerializableObjectRefAddr.java
---
@@ -14,7 +14,7 @@
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1659#discussion_r151581721
--- Diff:
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/referenceable/ActiveMQRAConnectionFactoryObjectFactory.java
---
@@ -27,7
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1659#discussion_r151577088
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java
---
@@ -88,20 +83,6 @@
Hi,
We have a requirement where in we need to connect to IBM Mainframe MQ from
ActiveMQ.
Can you please let me know whether it is possible and what challenges are
there to implement this
--
Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
This is a bit more complex.
LargeServerMessafe is too tight with core.
Will be a bit challenging changing it. I will make large Message a property
of the message so it can be resumed in AMQP.
It will still be compatible change. Won’t need to change it to 3.0.
I will update the design here onc
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1659
@michaelandrepearce sure.. I had missed your URL about the the example.
looks great
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1659
@cleclebertsuconic as noted we had made
https://github.com/michaelandrepearce/tomcat-sample to example this on tomcat
(and for my own piece of mind to prove it) i can move this
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1659
@michaelandrepearce this is really a piece of nice work...
Were you able to run it on tomcat... one thing that would be wonderful is
an example... or docs...
i
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1659
This is PR with Jira and updated commit message, for branch that has been
working/validating with @Spaction on already (see discussion there)
https://github.com/michaelandrepea
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1659
ARTEMIS-1516 - Ensure JNDI via Tomcat Resource works
Apply fix so that when using JNDI via tomcat resource it works.
Replace original extract of JNDIStorable taken from Qpi
Thanks you very much guys!!! how do i open a feature JIRA?
--
Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
I will try to make a conversion. I would rather treat than make another
parameter.
On Thu, Nov 16, 2017 at 9:31 AM Clebert Suconic
wrote:
> There is no distinction.
>
> It will stream if the packet is more then min Large message size on core.
> Or max frame size in AMQP.
>
> I don’t know how dis
There is no distinction.
It will stream if the packet is more then min Large message size on core.
Or max frame size in AMQP.
I don’t know how distinguish really large ones from the ones that are just
above the limit.
On Thu, Nov 16, 2017 at 9:11 AM Martyn Taylor wrote:
> On Thu, Nov 16, 2017
On Thu, Nov 16, 2017 at 2:01 PM, Clebert Suconic
wrote:
> On Thu, Nov 16, 2017 at 6:10 AM, Martyn Taylor wrote:
> > Clebert,
> >
> > We need to distinguish between streamed messages and large messages. For
> > the basic large message case, i.e. a single large message sent to the
> > broker. I
On Thu, Nov 16, 2017 at 6:10 AM, Martyn Taylor wrote:
> Clebert,
>
> We need to distinguish between streamed messages and large messages. For
> the basic large message case, i.e. a single large message sent to the
> broker. I agree with what you have here.
>
> Streamed large messages (i.e. messa
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1628
Got the CheckStyle validations. Will fix them and then commit and then
squash.
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1655
---
Clebert,
We need to distinguish between streamed messages and large messages. For
the basic large message case, i.e. a single large message sent to the
broker. I agree with what you have here.
Streamed large messages (i.e. messages that are received in chunks) allows
us to store the message wit
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1628
@mtaylor This is strange the Checkstyle is not failing on my end but it is
on the Jenkins.
---
26 matches
Mail list logo