Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2336
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2181#discussion_r221341953
--- Diff:
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
---
@@ -227,7 +227,11
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2181#discussion_r221341393
--- Diff:
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
---
@@ -227,7 +227,11
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2187#discussion_r221293865
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/SendAcknowledgementHandler.java
---
@@ -41,4
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2181#discussion_r221229493
--- Diff:
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
---
@@ -227,7 +227,11 @@
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2187#discussion_r221189768
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/SendAcknowledgementHandler.java
---
@@ -41,4 +41,13 @@
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2187#discussion_r221191158
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java
---
@@ -577,26 +587,62 @@
Github user rpelisse commented on the issue:
https://github.com/apache/activemq-artemis/pull/2336
But of course! Just done so (and thanks for the tip, never noticed this -x
option, it's pretty neat).
---
