[GitHub] activemq-artemis pull request #2414: ARTEMIS-1710 Allow management msgs to e...

2018-11-05 Thread wy96f
Github user wy96f commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2414#discussion_r230972615 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java --- @@ -1244,6

Queue.start() does not call systemUsage.start() so TempStore usage is not handled correctly

2018-11-05 Thread David Sitsky
Hi all, I created this JIRA some time ago (and also included a simple patch) but I have not seen any activity on it: https://jira.apache.org/jira/browse/AMQ-7085 It is a pretty trivial but important change. What is the process for getting this into the next release assuming the change is

[GitHub] activemq-artemis pull request #2417: ARTEMIS-2108 fix another potential Stac...

2018-11-05 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2417 ARTEMIS-2108 fix another potential StackOverflow You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis pull request #2416: [ARTEMIS-2163]: Classloading issue if a...

2018-11-05 Thread ehsavoie
GitHub user ehsavoie opened a pull request: https://github.com/apache/activemq-artemis/pull/2416 [ARTEMIS-2163]: Classloading issue if artemis-commons is not in the same classloader as artemis-client-* or artemis-server. * Setting TCCL to be able to load classes via

[GitHub] activemq-artemis pull request #2415: ARTEMIS-2100 address routing-type overr...

2018-11-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2415 ---

[GitHub] activemq-artemis issue #2415: ARTEMIS-2100 address routing-type overridden o...

2018-11-05 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2415 @franz1981 Thanks for making the requested changes. Merging ---

[GitHub] activemq-artemis pull request #2414: ARTEMIS-1710 Allow management msgs to e...

2018-11-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2414 ---

[GitHub] activemq-artemis issue #2414: ARTEMIS-1710 Allow management msgs to exceed g...

2018-11-05 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2414 @franz1981 This looks good to me. Merging. ---

[GitHub] activemq-artemis pull request #2414: ARTEMIS-1710 Allow management msgs to e...

2018-11-05 Thread mtaylor
Github user mtaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2414#discussion_r230684013 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java --- @@

[GitHub] activemq-artemis pull request #2414: ARTEMIS-1710 Allow management msgs to e...

2018-11-05 Thread wy96f
Github user wy96f commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2414#discussion_r230676923 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java --- @@ -1244,6

[GitHub] activemq-artemis issue #2415: ARTEMIS-2100 address routing-type overridden o...

2018-11-05 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2415 This looks fine ---

[GitHub] activemq-artemis issue #2414: ARTEMIS-1710 Allow management msgs to exceed g...

2018-11-05 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2414 Ive reviewed and this looks fine to me. Most of the changes are non intrusive ---