Github user qihongxu commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> @michaelandrepearce @qihongxu Ok, checked: the latest version of this PR
+ my branch
https://github.com/franz1981/activemq-artemis/tree/lock-free-live-page-cache is
fully non-blocking
michaelandrepearce commented on issue #1: projects using ActiveMQ: jms-testkit
URL: https://github.com/apache/activemq-website/pull/1#issuecomment-451625251
Im on leave currently.
Just quickly is this using the newer broker thats jms 2.0 compatible -
activemq artemis? Or the
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
@michaelandrepearce Done, the PR has been sent, now we can just wait the
perf results on it :)
I have improved quite a bit the live page cache behaviour/reliability
(especially if
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2489
ARTEMIS-2220 Fix PageCursorStressTest::testSimpleCursorWithFilter NPE
FakeQueue is not correctly setting the queue on its PageSubscription,
leading to fail the test due to NPEs when
sullis commented on issue #1: projects using ActiveMQ: jms-testkit
URL: https://github.com/apache/activemq-website/pull/1#issuecomment-451583899
@michaelandrepearce ping
This is an automated message from the Apache Git
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
@michaelandrepearce Good idea! let me do it now
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
@franz1981 did you send a pr to @qihongxu branch so he can merge it and
this pr picks it up?
Be great to see a final stat in @qihongxu test env
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
@michaelandrepearce @qihongxu Ok, checked: the latest version of this PR +
my branch
https://github.com/franz1981/activemq-artemis/tree/lock-free-live-page-cache is
never blocked :)
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2482
I will probably do it on the weekend or on Monday ;)
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
@michaelandrepearce @qihongxu I have re-implemented the LivePageCache to be
completly lock-free:
https://github.com/franz1981/activemq-artemis/tree/lock-free-live-page-cache
Fell
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2482
@franz1981 im away in another country without my main computer with my
apache git ssh cert key. Could you merge this?
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> whats the current PR look like in heat maps?
I'm finishing a thing to fix `LivePageCacheImpl` too, hopefully today and I
will post: impl-wise seems good to me as well :+1:
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2482
@qihongxu looks good to me now.
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
@qihongxu looks good to me.
@franz1981 whats the current PR look like in heat maps?
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> em.Could you please tell us which issues? We need to verify how it
affects our cluster.
The big issue im relating to, which became a night mare for my
Github user qihongxu commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
@michaelandrepearce
Removed readlock of isPaging().
Also as @franz1981 suggested now only volatile load
addressFullMessagePolicy once on each call.
Please review and notify
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> Id agree, im just cautious as we've been hit a few times with concurrency
issues that have been a nightmare to find (and quite recently as last month!).
em.Could you please
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245252912
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -278,21 +293,26 @@ public boolean
Github user wy96f closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2481
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245239811
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -278,21 +293,26 @@
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> @michaelandrepearce
>
> > Do you get this on master or this PR (im mean is that a typo)?
>
> I've got that on master!
ok so i think we not need worry
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> If we return `true` from the dirty read we can just return it, while if
we found the it `false` we could attempt to enter the read lock and validate
that's not paging for
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
@michaelandrepearce
> Im starting to feel like Alice here and were going to end up going into a
rabbit hole ;) and will end up with the original isPaging just being dirty.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2470
+1 from me, nice!
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2477
LGTM - would merge for you but currently abroad and don;t have access to my
computer with my apache git ssh key, feel free to merge.
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2481
@wy96f if you could close, only the person opening can close, or when we
merge.
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2482#discussion_r245233815
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java
---
@@ -120,14 +126,16
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
@michaelandrepearce
> Do you get this on master or this PR (im mean is that a typo)?
I've got that on master!
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> @michaelandrepearce @qihongxu Just a lil OT but I'm getting these warns
on master:
>
> ```
> 2019-01-03 17:36:44,408 WARN [org.apache.activemq.artemis.journal]
29 matches
Mail list logo
