[GitHub] soul2zimate opened a new pull request #2496: ENTMQBR-2178 add Implementation-Version for bundle packaging

soul2zimate opened a new pull request #2496: ENTMQBR-2178 add Implementation-Version for bundle packaging URL: https://github.com/apache/activemq-artemis/pull/2496 https://issues.jboss.org/browse/ENTMQBR-2178 Add Implementation-Version for bundle packaging MANIFEST.MF

[GitHub] michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453245632 @franz1981 i know i still owe you those tests... This is

[GitHub] michaelandrepearce closed pull request #2488: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce closed pull request #2488: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2488 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] michaelandrepearce edited a comment on issue #2488: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce edited a comment on issue #2488: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2488#issuecomment-453239022 Im going to close this for the other PR https://github.com/apache/activemq-artemis/pull/2490

[GitHub] michaelandrepearce commented on issue #2488: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce commented on issue #2488: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2488#issuecomment-453239022 Im going to close this for the other PR. This is an

[GitHub] michaelandrepearce commented on issue #2490: V2 196

michaelandrepearce commented on issue #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453238805 Ok, I put back to original class, and added an if check to it, with comments. Squashed everything also.

[GitHub] michaelandrepearce commented on issue #2490: V2 196

michaelandrepearce commented on issue #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453188403 Oh, ok ill try do that. This is an automated message from the Apache Git Service. To respond

[GitHub] gemmellr commented on issue #2490: V2 196

gemmellr commented on issue #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453180509 I'd have been content with an if and comment in the original class, but happy with the class if that is convention.

[GitHub] franz1981 commented on issue #2482: ARTEMIS-2214 Cache durable in PagedReference

franz1981 commented on issue #2482: ARTEMIS-2214 Cache durable in PagedReference URL: https://github.com/apache/activemq-artemis/pull/2482#issuecomment-453169452 Please due to a change can you rebase this one? This is an

[GitHub] michaelandrepearce commented on issue #2490: V2 196

michaelandrepearce commented on issue #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453154391 @gemmellr a created a new SessionCreateConsumerMessage_V2 so hopefully this addresses this and added a version check on channel. also addressed merge

[GitHub] gemmellr edited a comment on issue #2490: V2 196

gemmellr edited a comment on issue #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453129367 Sometimes tests don't pick up issues that may exist and we later find issues prompting more specific tests. You essentially don't need to rely on the

[GitHub] gemmellr commented on issue #2490: V2 196

gemmellr commented on issue #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453129367 Sometimes tests don't pick up issues that may exist and we later find issues prompting more specific tests. You essentially don't need to rely on the compatibility

[GitHub] michaelandrepearce edited a comment on issue #2490: V2 196

michaelandrepearce edited a comment on issue #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453122729 @gemmellr as i stated, this approach has been used many times over, historically and is obviously proven, as i noted theres even a compatibility

[GitHub] michaelandrepearce edited a comment on issue #2490: V2 196

michaelandrepearce edited a comment on issue #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453122729 @gemmellr as i stated, this approach has been used many times over, historically and is obviously proven, as i noted theres even a compatibility

[GitHub] michaelandrepearce edited a comment on issue #2490: V2 196

michaelandrepearce edited a comment on issue #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453122729 @gemmellr as i stated, this approach has been used many times over, historically and is obviously proven, as i noted theres even a compatibility

[GitHub] michaelandrepearce edited a comment on issue #2490: V2 196

michaelandrepearce edited a comment on issue #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453122729 @gemmellr as i stated, this approach has been used many times over, historically and is obviously proven, as i noted theres even a compatibility

[GitHub] michaelandrepearce edited a comment on issue #2490: V2 196

michaelandrepearce edited a comment on issue #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453122729 @gemmellr as i stated, this approach has been used many times over, historically and is obviously proven, this is not something i invented, im just

[GitHub] michaelandrepearce commented on issue #2490: V2 196

michaelandrepearce commented on issue #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453122729 @gemmellr as i stated, this approach has been used many times over, historically and is obviosuly proven, this is not something i invented, im just

[GitHub] asfgit closed pull request #2495: ARTEMIS-2144 - fixing brokern test

asfgit closed pull request #2495: ARTEMIS-2144 - fixing brokern test URL: https://github.com/apache/activemq-artemis/pull/2495 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] gemmellr commented on issue #2490: V2 196

gemmellr commented on issue #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453121357 @michaelandrepearce I'd have made the same comment for those changes if reviewing them, as I would probably have to go digging through commits now if I wanted to

Re: [PROPOSAL] Migrate to gitbox on January, 9th

Repositories have been moved by INFRA. I'm now updating the scm location where I can. Regards JB On 10/01/2019 08:00, Jean-Baptiste Onofré wrote: > Hi, > > Following this, the migration of all of our repositories started. > > I will keep you posted soon. > > Regards > JB > > On 07/01/2019

Re: [PROPOSAL] Migrate to gitbox on January, 9th

I updated the ActiveMQ urls in Jenkins for 5.x but the other projects still need to be updated. On Thu, Jan 10, 2019 at 5:33 AM Robbie Gemmell wrote: > The initial/main step looks to have been performed already, with repo > migration completed by Infra (via >

[GitHub] michaelandrepearce commented on issue #2490: V2 196

michaelandrepearce commented on issue #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453079968 @gemmellr so this is the same pattern used quite a bit, e.g. if you look at in master: ClusterTopologyChangeMessage_V2 it was used when adding

[GitHub] gemmellr edited a comment on issue #2490: V2 196

gemmellr edited a comment on issue #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453069204 @michaelandrepearce Thanks. I'd still rather some of the tests weren't burning 250ms various times waiting to test something that can be verified

[GitHub] gemmellr commented on issue #2490: V2 196

gemmellr commented on issue #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453069204 @ Thanks. I'd still rather some of the tests weren't burning 250ms various times waiting to test something that can be verified 'immediately', but its a lot better.

[GitHub] andytaylor opened a new pull request #2495: ARTEMIS-2144 - fixing brokern test

andytaylor opened a new pull request #2495: ARTEMIS-2144 - fixing brokern test URL: https://github.com/apache/activemq-artemis/pull/2495 This is an automated message from the Apache Git Service. To respond to the message,

Re: [PROPOSAL] Migrate to gitbox on January, 9th

The initial/main step looks to have been performed already, with repo migration completed by Infra (via https://issues.apache.org/jira/browse/INFRA-17607 for later reference). Using the old git-wip-us URLs has stopped working currently (the URLs will eventually be redirected in the forced

[GitHub] franz1981 commented on a change in pull request #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

franz1981 commented on a change in pull request #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#discussion_r246602031 ## File path:

[GitHub] onlyMIT commented on a change in pull request #2466: ARTEMIS-2206 The MQTT consumer reconnection caused the queue to not be cle…

onlyMIT commented on a change in pull request #2466: ARTEMIS-2206 The MQTT consumer reconnection caused the queue to not be cle… URL: https://github.com/apache/activemq-artemis/pull/2466#discussion_r246680631 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2490: V2 196

michaelandrepearce commented on a change in pull request #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#discussion_r246670739 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java ## @@

[GitHub] michaelandrepearce commented on a change in pull request #2490: V2 196

michaelandrepearce commented on a change in pull request #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#discussion_r246670280 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2490: V2 196

michaelandrepearce commented on a change in pull request #2490: V2 196 URL: https://github.com/apache/activemq-artemis/pull/2490#discussion_r246668795 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java ## @@