Re: [Discuss] automated github messages on a separate list

Sharing my perspective as someone who also would like to contribute more often: I think that it be good. I think that the Github messages create a lot of noise in the mailbox. It requires constant cleaning/filtering and it is easy to miss discussions about subjects that interest me and for which

[GitHub] onlyMIT commented on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

onlyMIT commented on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-463883656 @michaelandrepearce Ok, thank you very much for your help.

[GitHub] wy96f edited a comment on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout

wy96f edited a comment on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout URL: https://github.com/apache/activemq-artemis/pull/2533#issuecomment-463874114 > To me it seems we shouldnt have change critical analyslzer at all. Its

[GitHub] wy96f edited a comment on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout

wy96f edited a comment on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout URL: https://github.com/apache/activemq-artemis/pull/2533#issuecomment-463874114 > To me it seems we shouldnt have change critical analyslzer at all. Its

[GitHub] wy96f commented on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout

wy96f commented on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout URL: https://github.com/apache/activemq-artemis/pull/2533#issuecomment-463874114 > To me it seems we shouldnt have change critical analyslzer at all. Its done

[GitHub] michaelandrepearce edited a comment on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

michaelandrepearce edited a comment on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-463871181 @onlyMIT i would like some of others in the group to review this as well, as there

[GitHub] michaelandrepearce edited a comment on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

michaelandrepearce edited a comment on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-463871181 @onlyMIT i would like some of others in the group to review this as well, as there

[GitHub] michaelandrepearce edited a comment on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

michaelandrepearce edited a comment on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-463871181 @onlyMIT i would like some of others in the group to review this as well, as there

[GitHub] michaelandrepearce commented on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

michaelandrepearce commented on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-463871181 @onlyMIT i would like some of others in the group to review this as well.

[GitHub] michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463867719 @franz1981 the needing to copy a IntObjectHashmap, still didnt fit right with me. As such have had a sit

[GitHub] michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463867719 @franz1981 the needing to copy a IntObjectHashmap, still didnt fit right with me. As such have had a sit

[GitHub] michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463867719 @franz1981 the needing to copy a IntObjectHashmap, still didnt fit right with me. As such have had a sit

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463867719 @franz1981 the needing to copy a IntObjectHashmap, still didnt fit right with me. As such have had a sit and

[Discuss] automated github messages on a separate list

I work on this dev list on my daily basis. We had some members here suggesting doing this in the past and we decided to let just people to filter out stuff with filters. Etc. But this doesn’t make easy to recruit new open source devs. I just heard from a guy who only subscribed users list

[GitHub] michaelandrepearce commented on issue #2551: NO-JIRA Removing Debug Message from code

michaelandrepearce commented on issue #2551: NO-JIRA Removing Debug Message from code URL: https://github.com/apache/activemq-artemis/pull/2551#issuecomment-463759358 +1 This is an automated message from the Apache Git

[GitHub] clebertsuconic commented on issue #2551: NO-JIRA Removing Debug Message from code

clebertsuconic commented on issue #2551: NO-JIRA Removing Debug Message from code URL: https://github.com/apache/activemq-artemis/pull/2551#issuecomment-463734606 @michaelandrepearce I'm merging this.. adding this comment FYI

[GitHub] nomstradamus opened a new pull request #346: Modified code to not read from file every time but use last modified timestamp and cache filedata.

nomstradamus opened a new pull request #346: Modified code to not read from file every time but use last modified timestamp and cache filedata. URL: https://github.com/apache/activemq/pull/346 As per the comment given by the earlier developer the code could be optimized by checking only

[GitHub] clebertsuconic opened a new pull request #2551: NO-JIRA Removing Debug Message from code

clebertsuconic opened a new pull request #2551: NO-JIRA Removing Debug Message from code URL: https://github.com/apache/activemq-artemis/pull/2551 This is an automated message from the Apache Git Service. To respond to the

[GitHub] clebertsuconic commented on a change in pull request #2467: ARTEMIS-2205 Performance improvements on AMQP and other parts

clebertsuconic commented on a change in pull request #2467: ARTEMIS-2205 Performance improvements on AMQP and other parts URL: https://github.com/apache/activemq-artemis/pull/2467#discussion_r256920259 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2467: ARTEMIS-2205 Performance improvements on AMQP and other parts

michaelandrepearce commented on a change in pull request #2467: ARTEMIS-2205 Performance improvements on AMQP and other parts URL: https://github.com/apache/activemq-artemis/pull/2467#discussion_r256896902 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2467: ARTEMIS-2205 Performance improvements on AMQP and other parts

michaelandrepearce commented on a change in pull request #2467: ARTEMIS-2205 Performance improvements on AMQP and other parts URL: https://github.com/apache/activemq-artemis/pull/2467#discussion_r256896902 ## File path:

[GitHub] jdanekrh commented on a change in pull request #2467: ARTEMIS-2205 Performance improvements on AMQP and other parts

jdanekrh commented on a change in pull request #2467: ARTEMIS-2205 Performance improvements on AMQP and other parts URL: https://github.com/apache/activemq-artemis/pull/2467#discussion_r256879260 ## File path:

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463640868 @franz1981 Hopefully fixed the checkstyle, netty used 4 space tabs we use 3, lol, i feel like an episode of

[GitHub] asfgit merged pull request #2550: NO-JIRA Fix a "Computation of average could overflow" SpotBugs warning

asfgit merged pull request #2550: NO-JIRA Fix a "Computation of average could overflow" SpotBugs warning URL: https://github.com/apache/activemq-artemis/pull/2550 This is an automated message from the Apache Git Service. To

[GitHub] clebertsuconic commented on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout

clebertsuconic commented on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout URL: https://github.com/apache/activemq-artemis/pull/2533#issuecomment-463621345 I have amended the change before merging (extra commit) Basically

[GitHub] michaelandrepearce commented on issue #2550: NO-JIRA Fix a "Computation of average could overflow" SpotBugs warning

michaelandrepearce commented on issue #2550: NO-JIRA Fix a "Computation of average could overflow" SpotBugs warning URL: https://github.com/apache/activemq-artemis/pull/2550#issuecomment-463616792 Great find. Thanks. Will merge

[GitHub] michaelandrepearce edited a comment on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout

michaelandrepearce edited a comment on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout URL: https://github.com/apache/activemq-artemis/pull/2533#issuecomment-463614378 To me it seems we shouldnt have change critical analyslzer at

[GitHub] michaelandrepearce commented on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout

michaelandrepearce commented on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout URL: https://github.com/apache/activemq-artemis/pull/2533#issuecomment-463614378 To me it seems we shouldnt have change critical analyslzer at all.

[GitHub] jdanekrh opened a new pull request #2550: NO-JIRA Fix a "Computation of average could overflow" SpotBugs warning

jdanekrh opened a new pull request #2550: NO-JIRA Fix a "Computation of average could overflow" SpotBugs warning URL: https://github.com/apache/activemq-artemis/pull/2550

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256745053 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256745053 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256745053 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256745053 ## File path:

[GitHub] franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256741638 ## File path:

[GitHub] franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256741638 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256739594 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256739594 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256739594 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256738673 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256706799 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256706799 ## File path:

[GitHub] franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256728547 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256706799 ## File path:

[GitHub] franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256728127 ## File path: