This is a good summary Justin. As someone who mostly follows issues these
days-as opposed to contributing-a few things to add, having used both to manage
work:
* Github has "projects" which allow you to organize tasks across repos -- which
in some ways is helpful, but you have to know to look
-1
Reasons to keep:
* It's useful to be able to link a specific line/method in the javadoc when
explaining something to someone through the use of a URL
* It's nice to be able to navigate the source code in your browser, if say your
IDE is having issues and you can't correctly navigate to docs
gt;> Greetings.
>>
>> My name is Nikita Shupletsov. I am a software development engineer at
>> Amazon MQ.
>>
>> I have been working on an Asynchronous Replication plugin for ActiveMQ
>> “Classic” that was proposed by Étienne Hossack last year:
>>
Given I'm still hoping to drive the PRs for AMQ-8317, and AMQ-7514 through I
apologize for not chiming in earlier due to busyness.
But echoing the consensus as well for posterity:
> Nouns: Primary/Backup
> Adjectives: Active/Passive
Such that for AMQ5 we'd be starting generally to use the
Thanks for clarifying Justin, Clebert.
+1 to the approach Art is highlighting.
One of the problems with the log4j migration we had in AMQ5 (and as Matt has
linked) is that the test classes are coupled to the logging framework (log4j
specifically). So if there was a need to switch to say,
+1
Bit late, but LGTM
Docker image is helpful, could be a good thing to build automatically in the
future!
--
Étienne
he/him/his
On Tue, 3 May 2022, at 2:07 AM, Domenico Francesco Bruscino wrote:
> +1 (non binding)
>
> * Checked parent version in pom.xml files using `grep -LPrz --include
>
Jumping back to the specific approach...
Out of curiousity, why add in annotation processing to the mix? Seems like a
clever enough approach, but most projects I've worked with don't involve
annotations/code generation in the logging mix (apart from e.g. Lombok + Slf4j
annotations).
Clebert,
+1 to this. Particularly if there's a desire to automate more of the
announcements on the website.
If we wanted to go further someone could set up Jira fields and Github
templates to enforce these.
It's good to have context in both commits and Jira, so worst case you copy your
detailed commit
>> to include since it's just logging so it's probably fine. But as I said I
>> find very little value in having a toggle mode so I would be a -1 to
>> include in the current form and think the toggle mode should be removed.
>> That will make the change even simpler. If
s. We should be
> going to a faster release process so I wouldn't expect it to take too long.
>
> On Tue, Mar 1, 2022 at 1:33 PM Étienne Hossack wrote:
>
>> Hey all,
>>
>> There's been a few PRs open for
>> https://issues.apache.org/jira/browse/AMQ-7514 (specifically AMQ-8
Hey all,
There's been a few PRs open for https://issues.apache.org/jira/browse/AMQ-7514
(specifically AMQ-8317) that have not had traction in a while. I can
rebase/re-open them, but it would be good to get the ball rolling on these in
an earlier release so that the removal can happen in a
+1
Thanks for the work JB, Matt!
Ran repo + some custom tests.
Étienne
On Fri, 11 Feb 2022, at 11:49 AM, Christopher Shannon wrote:
> +1 (binding), looks good!
>
> * Validated signatures and checksums
> * Built from source and ran some custom tests
> * Verified all the new tests added since
12 matches
Mail list logo
