[GitHub] activemq-artemis issue #2492: ARTEMIS-2222 why the position remains unchange...

2019-01-08 Thread CNNJYB
Github user CNNJYB commented on the issue: https://github.com/apache/activemq-artemis/pull/2492 > This had a specific purpose so we ignore deleted or completed pages, so we shouldnt be getting the message position. > > As per commen

[GitHub] activemq-artemis issue #2492: ARTEMIS-2222 why the position remains unchange...

2019-01-08 Thread CNNJYB
Github user CNNJYB commented on the issue: https://github.com/apache/activemq-artemis/pull/2492 > It is correct that the first commit is related to ARTEMIS-2144? Branch is not latest. Now updated. ---

[GitHub] activemq-artemis pull request #2492: ARTEMIS-2222 why the position remains u...

2019-01-08 Thread CNNJYB
GitHub user CNNJYB opened a pull request: https://github.com/apache/activemq-artemis/pull/2492 ARTEMIS- why the position remains unchanged if ignored is set to true I am a bit confused about this, When CursorIterator:next is called during queue depage, if ignored is set to true

[GitHub] activemq-artemis pull request #2483: ARTEMIS-2215 largemessage have been con...

2019-01-03 Thread CNNJYB
Github user CNNJYB commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2483#discussion_r244976446 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java --- @@ -309,16

[GitHub] activemq-artemis pull request #2483: ARTEMIS-2215 largemessage have been con...

2019-01-01 Thread CNNJYB
Github user CNNJYB commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2483#discussion_r244657469 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java --- @@ -193,7

[GitHub] activemq-artemis pull request #2483: ARTEMIS-2215 largemessage have been con...

2018-12-29 Thread CNNJYB
GitHub user CNNJYB opened a pull request: https://github.com/apache/activemq-artemis/pull/2483 ARTEMIS-2215 largemessage have been consumed but not deleted During the backup and live synchronization, the client consumes the largemessage, then the live crash