Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2402
I know, either way, this is just to update the documentation to say that 0
will disable the timed buffer
---
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2402
NO-JIRA: Clarify journal-buffer-timeout documentation
Clarify how to disable the buffer timeout. On one of my test brokers I
disabled journal-sync-transactional and journal-sync-non
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
Yes you need the latest client as well. This feature works by retrieving
the value from the server as part of a query on connect. The old client doesn't
know to read the default
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
This is only available for version 2.7.0 which has not been released yet.
There is documentation available for it as well that will be released with it
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2278
@clebertsuconic - besides the test fix it looks good to me, thanks for
fixing it
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2278
The issue is here:
https://github.com/apache/activemq-artemis/blob/106e71bdf4f1cf7ddf0dfc37ce6bab76d5c00dad/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2278
It looks like one of tests I added in ConsumerWindowSizeTest
brokertestConsumerWindowSizeAddressSettingsDifferentAddressAndQueueName
---
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2267
ARTEMIS-2052 - QueueQuery should use address name for address settings
The name used for looking up address settings for a queue now uses the
address name if there is a local queue
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2262
@michaelandrepearce - Do you have an actual use case or example where it's
not reliable? The new metric gets used for size stuff as well so I don't think
it should be changed
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2258
@calohmn - ah ok, yeah that makes sense I didn't look closely enough so if
it's spaces then all should be good
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2258
Adding exception callbacks seems good to me, one thing I noticed is a lot
of white space changes. My guess is your IDE is set to use tabs instead of
spaces so I would fix that before
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2231
Looks good to me
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2229
I like the idea of using separate interfaces and having
ActiveMQServerPlugin extend them. This way if someone doesn't care they can
make it easy and just extend ActiveMQServerPlugin
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2229
ARTEMIS-2018 - Add bridge events to plugin API
Add callbacks to handle bridge events including beforeDeliverBridge,
afterDeliverBridge and afterAcknowledgeBridge
You can merge
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2206
Done, test is running now
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2206
@jbertram - patch updated...not sure why CI keeps failing but the tests
pass on my machine
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2206
@jbertram - renaming the metrics is no problem, I had just used what 5.x
had called them but it's fine to rename them for consistency with other
existing metrics
I added the map
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2206
@franz1981 - makes sense with the API hints if that change is done in other
cases to make it known to developers the semantics...in this case i think we
are good as no change should
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2206
I don't think that change can be made. The metrics for the dequeue case on
the send acknowledge in this case can be updated in another runnable (new
thread)
Also, honestly I
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2206
ARTEMIS-2003 - Add bridge metrics
This commit adds support for tracking metrics for bridges for both
normal bridges and bridges that are part of a cluster. The two
statistics
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
@clebertsuconic and @michaelandrepearce - i rebased against master and it
looks like the tests all pass so this should be good to merge
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
I don't know what the latest test failure is but the tests pass on my
machine. The travis CI build seems to be pretty inconsistent with random
failures.
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
I had to add a setting to one of the tests so hopefully that fixes it, will
find out in a few minutes
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
@clebertsuconic - Is this ok to merge?
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
Ok latest changes have been pushed which includes removing the new version
and using a nullable integer instead
---
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2191#discussion_r204867142
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionQueueQueryResponseMessage_V4.java
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2191#discussion_r204867293
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionQueueQueryResponseMessage_V4.java
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
@clebertsuconic and @michaelandrepearce - PR has been updated
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
@clebertsuconic - My use case is for the "service provider" case where the
administrators want to protect a shared resource broker that services many
different customers and
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2191#discussion_r204819939
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
---
@@ -822,6
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2191#discussion_r204819904
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java
---
@@ -347,7 +347,7 @@ private
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2191
ARTEMIS-1987 - Add consumer window size to AddressSettings
Support configuring a default consumer window size via AddressSettings
which will allow sensible defaults to be used
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2116
The build looks good now
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2116
I don't think it's related as the test it failed on doesn't have a plugin
registered. I tried to see if I could trigger it to re-run the build in travis
ci but i didn't see a way to do that.
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2116
@clebertsuconic - is this ok to merge?
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2116
I removed the re-throw and the expect for the JMSException so it will only
pass on InvalidClientIDException as that is the only type that should be thrown
---
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2116#discussion_r191788973
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/SessionMetadataAddExceptionTest.java
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2116#discussion_r191787441
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/SessionMetadataAddExceptionTest.java
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2116
@michaelandrepearce - good point, i fixed it to bubble up the
ActiveMQException and so it is handled properly by the client
---
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2116
ARTEMIS-1895 - Add duplicate metadata failure callback to
ActiveMQServerPlugin
Add a callback on duplicate metadata which will allow extra functionality
to be added.
You can merge
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2109
It's fine to wait for next week
---
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2109
ARTEMIS-1888 - Fix SSL order of precedence in core client
Local connection SSL settings should be preferred over javax.ssl
settings
You can merge this pull request into a Git
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2044
Ah yep you are right so there is no change needed.
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2044
@franz1981 - You should probably also update the tests as well. The
MethodCalledVerifier class implements ActiveMQServerPlugin in the integration
tests project and should probably have
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2044
Oops, yeah this is the correct fix. The new default method would call off
to the old one as it's default if nothing overrides it to stay backwards
compatible. And then with Artemis
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2012
@franz1981 and @michaelandrepearce - thanks for taking a look
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2012
@franz1981 and @michaelandrepearce - I updated the patch to pass a
reference to the ServerConsumer (when it applies) for both the expired and
acked callbacks and dropped the extra
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2012
I understand wanting to keep memory low but there's a point where you take
things too far. At some point usability and correctness is more important.
Having just a consumerId is just
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2012
@michaelandrepearce - because 1) there can be more than just that use case
for having sessionId part of the reference in the future and 2) the acknowledge
code is not part
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2012
For example, it's a common use case to fire notifications or logging when a
message is acknowledged. I have a requirement to do this for my organization
and I need to quickly track
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2012
@franz1981 - So what size would you recommend? Seems like maybe 8 is too
much to add to the estimation based on the output.
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2012
Furthermore there is more to a broker than just processing. Monitoring and
metrics are very important to business flows and trying to save a few bytes of
memory is not worth it if you
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2012
It's not attached to the message. The reference has the information for
which consumer is attached to it. The consumer id is not unique so you need to
have the session Id as well
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2012
@franz1981 - If you don't mind double checking with the tool again I would
appreciate it since you have already validated the memory before but if you
don't have time I can try
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2012
I updated the PR and added 8 to the estimated size in MessageRefereceImpl.
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2012
@franz1981 - Did you mean probably "would" be enough? The string is a UUID
(which is normally 16 bytes I think) but it is owned by the ServerSessionImpl
so it would just be a
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2012
ARTEMIS-1803 - Add sessionId to MessageReference
Track the sessionId along with the consumerId in a MessageReference when
appropriate in order to figure out which consumer
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2009#discussion_r180774964
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
---
@@ -2510,6
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2009
ARTEMIS-1800 - Fix metrics decrement on scheduled message cancel
The queue metrics were being decremented improperly because on iteration
over the cancelled scheduled messages
Github user cshannon closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2008
---
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2008
ARTEMIS-1800 - fix duplicate metrics update on scheduled message cancel
When removing scheduled messages from a queue the scheduled message
metrics were being decremented twice
You
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2007
@clebertsuconic - thanks for merging
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2007
I don't understand the confusion. That call just calls off to any
registered plugins if they exist. This commit is a brand new plugin that
implements the afterDeliver call and fires
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2007#discussion_r180449915
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
---
@@ -39,7 +39,15
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2007
ARTEMIS-1799 - Add a NotificationActiveMQServerPlugin
Adds a new plugin that will support sending new types of notifications
for broker events which will allow enhanced broker
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1959
Shouldn't we just have the getPersistentSize() method open/close the
encoder? The idea is that this method might be called by anyone as it is
public so this is a bigger issue than just
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1925
@tabish121 - PR has been updated to use the broker's scheduled pool
---
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1925#discussion_r171924792
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1925#discussion_r171921837
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1925
ARTEMIS-1727 - Make sure transport is stopped on failed OpenWire
connection
To prevent a socket from hanging open by a bad client the broker should
make sure to stop
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1923
ARTEMIS-1726 - check proper permissions when using OpenWire
Ensure that on queue creation and deletion that the proper permissions
are checked
You can merge this pull request
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1910
ARTEMIS-1713 - Fix NPE inside OpenWireConnection
fix NPE inside getClientId() in OpenWireConnection
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1908
ARTEMIS-1711 - Fix openwire exlusive divert
Fixing the failure on send from an OpenWire producer when an exclusive
divert exists
You can merge this pull request into a Git
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1903
@clebertsuconic and @tabish121 - PR has been updated and rebased.
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1903
I am going to update my PR with Timâs suggestion to have it match 5.x and
rebase in the morning
---
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1903
ARTEMIS-1706 - Add support for wantClientAuth
Support setting wantClientAuth on a netty acceptor
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1886
ARTEMIS-1695 - Improve STOMP compatiblity with 5.x clients
Also make sure on authentication error in version 1.0 a client will
disconnect
You can merge this pull request into a Git
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1853
Had to update the PR again as something got messed up when rebasing
---
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166700570
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
---
@@ -439,7 +453,7
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1853
@clebertsuconic - I did some cleanup work and I added a couple of basic
tests to the compatibility test. It doesn't do much but show that the current
snapshot can load a 2.4 journal
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166632761
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountPendingImpl.java
---
@@ -62,21
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166630379
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountPendingImpl.java
---
@@ -62,21
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1853
@clebertsuconic - The metric in the page counters is persisted along with
the page counters now. When the page counters are written to the journal that
metric is encoded to disk
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1853
Oh ok I get it now. Yeah you are right that the PagingStore interface has
a method to get the number of pages and the page size which can be used to get
an idea of consumption
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1853
@clebertsuconic - I don't think we need to re-calculate anything if the
values are missing for paging. The point of this metric isn't to give the
user information on storage
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166601621
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountRecordInc.java
---
@@ -26,17
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1853
I updated the PR with getPersistentSize() everywhere along with comments to
try and make it more clear what the value represented. I can tweak it some
more if people still think it's
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1853
Ok I can just use getPersistentSize() then for everything, I will update
the PR shortly.
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1853
@clebertsuconic - hmm so I'm starting to like you original idea of just
using getEncodeSize() more as the the message might be non-durable and in that
case the encode size is still used
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1853
getPersistentSize() is fine with me as it specifies that the size
represents the entire persisted size of the message
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1853
@clebertsuconic - Fair enough, but I think I should call it
getMessageSize() instead (i already did this in a couple places) The reason
why I would use that name is because the value
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166401530
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountPendingImpl.java
---
@@ -43,6
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166388367
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountPendingImpl.java
---
@@ -43,6
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166386744
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountPendingImpl.java
---
@@ -43,6
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1853
@clebertsuconic - No, I'm not trying to measure the size on the JVM. I
want to measure the size of the messages in general (including how much space
is on disk) as a metric to know how
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1853
@michaelandrepearce - ok made those 2 changes so it is ready for another
look
---
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166346352
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java
---
@@ -53,6 +53,8
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166346269
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
---
@@ -1309,4 +1336,68
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1853
@michaelandrepearce - I updated my PR, take a look and let me know what you
think.
---
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166283882
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionCounterImpl.java
---
@@ -374,8
1 - 100 of 210 matches
Mail list logo
