[GitHub] activemq-artemis pull request #2341: ARTEMIS-2103 - use the full openwire co...

2018-10-08 Thread gtully
GitHub user gtully reopened a pull request: https://github.com/apache/activemq-artemis/pull/2341 ARTEMIS-2103 - use the full openwire consumer queue for the mapped vi… …rtual topic queue binding, fix and test You can merge this pull request into a Git repository by running

[GitHub] activemq-artemis pull request #2341: ARTEMIS-2103 - use the full openwire co...

2018-10-08 Thread gtully
Github user gtully closed the pull request at: https://github.com/apache/activemq-artemis/pull/2341 ---

[GitHub] activemq-artemis pull request #2346: ARTEMIS-2110 allow a lease renew withou...

2018-10-08 Thread gtully
Github user gtully closed the pull request at: https://github.com/apache/activemq-artemis/pull/2346 ---

[GitHub] activemq-artemis pull request #2346: ARTEMIS-2110 allow a lease renew withou...

2018-10-08 Thread gtully
GitHub user gtully reopened a pull request: https://github.com/apache/activemq-artemis/pull/2346 ARTEMIS-2110 allow a lease renew without update to the expiry timesta… …mp. Fix intermittent failure of org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest

[GitHub] activemq-artemis pull request #2346: ARTEMIS-2110 allow a lease renew withou...

2018-10-05 Thread gtully
Github user gtully closed the pull request at: https://github.com/apache/activemq-artemis/pull/2346 ---

[GitHub] activemq-artemis pull request #2346: ARTEMIS-2110 allow a lease renew withou...

2018-10-05 Thread gtully
GitHub user gtully reopened a pull request: https://github.com/apache/activemq-artemis/pull/2346 ARTEMIS-2110 allow a lease renew without update to the expiry timesta… …mp. Fix intermittent failure of org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest

[GitHub] activemq-artemis issue #2346: ARTEMIS-2110 allow a lease renew without updat...

2018-10-05 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/2346 seems building the web site is the crux. it can be disabled with: mvn -Pfast-tests -Pextra-tests -B install -q -pl '!artemis-web' ---

[GitHub] activemq-artemis issue #2346: ARTEMIS-2110 allow a lease renew without updat...

2018-10-05 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/2346 The ci build failure seems may be related to the doc generation... there is no output for 10 mins and a termination after 42 mins

[GitHub] activemq-artemis pull request #2346: ARTEMIS-2110 allow a lease renew withou...

2018-10-04 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/2346 ARTEMIS-2110 allow a lease renew without update to the expiry timesta… …mp. Fix intermittent failure of org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest

[GitHub] activemq-artemis pull request #2341: ARTEMIS-2103 - use the full openwire co...

2018-10-04 Thread gtully
GitHub user gtully reopened a pull request: https://github.com/apache/activemq-artemis/pull/2341 ARTEMIS-2103 - use the full openwire consumer queue for the mapped vi… …rtual topic queue binding, fix and test You can merge this pull request into a Git repository by running

[GitHub] activemq-artemis issue #2341: ARTEMIS-2103 - use the full openwire consumer ...

2018-10-04 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/2341 going to try again, the tests that fails is lease.tryAquire/renew which seems to be b/c it happens in the same millisecond. Will work on a fix for that. ---

[GitHub] activemq-artemis pull request #2341: ARTEMIS-2103 - use the full openwire co...

2018-10-04 Thread gtully
Github user gtully closed the pull request at: https://github.com/apache/activemq-artemis/pull/2341 ---

[GitHub] activemq-artemis pull request #2341: ARTEMIS-2103 - use the full openwire co...

2018-10-03 Thread gtully
Github user gtully closed the pull request at: https://github.com/apache/activemq-artemis/pull/2341 ---

[GitHub] activemq-artemis pull request #2341: ARTEMIS-2103 - use the full openwire co...

2018-10-03 Thread gtully
GitHub user gtully reopened a pull request: https://github.com/apache/activemq-artemis/pull/2341 ARTEMIS-2103 - use the full openwire consumer queue for the mapped vi… …rtual topic queue binding, fix and test You can merge this pull request into a Git repository by running

[GitHub] activemq-artemis pull request #2341: ARTEMIS-2103 - use the full openwire co...

2018-10-03 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/2341 ARTEMIS-2103 - use the full openwire consumer queue for the mapped vi… …rtual topic queue binding, fix and test You can merge this pull request into a Git repository by running

[GitHub] activemq-artemis pull request #2173: ARTEMIS-1971 - close ldap context on cl...

2018-07-06 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/2173 ARTEMIS-1971 - close ldap context on clear and add support for connec… …tion pooling You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] activemq-artemis pull request #2143: ARTEMIS-1547 - replace properties remov...

2018-06-15 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/2143 ARTEMIS-1547 - replace properties removed in error from internal conf… …ig map You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] activemq-artemis pull request #1961: [ARTEMIS-1758] support SASL EXTERNAL wi...

2018-03-23 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1961#discussion_r176762803 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPConnectionCallback.java

[GitHub] activemq-artemis issue #1961: [ARTEMIS-1758] support SASL EXTERNAL with Text...

2018-03-22 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/1961 Thanks Tim, artemis will treat the key/trust-store string as a url first and then revert to file. qpid-jms expects a file only. I found some certs that work among the existing

[GitHub] activemq-artemis pull request #1961: [ARTEMIS-1758] support SASL EXTERNAL wi...

2018-03-21 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/1961 [ARTEMIS-1758] support SASL EXTERNAL with TextCertLoginModule - rework proton handler to use saslListener You can merge this pull request into a Git repository by running: $ git

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

2018-02-01 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/1832 @michaelandrepearce to make the feature work is trivial in queueimpl; to make it dynamic is a lot of code. I would have been shooting for an address setting and pulling that value

[GitHub] activemq-artemis pull request #1815: [ARTEMIS-1030] document url escaping of...

2018-01-31 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1815#discussion_r165010374 --- Diff: docs/user-manual/en/protocols-interoperability.md --- @@ -215,9 +215,11 @@ The first is the 5.x style destination filter that identifies

[GitHub] activemq-artemis issue #1820: [ARTEMIS-550] fix up test to validate CORE and...

2018-01-29 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/1820 Hope we don't lose the pictures, but this PR as it stands is too simplistic and the use case is already covered by a shared durable sub. the prefixed fqqn will be the way to go if we

[GitHub] activemq-artemis pull request #1820: [ARTEMIS-550] fix up test to validate C...

2018-01-29 Thread gtully
Github user gtully closed the pull request at: https://github.com/apache/activemq-artemis/pull/1820 ---

[GitHub] activemq-artemis pull request #1820: [ARTEMIS-550] fix up test to validate C...

2018-01-29 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1820#discussion_r164445884 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java --- @@ -698,8 +699,17 @@ private

[GitHub] activemq-artemis pull request #1820: [ARTEMIS-550] fix up test to validate C...

2018-01-26 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1820#discussion_r164162902 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java --- @@ -698,8 +699,17 @@ private

[GitHub] activemq-artemis pull request #1820: [ARTEMIS-550] fix up test to validate C...

2018-01-26 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1820#discussion_r164159618 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java --- @@ -698,8 +699,17 @@ private

[GitHub] activemq-artemis pull request #1820: [ARTEMIS-550] fix up test to validate C...

2018-01-26 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/1820 [ARTEMIS-550] fix up test to validate CORE and implement FQQN check b… …efore core auto createQueue call You can merge this pull request into a Git repository by running: $ git

[GitHub] activemq-artemis pull request #1815: [ARTEMIS-1030] document url escaping of...

2018-01-24 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/1815 [ARTEMIS-1030] document url escaping of the virtualTopicConsumerWildc… …ards value You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] activemq-artemis issue #1801: ARTEMIS-1607 OpenWire is sending responses too...

2018-01-22 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/1801 think any error from the io completion callback should result in connection.sendException(...); ---

[GitHub] activemq-artemis pull request #1785: [ARTEMIS-1030] add support for mapping ...

2018-01-22 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1785#discussion_r162907379 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/VirtualTopicToFQQNOpenWireTest.java

[GitHub] activemq-artemis pull request #1794: [ARTEMIS-1552] differenciate empty fram...

2018-01-19 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/1794 [ARTEMIS-1552] differenciate empty frame from no frame such that a nu… …ll response is accepted when valid You can merge this pull request into a Git repository by running: $ git

[GitHub] activemq-artemis pull request #1785: [ARTEMIS-1030] add support for mapping ...

2018-01-17 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/1785 [ARTEMIS-1030] add support for mapping openwire virtual topic consume… …r destinations to FQQN You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] activemq-artemis pull request #1759: [ARTEMIS-1241] check for FQQN and autoc...

2018-01-17 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1759#discussion_r162117583 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java

[GitHub] activemq-artemis pull request #1759: [ARTEMIS-1241] check for FQQN and autoc...

2018-01-17 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1759#discussion_r162113988 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java

[GitHub] activemq-artemis issue #1759: [ARTEMIS-1241] check for FQQN and autocreate q...

2018-01-12 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/1759 @mtaylor Pushed an update, with the check in the openwire session the change set is smaller and the new tests with an existing address work as expected. the prefixing remains

[GitHub] activemq-artemis pull request #1759: [ARTEMIS-1241] check for FQQN and autoc...

2018-01-11 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1759#discussion_r160949474 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/FQQNOpenWireTest.java --- @@ -315,13

[GitHub] activemq-artemis pull request #1767: [ARTEMIS-1597] validate non null callba...

2018-01-10 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/1767 [ARTEMIS-1597] validate non null callback principal for login success You can merge this pull request into a Git repository by running: $ git pull https://github.com/gtully/activemq

[GitHub] activemq-artemis issue #1759: [ARTEMIS-1241] check for FQQN and autocreate q...

2018-01-09 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/1759 I added to some existing auto create address logic in the code path which suffices for my test case. It does appear a little hacky to have three xxToUse local variables and the toString

[GitHub] activemq-artemis pull request #1759: [ARTEMIS-1241] check for FQQN and autoc...

2018-01-09 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/1759 [ARTEMIS-1241] check for FQQN and autocreate queue using the configur… …ed default routing type You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] activemq-artemis pull request #1703: [ARTEMIS-1552] ensure gssapi sasl mech ...

2017-12-12 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/1703 [ARTEMIS-1552] ensure gssapi sasl mech can deal with empty receive bu… …ffer You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] activemq-artemis pull request #1550: ARTEMIS-1435 - provide default jolokia-...

2017-09-22 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/1550 ARTEMIS-1435 - provide default jolokia-access.xml security policy in … …etc to lock down cors to http.host You can merge this pull request into a Git repository by running: $ git

[GitHub] activemq-artemis issue #1508: Artemis 1373

2017-09-05 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/1508 I will push the doc updates directly if that is ok ---

[GitHub] activemq-artemis pull request #1508: Artemis 1373

2017-09-04 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/1508 Artemis 1373 - Have the ldapLoginModule do role mapping for any artemis UserPrincipal present in the subject - support using kerberos to authenticate to ldap You can merge

[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support

2017-08-08 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/1449 The new proton-j and qpid-jms deps are in maven central. W.r.t to the tests check failing, some unrelated permissions issue with temp dir creation seems to be the root cause of them

[GitHub] activemq-artemis pull request #1449: [ARTEMIS-1310] SASL GSSAPI support

2017-08-08 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/1449 [ARTEMIS-1310] SASL GSSAPI support update to proton-j 0.20.0 and qpid-jms 0.24.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] activemq-artemis issue #1388: ARTEMIS-1264 allow role mapping via chained lo...

2017-07-07 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/1388 there is a regression in: org.apache.activemq.artemis.tests.integration.amqp.AmqpSecurityTest.testSendAndRejected org.apache.activemq.artemis.core.security.SecurityAuth

[GitHub] activemq-artemis issue #1388: ARTEMIS-1264 allow role mapping via chained lo...

2017-07-06 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/1388 note there are some api changes in the mix here, in place of cert[] the connection is passed in. This allows lower levels to pull certs or peer info from the connection on demand. Which

[GitHub] activemq-artemis pull request #1388: ARTEMIS-1264 allow role mapping via cha...

2017-07-06 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/1388 ARTEMIS-1264 allow role mapping via chained login modules Add krb5sslloginmodule that will populate userPrincipal that can be mapped to roles independently Generalised callback

[GitHub] activemq-artemis issue #1379: https://issues.apache.org/jira/browse/ARTEMIS-...

2017-07-05 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/1379 Tidied up the commit message --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] activemq-artemis issue #1379: https://issues.apache.org/jira/browse/ARTEMIS-...

2017-06-30 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/1379 also of note is the addition of the SNI support - the SNIHost is used to for the kerberos ticket grant which avoids the need to tie server principal to dns (the default name is host

[GitHub] activemq-artemis issue #1379: https://issues.apache.org/jira/browse/ARTEMIS-...

2017-06-30 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/1379 The mods to org.apache.activemq.artemis.core.remoting.impl.netty.NettyConnection#getDefaultActiveMQPrincipal may need a revisit - may go against the intent of the existing comment

[GitHub] activemq-artemis issue #1379: https://issues.apache.org/jira/browse/ARTEMIS-...

2017-06-30 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/1379 There is a bump of the apache directory-version due to clashes between minikdc and the existing test usage of 1.5.7 --- If your project is set up for it, you can reply to this email

[GitHub] activemq-artemis pull request #1379: https://issues.apache.org/jira/browse/A...

2017-06-30 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/1379 https://issues.apache.org/jira/browse/ARTEMIS-1264 first cut poc for the core client with netty connector and acceptor doing kerberos jaas.doAs around sslengine init such that the SSL

[GitHub] activemq-artemis pull request #907: ARTEMIS-883 Fix OpenWire ProducerFlowCon...

2016-12-15 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/907#discussion_r92598858 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java

[GitHub] activemq-artemis pull request #907: ARTEMIS-883 Fix OpenWire ProducerFlowCon...

2016-12-14 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/907#discussion_r92431065 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java

[GitHub] activemq-artemis pull request: ARTEMIS-356 - better support for sp...

2016-01-22 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/336 ARTEMIS-356 - better support for special characters in like selector … https://issues.apache.org/jira/browse/ARTEMIS-356 https://issues.apache.org/jira/browse/AMQ-6137 You can merge

[GitHub] activemq-artemis pull request: ARTEMIS-356 - better support for sp...

2016-01-22 Thread gtully
Github user gtully commented on the pull request: https://github.com/apache/activemq-artemis/pull/336#issuecomment-173971186 thanks justin, all over it :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-06-05 Thread gtully
Github user gtully commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-109288077 @gaohoward - this may be naive, but what happens if your pom dependency for 5.x is just: ``` dependency groupIdorg.apache.activemq/groupId