Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2466#discussion_r246563323
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTQueueCleanTest.java
---
@@ -0,0
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2466#discussion_r246562512
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -3604,4 +3605,14 @@ private
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2485
@onlyMIT, I put the `getSessionState` method back onto #2491, but #2466
will still have conflicts which you'll need to resolve once the merge on #2491
is done.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2485
@onlyMIT, can you close this PR since #2491 is in good shape now?
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2491#discussion_r246123082
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java
---
@@ -117,14
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2493
The test is correct. Creating a subscription before attempting to receive
the message defeats the point of the test as the test is ensuring that the
session is clean (i.e. no previous
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2491
The test code is correct. The state kept in an unclean session includes the
subscriptions which is why the test doesn't create a subscription before trying
to receive the message
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2491#discussion_r246075935
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java
---
@@ -117,14
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2491
IMO this should replace #2485.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2485
After looking at writing a test for this I thought the solution here was
not very intuitive so I opened #2491 to address this problem (with a test).
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2491
ARTEMIS-2217 remove state on clean MQTT session disconnect
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2485
I'm going to look at writing a test for this.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2469
@clebertsuconic, done.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2477
ARTEMIS-2190 move tests
The "jms-tests" module is deprecated and these tests should have never
gone in there. Moving them to the "integration-tests" module.
You
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2444
@clebertsuconic, @michaelandrepearce, do you guys think this is ready to be
merged now? It looks good to me since there is a test and the file is always
synced on `releaseResources`.
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2470#discussion_r243076837
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java
---
@@ -216,63 +216,63 @@ private static void
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2464#discussion_r243026861
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerReceiverContext.java
Github user jbertram closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2464
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2468
After looking at this a bit more closely I think this change is incorrect.
The optional carriage return (octet 13) was added in STOMP 1.2, but you have
changed
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2473
Wasn't there a Jetty issue opened about this? If so, how was that resolved?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2199
IMO this PR should be closed based on the commits from #2250. @morefuntang,
can you close it?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2467
I've read through this and it looks fine, although I can't say I understood
it all. :)
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
@RaiSaurabh, at this point there are lots of conflicts on this PR. They
either need to be fixed and this PR can move forward or it needs to be closed.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2290
I don't think there's currently any plan to merge this. Could you close
this PR, @xcorail?
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2470
Fixes for alerts from lgtm.com
After reviewing lgtm.com based on #2290 I decided to fix a handful of the
warnings and errors they reported.
You can merge this pull request into a Git
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2458#discussion_r242640005
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/impl/JMSServerManagerImpl.java
---
@@ -1719,11 +1720,11
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2469
NO-JIRA avoid unnecessary Bindings instance creation
When trying to get the bindings for an address the getBindingsForAddress
method will create a Bindings instance
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1761
@JiriOndrusek, I don't think this is going to get merged. Can you go ahead
and close this PR?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2468
Could you create a JIRA for this at
https://issues.apache.org/jira/projects/ARTEMIS and also add a test to
reproduce the failure you were seeing without the fix? Something simple
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2266
Can you close this one as well, @JiriOndrusek?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2305
@gaohoward, looks like this needs to be rebased.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2274
@franz1981, @gemmellr, is this ready to be closed or is further discussion
needed?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2256
@tabish121, is it OK by the AMQP 1.0 spec for the broker to add delivery
annotations?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1975
I think this PR is moot at this point as this change is on the master and
2.6.x branches (and Wildfly has moved to 2.6.x). @rstancel, can you close this
PR?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2265
I cherry-picked this manually. Please close this PR, @JiriOndrusek. Thanks!
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2266
I cherry-picked this manually. Please close this PR, @JiriOndrusek. Thanks!
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2412
@michaelandrepearce, I'm doing my best to clean up all the out-standing
PRs. Can you close this one if possible?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2459
Do you want to implement a better test before this is merged? The test
looks fine to me. :+1:
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2434
From what I can tell everything in this PR is sorted now. I'd like to get
this in for the upcoming 2.7.0.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2465
This does appear to be the simplest solution to a complex issue. Could you
use the
`org.apache.activemq.artemis.jms.client.ActiveMQConnection#JMS_SESSION_CLIENT_ID_PROPERTY`
constant
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2465
Could there just be a column where we dump all the session metadata?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2084
I've pulled this test into #2464 along with the fix (including removing the
2nd `send`). This PR can be closed.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2464
ARTEMIS-1859 Incorrect routing with AMQP anonymous producer & auto-created
queue
You can merge this pull request into a Git repository by running:
$ git pull https://github
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2312
I merged this on master and 2.6.x. @rpelisse, can you please close this?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2440
Can you confirm this change is backwards compatible (i.e. everything still
works with previous version of GCC)?
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2458#discussion_r240429222
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/impl/JMSServerManagerImpl.java
---
@@ -1719,11 +1720,11
Github user jbertram closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2458
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2458
I've run the PR build locally and everything worked. I'm pushing this
directly.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2458
ARTEMIS-2199 PagingStore leak when deleting queue
When deleting a queue the JMSPostQueueDeletionCallback#callback will
invoke PostOfficeImpl#getBindingsForAddress which will *create
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2434#discussion_r239530225
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java
---
@@ -53,7 +54,13
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2450
@franz1981, rebase done. :+1:
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2434#discussion_r239502825
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java
---
@@ -53,7 +54,13
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2434#discussion_r239499976
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java
---
@@ -53,7 +54,13
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2434#discussion_r239494788
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java
---
@@ -53,7 +54,13
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2449
@franz1981, I'd still love to see numbers whenever you get the chance to
post them. :+1:
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2448#discussion_r238910671
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
@@ -386,14 +386,27 @@ public
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2451
ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types
Change the LegacyLDAPSecuritySettingPlugin to interpret the search
results based on the order of the returned
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2450
ARTEMIS-2190 core JMS client leaks temp dest names
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2448#discussion_r238422596
--- Diff:
tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TemporaryDestinationTest.java
---
@@ -265,6 +266,126 @@ public
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2448
ARTEMIS-2189 allow deleting temp dest when session is closed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2438
I thought I had added docs, but I must have mistaken the divert docs for
this. I added a section in the docs for this.
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2438#discussion_r235566861
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/BridgeConfiguration.java
---
@@ -75,6 +76,8
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2439
ARTEMIS-2179 mgmnt method to get cluster-cxn names
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2438
ARTEMIS-2178 routing-type config for core bridge
MULTICAST messages forwarded by a core bridge will not be routed to any
ANYCAST queues and vice-versa. Diverts have the ability
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2437
NO-JIRA doc for divert routing-type
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis divertDoc
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2436
NO-JIRA improve logging for test System prop cleanup
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2435
NO-JIRA fix QueueControlUsingCoreTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2434#discussion_r233854063
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -3178,138 +3187,7 @@ public
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2434
ARTEMIS-1867 FQQN for producers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1867-2
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2287
The PR build is automated. You just need to update your branch so it knows
to test it again. A couple of git commands aren't really much harder than a
GitHub comment.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2287
@TomasHofman you'll need to update your branch somehow to force the PR
build to run again. I recommend something like `git commit --amend` & `push
-f`.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2426
ARTEMIS-2140 queue creation race w/AMQP shared subs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2420
Just for the record...I opened a JIRA for this, squashed your commits, and
referenced the JIRA in the commit message. Thanks for the contribution,
@jsmucr!
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2385
@jostbg, yes I think they're essentially the same.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2420
Have you confirmed that this change actually sets the RMI registry port as
expected?
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2417
ARTEMIS-2108 fix another potential StackOverflow
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2401
FWIW, management can be done through JMX or REST (via Jolokia) if
management messages are blocked for any reason.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2403
ARTEMIS-2155 disconnect on failure to handle packet
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2376
I agree with @michaelandrepearce - JMS specifics should not be built into
the console (or any part of the core broker, for that matter). The session
contains generic meta-data which can
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2388#discussion_r227609075
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
---
@@ -1540,6 +1561,75 @@ public
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2388
ARTEMIS-1856 support delays before deleting addresses & queues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/acti
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2385
ARTEMIS-1929 race in STOMP identical durable subs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2381
I ran the PR build locally and everything was good.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2381
ARTEMIS-2136 synchronize copy constructor
A synchronization block was missed during the AMQP refactoring.
This could impact use-cases involving diverts, cluster bridges
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2380
@clebertsuconic, will do. Thanks!
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2374#discussion_r225561623
--- Diff: docs/user-manual/en/management.md ---
@@ -735,8 +735,8 @@ un-formatted result of a call to
`java.lang.System.currentTimeMillis
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2374
ARTEMIS-2127 Add auth details to consumer created notification
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2345#discussion_r225517433
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2372
ARTEMIS-2126 web server can leak
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2126
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2347
@michalxo, in your test is it the management context that's leaking or
something else?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2312
@rpelisse, to restart the Travis CI build you'll need to do something like
`git commit --amend` and then `git push -f `.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2365
ARTEMIS-2121 reload logging config at runtime
Many thanks to James Perkins who supplied the guts of the reload logic.
You can merge this pull request into a Git repository by running
Github user jbertram closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2351
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2351
@michaelandrepearce, unfortunately the build I have access to no longer has
the history as too many builds have been run since then. Push your changes to
your GitHub repo and tell me
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2351
The commit for ARTEMIS-2094 needs to be reverted because (as noted on the
JIRA 10 days ago) it is breaking lots of tests. For example, all the tests
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2351
Revert "ARTEMIS-2094 - Fix Configuration change loss when network Issue"
This reverts commit cce0e1927c258ce6f3c3c3cb0d90bad5337b7d12.
You can merge this pull request
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2348
ARTEMIS-2112 Remove JMX props from start scripts
JMX configuration is now done via management.xml. Configuring JMX via
the start scripts could result in unexpected behavior since
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2347
@franz1981, thanks for the suggestion, but I don't think this is *that*
kind of leak. I came up with a way to test it and updated the PR.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2347
I couldn't find a way to write a test for this so I tested manually using
the `forceFailover()` management method on the `ActiveMQServerControl`. If
anybody has any clever ideas I'd
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2347
ARTEMIS-2111 ManagementContext can leak
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2111
1 - 100 of 1052 matches
Mail list logo
