Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2434#discussion_r239499976
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java
---
@@ -53,7 +54,13 @@
private final Map<SimpleString, Integer> routingNamePositions = new
ConcurrentHashMap<>();
- private final Map<Long, Binding> bindingsMap = new
ConcurrentHashMap<>();
+ private final Map<Long, Binding> bindingsIdMap = new
ConcurrentHashMap<>();
--- End diff --
Got it. FWIW, I just changed the name of the variable here to differentiate
it from the new one I added. Given it's been working fine (as far as we know)
so far I'd say it should stay the same and we can change it in another PR if
necessary.
---
