[GitHub] activemq-artemis issue #1066: Fixes to CDI client

2017-03-06 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/1066 Looks like clebert took care of that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis pull request #1066: Fixes to CDI client

2017-03-06 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/1066 Fixes to CDI client ARTEMIS-1020 Observe process bean when finding eligible bean classes to allow producer methods. You can merge this pull request into a Git repository by running

[GitHub] activemq-artemis issue #944: ARTEMIS-904 - Remove cyclic dependencies from a...

2017-01-01 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/944 You'll need to close it. Here's a link to the checkstyle issues https://builds.apache.org/job/ActiveMQ-Artemis-PR-Build/2113/consoleFull --- If your project is set up for it, you can

[GitHub] activemq-artemis issue #944: ARTEMIS-904 - Remove cyclic dependencies from a...

2017-01-01 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/944 Also it looks like you have two PRs with the same changes now. We should merge one. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] activemq-artemis issue #944: ARTEMIS-904 - Remove cyclic dependencies from a...

2017-01-01 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/944 Looks like some checkstyle issues in the CLI module, if you could fix those up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] activemq-artemis pull request #887: ARTEMIS-849 Added CDI Integration to the...

2016-11-11 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/887 ARTEMIS-849 Added CDI Integration to the summary file. Updated hacki… …ng guide to explain how to build docs. Added doc output to gitignore. You can merge this pull request

[GitHub] activemq-artemis pull request #864: https://issues.apache.org/jira/browse/AR...

2016-10-24 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/864#discussion_r84759299 --- Diff: pom.xml --- @@ -128,8 +128,8 @@ UTF-8 UTF-8 - 1.7 - 1.7 + 1.8 --- End diff

[GitHub] activemq-artemis issue #861: ARTEMIS-756 Moving Client CDI as a main module

2016-10-24 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/861 I'm fine with the CDI stuff going in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis pull request #861: ARTEMIS-756 Moving Client CDI as a main ...

2016-10-24 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/861#discussion_r84735641 --- Diff: artemis-rest/src/main/java/org/apache/activemq/artemis/rest/integration/EmbeddedRestActiveMQJMS.java --- @@ -20,9 +20,9 @@ import

[GitHub] activemq-artemis pull request #861: ARTEMIS-756 Moving Client CDI as a main ...

2016-10-24 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/861#discussion_r84735576 --- Diff: artemis-rest/src/main/java/org/apache/activemq/artemis/rest/Jms.java --- @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache

[GitHub] activemq-artemis pull request #861: ARTEMIS-756 Moving Client CDI as a main ...

2016-10-24 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/861#discussion_r84735762 --- Diff: artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/JMSTest.java --- @@ -0,0 +1,270 @@ +/* + * Licensed

[GitHub] activemq-artemis pull request #861: ARTEMIS-756 Moving Client CDI as a main ...

2016-10-24 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/861#discussion_r84735622 --- Diff: artemis-rest/src/main/java/org/apache/activemq/artemis/rest/integration/EmbeddedRestActiveMQ.java --- @@ -41,7 +41,7 @@ protected void

[GitHub] activemq-artemis pull request #861: ARTEMIS-756 Moving Client CDI as a main ...

2016-10-24 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/861#discussion_r84735689 --- Diff: artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/Embedded.java --- @@ -0,0 +1,91 @@ +/* + * Licensed

[GitHub] activemq-artemis pull request #861: ARTEMIS-756 Moving Client CDI as a main ...

2016-10-24 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/861#discussion_r84735729 --- Diff: artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/EmbeddedTest.java --- @@ -0,0 +1,161 @@ +/* + * Licensed

[GitHub] activemq-artemis issue #857: ARTEMIS-756 Introduced an example for CDI integ...

2016-10-24 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/857 I'm fine with moving the packages up since its just a client lib, not a true integration (as Clebert's described) --- If your project is set up for it, you can reply to this email

[GitHub] activemq-artemis issue #857: ARTEMIS-756 Introduced an example for CDI integ...

2016-10-22 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/857 I just re-kicked Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] activemq-artemis issue #857: ARTEMIS-756 Introduced an example for CDI integ...

2016-10-22 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/857 No, the finalize method issue isn't something to be worried about I don't think, except that I also tried explicitly closing the connection and it didn't work. So I'm not sure what

[GitHub] activemq-artemis issue #857: ARTEMIS-756 Introduced an example for CDI integ...

2016-10-22 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/857 Also... you keep saying OSGi. This is CDI. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis issue #857: ARTEMIS-756 Introduced an example for CDI integ...

2016-10-21 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/857 Ok, never mind on the plugin issue. Thought about it a little more and moved the profiles a bit. One odd thing, I get this in OWB but not Weld... ``` INFO

[GitHub] activemq-artemis issue #857: ARTEMIS-756 Introduced an example for CDI integ...

2016-10-21 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/857 So there's a couple of things I don't like right now - need some input from you guys. - The artemis maven plugin seems to need to redeclare dependencies. Is there a way to do

[GitHub] activemq-artemis pull request #857: ARTEMIS-756 Introduced an example for CD...

2016-10-21 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/857 ARTEMIS-756 Introduced an example for CDI integration, added a README… … to explain how it works. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis issue #800: POC for CDI Integration in Artemis

2016-09-28 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/800 Ok, I think the clean up work is done. - Tests executable for both OWB and Weld. I think its low risk to only run Weld tests in CI, even though OWB is nice and all. - All

[GitHub] activemq-artemis issue #808: Add javax inject dependancy, is part of the dis...

2016-09-28 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/808 LGTM. I'll merge, since it's going to impact my PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] activemq-artemis issue #800: POC for CDI Integration in Artemis

2016-09-27 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/800 Hmm ok. I was using the JMSContext, but getting issues there, decided to step back, see if it was an issue. It does look like though I don't have to start the connection the first go

[GitHub] activemq-artemis pull request #800: POC for CDI Integration in Artemis

2016-09-25 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/800 POC for CDI Integration in Artemis This PR isn't ready to go. However, two issues I'm running into. - When running tests, it cannot locate the JBoss Log Manager. I'm assuming

[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...

2016-09-21 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/789 @clebertsuconic agreed. This does look like an awesome idea though for end users trying to test with messaging systems. --- If your project is set up for it, you can reply

[GitHub] activemq-artemis issue #741: ARTEMIS-702 JMS 2 spec violation for receiveBod...

2016-09-06 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/741 @clebertsuconic I'm assuming all the tests you're running are in the code base right? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

2016-09-06 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/754#discussion_r77727346 --- Diff: RELEASING.md --- @@ -45,6 +55,26 @@ mvn clean release:prepare -DautoVersionSubmodules=true -Prelease

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

2016-09-06 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/754#discussion_r77727254 --- Diff: RELEASING.md --- @@ -36,6 +36,16 @@ The file will be located under ./artemis-pom/RELEASE/ Remove these files manually under Nexus

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

2016-09-06 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/754#discussion_r77720861 --- Diff: RELEASING.md --- @@ -45,6 +55,26 @@ mvn clean release:prepare -DautoVersionSubmodules=true -Prelease

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

2016-09-06 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/754#discussion_r77720730 --- Diff: RELEASING.md --- @@ -36,6 +36,16 @@ The file will be located under ./artemis-pom/RELEASE/ Remove these files manually under Nexus

[GitHub] activemq-artemis pull request #725: Add forceShutdown core management operat...

2016-08-17 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/725#discussion_r75113156 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java --- @@ -1983,6 +1983,12

[GitHub] activemq-artemis pull request #:

2016-08-17 Thread johnament
Github user johnament commented on the pull request: https://github.com/apache/activemq-artemis/commit/76288a3ad9f468332cba2580b63cb0da79b6ccc3#commitcomment-18671852 In pom.xml: In pom.xml on line 591: That would be here: https://github.com/apache/activemq-artemis/blob

[GitHub] activemq pull request #194: Renamed README file. Updated link for encryption...

2016-08-15 Thread johnament
Github user johnament closed the pull request at: https://github.com/apache/activemq/pull/194 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] activemq-artemis issue #718: just some refactorings

2016-08-11 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/718 Could you create a Jira and reference it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis issue #717: Logs, docs and CLI

2016-08-10 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/717 Let me give it a shot.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] activemq-artemis pull request #712: Artemis 447

2016-08-10 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/712#discussion_r74238129 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/proton/ProtonTest.java --- @@ -211,6 +213,25

[GitHub] activemq-artemis pull request #712: Artemis 447

2016-08-10 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/712#discussion_r74238033 --- Diff: artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/context/AbstractConnectionContext.java --- @@ -73,6 +76,8

[GitHub] activemq-artemis issue #706: ARTEMIS-671 Returning messages after connection...

2016-08-09 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/706 BTW -> SOP = System.out.println instead of logging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] activemq-artemis pull request #706: ARTEMIS-671 Returning messages after con...

2016-08-08 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/706#discussion_r73975246 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/logs/AssertionLoggerHandler.java --- @@ -71,6 +71,26 @@ public static

[GitHub] activemq pull request #194: Renamed README file. Updated link for encryption...

2016-08-04 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq/pull/194 Renamed README file. Updated link for encryption and location of LICENSE. Formatting looks better IMHO, if you want to take a look: https://github.com/johnament/activemq/blob/master/README.md

[GitHub] activemq-artemis pull request #691: ARTEMIS-659 Remove unneeded CDI dependen...

2016-08-01 Thread johnament
Github user johnament closed the pull request at: https://github.com/apache/activemq-artemis/pull/691 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] activemq-artemis issue #691: ARTEMIS-659 Remove unneeded CDI dependency. Swi...

2016-08-01 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/691 Closing out since Clebert pushed his own version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] activemq-artemis issue #694: ARTEMIS-659 Remove unneeded CDI dependency

2016-08-01 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/694 If that comes in, I'll bring in a separate dependency from geronimo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] activemq-artemis issue #672: [ARTEMIS-642] Disable slow client reconnecting ...

2016-08-01 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/672 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] activemq-artemis pull request #691: ARTEMIS-659 Remove unneeded CDI dependen...

2016-08-01 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/691#discussion_r73035248 --- Diff: pom.xml --- @@ -349,16 +349,9 @@ -javax.enterprise -cdi-api

[GitHub] activemq-artemis issue #672: [ARTEMIS-642] Disable slow client reconnecting ...

2016-08-01 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/672 @clebertsuconic think we can add the version aware stuff to the hacking guide? Would be useful for those not very familiar to know how to deal with it. --- If your project is set up

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-08-01 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72964880 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java --- @@ -387,4

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-08-01 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72964784 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -162,6

[GitHub] activemq-artemis pull request #691: ARTEMIS-659 Remove unneeded CDI dependen...

2016-07-31 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/691#discussion_r72918082 --- Diff: pom.xml --- @@ -349,16 +349,9 @@ -javax.enterprise -cdi-api

[GitHub] activemq-artemis pull request #691: ARTEMIS-659 Remove unneeded CDI dependen...

2016-07-31 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/691 ARTEMIS-659 Remove unneeded CDI dependency. Switch to geronimo atinj… …ect JAR in all uses. It turned out the client wasn't even using the dependency and the JARs were

[GitHub] activemq-artemis issue #684: ARTEMIS-565 Dealing with ClassLoading issues on...

2016-07-29 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/684 At this point, this is the best solution to ensure that it works across different impls and spec jars. +1 --- If your project is set up for it, you can reply to this email and have your

[GitHub] activemq-artemis issue #684: ARTEMIS-565 Dealing with ClassLoading issues on...

2016-07-28 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/684 Mmmph. So I can fix the spec jar for geronimo, but the problem will persist in the other spec jars, e.g. the same problem happens w/ the RI JAR and the JBoss JAR. Minor issue

[GitHub] activemq-artemis issue #684: ARTEMIS-565 Dealing with ClassLoading issues on...

2016-07-28 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/684 If you don't mind, let me take a look over the weekend. This sounds like more of an issue with the geronimo spec jar, which we can get changes into. https://github.com/apache

[GitHub] activemq-artemis issue #684: ARTEMIS-565 Dealing with ClassLoading issues on...

2016-07-28 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/684 What was happening prior to this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis pull request #682: Adding set -e on merge script

2016-07-28 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/682#discussion_r72696319 --- Diff: scripts/merge-PR.sh --- @@ -16,6 +16,8 @@ # specific language governing permissions and limitations # under the License

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-28 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72686789 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java --- @@ -387,4

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-28 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72686692 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -759,6

[GitHub] activemq-artemis pull request #680: Null pointer/check related fixes

2016-07-28 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/680#discussion_r72686371 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/FileUtil.java --- @@ -63,10 +63,15 @@ public static final boolean

[GitHub] activemq-artemis pull request #682: Adding set -e on merge script

2016-07-28 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/682#discussion_r72686205 --- Diff: scripts/merge-PR.sh --- @@ -16,6 +16,8 @@ # specific language governing permissions and limitations # under the License

[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...

2016-07-27 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72448663 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed

[GitHub] activemq-artemis issue #672: [ARTEMIS-642] Disable slow client reconnecting ...

2016-07-27 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/672 BTW, you may want to look at the jenkins output. May be a new test failing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] activemq-artemis issue #672: [ARTEMIS-642] Disable slow client reconnecting ...

2016-07-27 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/672 @bayern39 sorry, you're right. I just realized your changes in `failoverOrReconnect` is in the client side. --- If your project is set up for it, you can reply to this email and have

[GitHub] activemq-artemis issue #672: [ARTEMIS-642] Disable slow client reconnecting ...

2016-07-27 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/672 It strikes me that the client needs to know about this message type as well, potentially. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-27 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72421190 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/DisconnectConsumerWithKillMessage.java

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-27 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72421069 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java --- @@ -2983,6 +2988,18 @@ else

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-27 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72420954 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java --- @@ -2971,6 +2975,7 @@ public void run

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-27 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72420605 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SlowConsumerTest.java --- @@ -115,6 +119,40

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-27 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72420571 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SlowConsumerTest.java --- @@ -115,6 +119,40

[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...

2016-07-27 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72416705 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed

[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...

2016-07-26 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72306219 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed

[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...

2016-07-26 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72302279 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed

[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...

2016-07-26 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72296232 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed

[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...

2016-07-26 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72292777 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed

[GitHub] activemq-artemis pull request #662: ARTEMIS-587 add more JSON JMX mgmt metho...

2016-07-25 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/662#discussion_r72180014 --- Diff: artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/management/impl/JMSServerControlImpl.java --- @@ -796,20 +796,12

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 I pinged the PMC to add me as contributor. That will allow JIRA assignment. I must have had something cached, as this was after I rebased. --- If your project is set up

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 I just checked. its happening with my changes. I can't find this log message anywhere though. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 No problems @clebertsuconic hope it went well. I pushed up fixes, one oddity is that when starting the broker I get this on the console... ``` 20:50:26,422 INFO

[GitHub] activemq-artemis pull request #662: ARTEMIS-587 add more JSON JMX mgmt metho...

2016-07-25 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/662#discussion_r72125621 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java --- @@ -1360,6 +1359,130

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 @clebertsuconic oh, for wildfly, you'll need to add dependencies on `javax.json.api` and `org.glassfish.javax.json` modules. As far as plain library usage, the dependency tree

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 @clebertsuconic yes, once i fix the distribution the johnzon one will ship by default. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 Ah good catch. I can fix that, probably some assembly issues. I'm assuming shipping johnzon as the default is fine? --- If your project is set up for it, you can reply to this email

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-23 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 I'm not sure why Jenkins didn't write the result back, but the build did pass in Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-21 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 Ok, the changes should be good. I manually ran the integration tests that were touched, and fixed a bunch of issues identified there. I'm going to create a ticket to create

[GitHub] activemq-artemis pull request #653: ARTEMIS-548 Stomp durable sub unsubscrbe

2016-07-21 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/653#discussion_r71780013 --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-21 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 @puntogil yep, that's why i'm not saying this is ready. @mtaylor Ok, I'll clean it up. Thanks for looking at this guys! --- If your project is set up for it, you can

[GitHub] activemq-artemis pull request #640: ARTEMIS-565 Replace json.org with javax....

2016-07-17 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/640 ARTEMIS-565 Replace json.org with javax.json Javax.json is a newer JSR, but has an ASF compliant version, is pretty close to the original JSON.org API and will support a standard

[GitHub] activemq-artemis issue #617: ARTEMIS-607 Added interceptor support for MQTT ...

2016-07-05 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/617 Ok, I rebased from master and squashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis issue #617: ARTEMIS-607 Added interceptor support for MQTT ...

2016-07-05 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/617 Up to you. I won't be able to squash until this evening. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] activemq-artemis issue #618: Upgrade ApacheRat to 0.12

2016-07-04 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/618 Kicked it off again, not sure why it failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis pull request #617: ARTEMIS-607 Added interceptor support fo...

2016-07-03 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/617#discussion_r69403171 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTTest.java --- @@ -380,7 +384,8

[GitHub] activemq-artemis pull request #617: ARTEMIS-607 Added interceptor support fo...

2016-07-03 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/617 ARTEMIS-607 Added interceptor support for MQTT protocol. BTW, feel free to cry foul on things that don't look right. I was trying to follow the patterns in Stomp, but the structure

[GitHub] activemq-artemis pull request #610: Artemis build enhancements

2016-07-01 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/610#discussion_r69366465 --- Diff: pom.xml --- @@ -112,8 +112,8 @@ UTF-8 UTF-8 - 1.7 - 1.7 + 1.8 + 1.8

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/610 Well its still in the PR - https://github.com/glauciom/activemq-artemis/blob/c84c39abf0c9033a0a3b989dabee9ab12e5f030c/.mvn/wrapper/maven-wrapper.jar --- If your project is set up

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/610 @clebertsuconic maybe from your POV. However, from a release standpoint they carry the same problems. --- If your project is set up for it, you can reply to this email and have your

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/610 @clebertsuconic yep, shouldn't be an issue having it in source, just like the libaio binary. Just need to exclude it from your source release. @glauciom Even though they're

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/610 The usage of maven-wrapper.jar is fine. You just need to make sure its excluded from your source release (and probably exclude mvnw and mvnw.bat files) https://github.com/takari

[GitHub] activemq-artemis pull request #602: NO-JIRA update building instructions on ...

2016-06-26 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/602#discussion_r68509150 --- Diff: docs/hacking-guide/en/building.md --- @@ -23,9 +23,9 @@ Install `NPM` using the instructions below The new npm

[GitHub] activemq-artemis pull request: ARTEMIS-463 Refactored protocol loa...

2016-04-11 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/456 ARTEMIS-463 Refactored protocol loading code to not duplicate logic, and load from the default list. Prior to this change, when you would start the broker on the CLI, you would see

[GitHub] activemq-artemis pull request: ARTEMIS-326 Quote logging configura...

2015-12-21 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/282#discussion_r48204956 --- Diff: pom.xml --- @@ -115,11 +115,11 @@ --> -Djava.util.logging.manager=org.jboss.logmanager.LogMana

  1   2   >