[GitHub] activemq-artemis issue #2025: ARTEMIS-1815 adding exclusive-queue example

2018-04-18 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/2025 @clebertsuconic , Thanks Clebert. ---

[GitHub] activemq-artemis pull request #2025: ARTEMIS-1815 adding exclusive-queue exa...

2018-04-17 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/2025 ARTEMIS-1815 adding exclusive-queue example To highlight the new exclusive queue functionality, add "exclusive-queue" example. see contained examples/features/standard/exclu

[GitHub] activemq-artemis pull request #2017: ARTEMIS-1809 adding example of mapping ...

2018-04-16 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/2017 ARTEMIS-1809 adding example of mapping ActiveMQ 5.x Virtual Topic consumers see contained examples/protocols/openwire/virtual-topic-mapping/readme.md for details. You can merge this pull

[GitHub] activemq-artemis issue #1817: ARTEMIS-1623 add logging codes to LoggingActiv...

2018-01-31 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1817 Hi @jbertram, this is followup to #1796, does this address your points on that PR? Thanks Pat ---

[GitHub] activemq-artemis issue #1817: ARTEMIS-1623 add logging codes to LoggingActiv...

2018-01-25 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1817 @michaelandrepearce Thanks Mike ---

[GitHub] activemq-artemis pull request #1817: ARTEMIS-1623 add logging codes to Loggi...

2018-01-25 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1817 ARTEMIS-1623 add logging codes to LoggingActiveMQServerPlugin - added LoggingActiveMQServerPluginLogger to follow logging pattern - clarified DEBUG Level usage in doc

[GitHub] activemq-artemis issue #1796: ARTEMIS-1623 ActiveMQServerPlugin impl for log...

2018-01-24 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1796 @clebertsuconic no problem Clebert. I will create a new PR when I have those pending things completed. ---

[GitHub] activemq-artemis issue #1796: ARTEMIS-1623 ActiveMQServerPlugin impl for log...

2018-01-24 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1796 @clebertsuconic There was some outstanding improvements suggested by @jbertram @michaelandrepearce (above) on this PR that I have not finish yet. Can I just open a new PR

[GitHub] activemq-artemis issue #1796: ARTEMIS-1623 ActiveMQServerPlugin impl for log...

2018-01-24 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1796 I still had to do the suggested changes we discussed :( Sorry I did not think the would be merged yet. I hope to get those changes pushed to the PR in the next day or so. ---

[GitHub] activemq-artemis issue #1796: ARTEMIS-1623 ActiveMQServerPlugin impl for log...

2018-01-23 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1796 @jbertram , @michaelandrepearce Thanks for reviewing this PR. I will try to implement all the above suggestions. on the DEBUG vs. INFO I will make it clearer in the docs

[GitHub] activemq-artemis pull request #1796: ARTEMIS-1623 ActiveMQServerPlugin impl ...

2018-01-19 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1796 ARTEMIS-1623 ActiveMQServerPlugin impl for logging various broker events Similar concept to the ActiveMQ 5.x loggingBrokerPlugin. Commit includes: - plugin impl - tests

[GitHub] activemq-artemis issue #1696: NO-JIRA fixed minor regression and broken test...

2017-12-12 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1696 Thanks @michaelandrepearce , @mtaylor ---

[GitHub] activemq-artemis issue #1696: NO-JIRA fixed minor regression and broken test...

2017-12-12 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1696 - added in @michaelandrepearce commit to the PR - fixed a few minor check style infringements - added testing to exercise some of the sorting code I did not squash

[GitHub] activemq-artemis issue #1696: NO-JIRA fixed minor regression and broken test...

2017-12-11 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1696 @michaelandrepearce Thanks Mike, I updated the PR with your commit. I will do a test run tonight on the new PR. ---

[GitHub] activemq-artemis issue #1696: NO-JIRA fixed minor regression and broken test...

2017-12-10 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1696 - reverted JSON fields to origin names before #1628 - updated *.js to reflect field name reverts. ---

[GitHub] activemq-artemis issue #1696: NO-JIRA fixed minor regression and broken test...

2017-12-08 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1696 Hi @RaiSaurabh, great work on #1628. One minor point, the JSON field name changes as part of that PR causes a test to fail. That sparked the conversation above with Mike

[GitHub] activemq-artemis issue #1696: NO-JIRA fixed minor regression and broken test...

2017-12-08 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1696 @michaelandrepearce Thanks Mike, I agree about the field names in the JSON objects; IMHO they are really part of the external interface so should not be changed unless

[GitHub] activemq-artemis pull request #1696: NO-JIRA fixed minor regression and brok...

2017-12-07 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1696 NO-JIRA fixed minor regression and broken tests in ActiveMQServerControlImpl fixed minor regression and broken tests due to refactor in ARTEMIS-1364 You can merge this pull request

[GitHub] activemq-artemis pull request #1686: ARTEMIS-1534 added openwire logging (tr...

2017-12-04 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1686 ARTEMIS-1534 added openwire logging (trace level) to log openwire commands that are received/sent by the broker. This is similar to the CORE protocol packet level logging in org

[GitHub] activemq-artemis issue #1675: ARTEMIS-1526 NullpointerException in ActiveMQS...

2017-11-29 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1675 seems there were changed introduced yesterday - I will need to pick these up retest & push again. ---

[GitHub] activemq-artemis pull request #1665: ARTEMIS-1520 add connection ID to the t...

2017-11-28 Thread pgfox
Github user pgfox commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1665#discussion_r153641817 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java --- @@ -656,17 +672,15 @@ private

[GitHub] activemq-artemis pull request #1675: ARTEMIS-1526 NullpointerException in Ac...

2017-11-28 Thread pgfox
Github user pgfox commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1675#discussion_r153590458 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerView.java --- @@ -45,7 +45,7 @@ public Class

[GitHub] activemq-artemis pull request #1675: ARTEMIS-1526 NullpointerException in Ac...

2017-11-28 Thread pgfox
Github user pgfox commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1675#discussion_r153589625 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerView.java --- @@ -45,7 +45,7 @@ public Class

[GitHub] activemq-artemis pull request #1675: ARTEMIS-1526 NullpointerException in Ac...

2017-11-28 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1675 ARTEMIS-1526 NullpointerException in ActiveMQServerControl.listConsumers() race condition between listConsumers() and client closing a Session . Avoid NullPointerException and return empty

[GitHub] activemq-artemis pull request #1669: ARTEMIS-1524 avoid null pointer due to ...

2017-11-25 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1669 ARTEMIS-1524 avoid null pointer due to race condition in listAddresses() The listAddresses() retrieves the list of addresses and then retrieves the detail of each one to build the Json

[GitHub] activemq-artemis pull request #1668: ARTEMIS-1522 add date to timestamp in l...

2017-11-24 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1668 ARTEMIS-1522 add date to timestamp in logs Currently the date can derived from the log file prefix but in scenarios where you are only seeing snippets of log files or these log files

[GitHub] activemq-artemis pull request #1665: ARTEMIS-1520 add connection ID to the t...

2017-11-23 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1665 ARTEMIS-1520 add connection ID to the trace logging for reading/writing packets. This helps correlate the packets read/written to an individual tcp connection By setting

[GitHub] activemq-artemis issue #1643: ARTEMIS-1502 added addressMemorySize and pagin...

2017-11-19 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1643 Thanks @mtaylor. I will close this PR as it is the wrong approach, maybe followup later with another PR. ---

[GitHub] activemq-artemis pull request #1643: ARTEMIS-1502 added addressMemorySize an...

2017-11-19 Thread pgfox
Github user pgfox closed the pull request at: https://github.com/apache/activemq-artemis/pull/1643 ---

[GitHub] activemq-artemis pull request #1642: NO-JIRA - minor updates to sample, so i...

2017-11-06 Thread pgfox
Github user pgfox commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1642#discussion_r149118258 --- Diff: examples/features/standard/large-message/src/main/resources/jndi.properties --- @@ -16,5 +16,5 @@ # under the License

[GitHub] activemq-artemis pull request #1642: NO-JIRA - minor updates to sample, so i...

2017-11-06 Thread pgfox
Github user pgfox commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1642#discussion_r149115107 --- Diff: examples/features/standard/large-message/src/main/resources/jndi.properties --- @@ -16,5 +16,5 @@ # under the License

[GitHub] activemq-artemis issue #1643: ARTEMIS-1502 added addressMemorySize and pagin...

2017-11-05 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1643 @mtaylor I changed ActiveMQServerControlImpl#listAddresses(java.lang.String, int, int) to use `` server.getManagementService().getResources(AddressControl.class) `` rather

[GitHub] activemq-artemis pull request #1643: ARTEMIS-1502 added addressMemorySize an...

2017-11-05 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1643 ARTEMIS-1502 added addressMemorySize and paging info to addresslist You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq

[GitHub] activemq-artemis pull request #1642: NO-JIRA - minor updates to sample, so i...

2017-11-04 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1642 NO-JIRA - minor updates to sample, so it works as described in comments The LargeMessageExample was not working as described in docs: - FILESIZE was set to 1 MiB instead of 2 GiB

[GitHub] activemq-artemis pull request #1637: NO-JIRA minor typo in doc'd config samp...

2017-11-03 Thread pgfox
Github user pgfox closed the pull request at: https://github.com/apache/activemq-artemis/pull/1637 ---

[GitHub] activemq-artemis issue #1637: NO-JIRA minor typo in doc'd config sample

2017-11-03 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1637 @clebertsuconic thanks Clebert ... will close it now. ---

[GitHub] activemq-artemis pull request #1637: NO-JIRA minor typo in doc'd config samp...

2017-11-03 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1637 NO-JIRA minor typo in doc'd config sample You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis config_transport_doc

[GitHub] activemq-artemis pull request #1557: NO-JIRA minor typos in console

2017-09-27 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1557 NO-JIRA minor typos in console minor typos that showed on the console You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq

[GitHub] activemq-artemis issue #1543: ARTEMIS-1436 update CLI StatQueue to allow gre...

2017-09-26 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1543 add the greater_than/less_than only the filter objects of *.js that have numeric values to filter by ---

[GitHub] activemq-artemis issue #1543: ARTEMIS-1436 update CLI StatQueue to allow gre...

2017-09-26 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1543 @mtaylor sure, will give that go. ---

[GitHub] activemq-artemis issue #1543: NO-JIRA update StatQueue to allow greater_than...

2017-09-25 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1543 sure, will do that, thanks @clebertsuconic ---

[GitHub] activemq-artemis issue #1549: ARTEMIS-1433 adding AddressMemoryUsage()/Addre...

2017-09-22 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1549 @jbertram I have added getAddressMessageUsage as an attribute; in worst case scenario, if many clients constantly refresh their mBean view, this could result in a high number

[GitHub] activemq-artemis pull request #1549: ARTEMIS-1433 adding AddressMemoryUsage(...

2017-09-22 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1549 ARTEMIS-1433 adding AddressMemoryUsage()/AddressMemoryUsagePercentage() expose the total amount of memory used by the Addresses on the broker and express it as a percentage

[GitHub] activemq-artemis pull request #1543: NO-JIRA update StatQueue to allow GREAT...

2017-09-19 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1543 NO-JIRA update StatQueue to allow GREATER_THAN/LESS_THAN operations You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq

[GitHub] activemq-artemis pull request #1541: ARTEMIS-1423 numeric filtering for Acti...

2017-09-16 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1541 ARTEMIS-1423 numeric filtering for ActiveMQServerControl.listQueues() This also applies to listAddresses()/listSessions() Also to add GREATER_THAN and LESS_THAN operations

[GitHub] activemq-artemis pull request #1526: NO-JIRA add unit tests for ActiveMQServ...

2017-09-08 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1526 NO-JIRA add unit tests for ActiveMQServerControl listAddresses() unit tests for ActiveMQServerControl listAddresses() and listConsumers() You can merge this pull request into a Git

[GitHub] activemq-artemis issue #1503: NO-JIRA added unit test to exercise ActiveMQSe...

2017-09-06 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1503 @clebertsuconic sorry about that. I will fix that up and push this again thanks Pat ---

[GitHub] activemq-artemis issue #1506: ARTEMIS-1384 adding CLI command (stat) to disp...

2017-09-05 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1506 changed to ``` ./artemis queue stat ... ``` ---

[GitHub] activemq-artemis issue #1506: ARTEMIS-1384 adding CLI command (qstat) to dis...

2017-09-05 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1506 @clebertsuconic hi Clebert, perhaps I am missing something; I am already extending from AbstractAction. AbstractAction extends from ConnectionAbstract. So I seem to be getting all

[GitHub] activemq-artemis issue #1506: ARTEMIS-1384 adding CLI command (qstat) to dis...

2017-09-05 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1506 @jbertram Thanks Justin. I will move it under the queue group as you suggested. ---

[GitHub] activemq-artemis issue #1506: ARTEMIS-1384 adding CLI command (qstat) to dis...

2017-09-05 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1506 Updated to filter on any of the columns returned ``` $ ./artemis qstat --user admin --password admin --field ADDRESS --operation EQUALS --value test500 |NAME

[GitHub] activemq-artemis pull request #1506: ARTEMIS-1384 adding CLI command (qstat)...

2017-09-04 Thread pgfox
Github user pgfox commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1506#discussion_r136872715 --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/QueueStats.java --- @@ -0,0 +1,195 @@ +/* + * Licensed

[GitHub] activemq-artemis pull request #1506: ARTEMIS-1384 adding CLI command (qstat)...

2017-09-02 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1506 ARTEMIS-1384 adding CLI command (qstat) to display basic queue stats simple CLI command that displays minimal/basic stats for a queue by using the ActiveMQServerControl.listQueues

[GitHub] activemq-artemis pull request #1503: NO-JIRA added unit test to exercise Act...

2017-09-01 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1503 NO-JIRA added unit test to exercise ActiveMQServerControl.listQueues() You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq

[GitHub] activemq-artemis pull request #1500: ARTEMIS-1381 add JMX operation removeAl...

2017-08-31 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1500 ARTEMIS-1381 add JMX operation removeAllMessages() to the queue it would be good to add a removeAllMessages() JMX operation to clear all messages from the queue, to make it a little more

[GitHub] activemq-artemis pull request #1488: ARTEMIS-1370 - consumer command, does n...

2017-08-23 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1488 ARTEMIS-1370 - consumer command, does not offer a ClientID command line… … arg You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] activemq-artemis pull request #1474: NO-JIRA removed out of date info regard...

2017-08-19 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1474 NO-JIRA removed out of date info regarding jms queue specific config minor doc update to remove out of date info regarding jms queue configuration You can merge this pull request

[GitHub] activemq-artemis issue #1453: minor update to log message in browser command

2017-08-09 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1453 @clebertsuconic @michaelandrepearce Sure, your suggested changes should be in the pull request now. Thanks --- If your project is set up for it, you can reply

[GitHub] activemq-artemis pull request #1453: minor update to log message in browser ...

2017-08-09 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1453 minor update to log message in browser command You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis

[GitHub] activemq-artemis pull request #1424: fixed some minor typos in description w...

2017-07-28 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1424 fixed some minor typos in description within option annotations You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis

[GitHub] activemq-artemis issue #905: added unit test for setting the user and passwo...

2016-12-07 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/905 @jbertram, as you suggested, enabled security on the test broker and add a role to ensure credentials passed with connection. Also enabled the default user to ensure existing tests

[GitHub] activemq-artemis issue #905: added unit test for setting the user and passwo...

2016-12-07 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/905 @jbertram sure, I will give that a go --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis pull request #905: added unit test for setting the user and...

2016-12-07 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/905 added unit test for setting the user and password in the uri for tcp … …transport, used in JNDI. Could not find an example in the existing unit tests. You can merge this pull

[GitHub] activemq-artemis pull request #553: Doc minor updates

2016-06-02 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/553 Doc minor updates 2 minor alterations to the docs - I think these are correct from my testing. Best Regards Pat You can merge this pull request into a Git repository

[GitHub] activemq-artemis pull request: a few tiny doc typos

2016-05-23 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/530 a few tiny doc typos some minor doc typo fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis minor_doc_typos

[GitHub] activemq-artemis pull request: adding 2 links to the examples chap...

2016-05-20 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/528 adding 2 links to the examples chapter added 2 links to the example chapter which were omitted Best Regards Pat You can merge this pull request into a Git repository

[GitHub] activemq-artemis pull request: fixing typo in doc link

2016-05-19 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/527 fixing typo in doc link You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis doc_link_update Alternatively you can

[GitHub] activemq pull request: AMQ-5318: JDBC store; commit called on conn...

2014-08-09 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq/pull/43 AMQ-5318: JDBC store; commit called on connection that uses autocommit during deleteAllMessages issue reported at AMQ-5318 You can merge this pull request into a Git repository by running