Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> Id agree, im just cautious as we've been hit a few times with concurrency
issues that have been a nightmare to find (and quite recently as last month!).
em.Could you ple
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245252912
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -278,21 +293,26 @@ public boolean
Github user wy96f closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2481
---
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2482#discussion_r245195927
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java
---
@@ -120,6 +128,8 @@ public
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> > CursorIterator:hasNext
>
> Im bit concerned with this doing a dirty read, as this isnt something
that is trigger an ascyn action, in actual fact the hasNext is
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245183888
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -278,21 +293,26 @@ public boolean
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2481
> interim
Yes. The problem did't occur these days. We'll give more investigation.
---
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2481
@franz1981 thanks for your advice. We've enabled gc log and run the nano
program. Any news will be reported:)
---
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2481
@franz1981 thanks for the explanation. We have verified nanoTime is
correctly supported. We observed the queue delivered messages and received no
messages for abount 2mins, then broker
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2481
We add a pending counter to count enterCritical calls. If left time is less
than enter time and pending counter equals to 0, we don't expire component as
all threads have called
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2481
@michaelandrepearce @franz1981
Here is the code of System::nanoTime from openjdk:
jlong os::javaTimeNanos() {
if (Linux::supports_monotonic_clock()) {
struct timespec
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2481
ARTEMIS-2213 don't expire critical component in the case of clock back drift
In our production cluster some brokers crashed. There is nothing unusual in
the dump stack. After digging
Github user wy96f closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2476
---
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2476
Fix deadlock while getting queue message count during cleanup
ARTEMIS-2123 introduced a deadlock bug.
jstack shows:
Thread 1
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2446
ARTEMIS-2188 fix address size leak caused by large page message
When we write a paged large message,
addLiveMessage->incrementDelayDeletionCount->
incrementRefCount->on
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2445
ARTEMIS-2187 remove page from softcache before consumedpage
We found some PageCursorInfo in consumedPage map even if these
corresponding page file is deleted.
Suppose
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2444
> nice catch then.. i will merge this and back port into 2.6.x
I just found in ServerSessionImpl::messageToLargeMessage,
StompSession::sendInternalLarge
, ReplicationEndpo
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2444#discussion_r236911890
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java
---
@@ -1018,6 +1018,7
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2444
> I am a bit confused as a file.close would issue a sync.
It won't. As man page said:
A successful close does not guarantee that the data has been successfully
saved to d
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2444
> From the description it is unclear what is meant by "server crash". JVM
crash or host/machine crash. If the problem occured with unexpected JVM process
termination maybe t
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2444
ARTEMIS-2186 Large message incomplete when server is crashed
When sending large message, the large message file on server side is not
synced whereas the journal record or paged message
Github user wy96f closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2443
---
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2443
ARTEMIS-2186 Large message incomplete when server is crashed
When sending large message, the large message file on server side is not
synced whereas the journal record or paged message
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2414#discussion_r230972615
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1244,6
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2414#discussion_r230676923
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1244,6
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2405
ARTEMIS-2158 don't get pagedMessage if it's nontransactional
Transaction id of the non transactional paged message is -1. When we
acknowledge the message, we judge transactionID <
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2369
> @wy96f are you waiting a release to apply your patch?
@clebertsuconic We have an internal branch. We will upgrade our cluster
after a month.
---
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2369
@clebertsuconic @franz1981 Hi, this bug occurred in our production
environment yesterday. Our topic has one subscription without messages at the
moment. Though the consumers subscribed
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2369#discussion_r225769985
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
---
@@ -599,6 +600,18
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2369#discussion_r224977706
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
---
@@ -599,6 +600,29
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2369#discussion_r224977450
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
---
@@ -599,6 +600,29
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2369#discussion_r224976508
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
---
@@ -599,6 +600,29
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2369#discussion_r224976264
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
---
@@ -599,6 +600,29
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2369
ARTEMIS-2123 Paging not stopped if there are no consumers on one
subscription
Reproduction steps:
1. create a topic t and two subscriptions ta, tb
2. send messages to both ta
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2339
@clebertsuconic Could you look at this PR?
---
Github user wy96f closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2339
---
GitHub user wy96f reopened a pull request:
https://github.com/apache/activemq-artemis/pull/2339
ARTEMIS-2102 delete paging directory or table if address is removed
Our app uses clientRequestor to get message count or other metrics.
When the broker is globally full(all
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2339
ARTEMIS-2102 delete paging directory or table if address is removed
Our app uses clientRequestor to get message count or other metrics.
When the broker is globally full(all
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2324
ARTEMIS-2092 fix first page messages lost on server crash bug
Reproduction steps:
1. Send messages(using non transactional session), ensure the queue enters
page mode and only one
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2155
@michaelandrepearce Sorry for the late reply. I rebase the code and tests
pass.
---
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2171
ARTEMIS-1966 Replication channel closed but not connection if flow coâ¦
We use SharedNothing Activation. If flow control occurs during replication,
replication channel would be closed
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2166
We've encountered same problem. Live server will force another page when
backup server connects to live server. If zero size page is generated at first
and at last, page files would
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2155
Test resolved:)
---
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2155
Hi, michaelandrepearce, thanks for review, test has been added to validate
the issue:)
---
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2155
ARTEMIS-1949 fix IllegalMonitorStateException during shutdown
During server shutdown, the exception occurs as follows:
2018-06-19 16:23:03,503 WARN
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2133
ARTEMIS-1923 fix constructing binding journalimpl bug
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wy96f/activemq-artemis
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2114
ARTEMIS-1891 Sending synchronization finished packet starves when thread
pool is full
After sending pages, the thread will hold the storage manager write lock
and send synchronization
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1895#discussion_r170562278
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashMap.java
---
@@ -460,7 +468,7 @@ private
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/1851
@franz1981 Hi, I'm a little puzzled about padding technique. In your
example, i know that stampedLock fileds are in different cache lines for
different sections but fields like capacity
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/1851
@franz1981 1. I agree 2. Adding unsafe is not trivial and lazySet is
enough 3. size() is seldomly called, isn't it? 4. We can add
@sun.misc.Contended in Section class, right?
---
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/1851
@michaelandrepearce hi, i don't get what you mean the test. Why do we need
a suit test? And where should the test be put to stop from running by CI buid?
---
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/1851
Oops, i deleted the branch :( It seems not possible to reopen. I'll create
a new one.
---
Github user wy96f closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1851
---
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/1851
@franz1981 lazySet is used to update capacity. Please review it :)
---
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/1851
Sorry for the late reply. Using lazySet to update capacity filed is a good
point. As for the test, I modified test as follows:
@Test
public void concurrentInsertionsAndReads
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/1867
ARTEMIS-1679 Stopping consumer no need to wait until all queued tasksâ¦
Sping's SimpleMessageListenerContainer shutdown will stop consumers and
then close them. It will take lots of time
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/1851
Hi, franz1981. Thanks for the review. The jira issue is ARTEMIS-1664.
---
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/1851
fix npe bug while getting element in the process of rehash
Hi, we found a bug in ConcurrentLongHashMap, as follows:
12:32:31,000 WARN
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/1850
init pagingFactory with journalBufferTimeout_NIO
PagingFactory is wrongly initialized with journalBufferSize_NIO not
journalBufferTimeout_NIO.
You can merge this pull request into a Git
59 matches
Mail list logo
