[GitHub] activemq-artemis issue #1428: ARTEMIS-1308: Delegate acknowlegde to ClientMe...

2017-08-05 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1428 Have added a test case to ensure perf is at least double when many message, we expect it to be more as it should no longer block at all and it is, but was a good way to test

[GitHub] activemq-artemis issue #1428: ARTEMIS-1308: Delegate acknowlegde to ClientMe...

2017-08-05 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1428 PR builds don't "merge with master" in any kind of automatic way. The PR build simply builds the PR. It's up to the submitter to rebase on master if necessary. --- If your project is

[GitHub] activemq-artemis issue #1428: ARTEMIS-1308: Delegate acknowlegde to ClientMe...

2017-08-05 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1428 @franz1981 looks like its sporadic. just done two builds and it didn't occur again --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] activemq-artemis issue #1428: ARTEMIS-1308: Delegate acknowlegde to ClientMe...

2017-08-05 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1428 @franz1981 i assume it would i thought PR builds merge with master, as such should pick up, I've forced it to rebuild by doing a whitespace push to see if its sporadic or not.

[GitHub] activemq-artemis issue #1428: ARTEMIS-1308: Delegate acknowlegde to ClientMe...

2017-08-05 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1428 @michaelandrepearce try to see if you version include this: https://github.com/apache/activemq-artemis/commit/74f243cc4d9ec46f041e765148bdcb8be5af8b10 It's a fix for that test ---

[GitHub] activemq-artemis issue #1428: ARTEMIS-1308: Delegate acknowlegde to ClientMe...

2017-08-05 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1428 @clebertsuconic @franz1981 i believe i have this PR working except i am getting one test failure, see below.

[GitHub] activemq-artemis issue #1428: ARTEMIS-1308: Delegate acknowlegde to ClientMe...

2017-08-02 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1428 Yeah seems that we need to somehow ensure when redelivery or consumer.close is called to ensure any waiting batched packets are send and confirmed. It seems some acks are still

[GitHub] activemq-artemis issue #1428: ARTEMIS-1308: Delegate acknowlegde to ClientMe...

2017-08-01 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1428 This is causing a few failures on the testsuite: Test Name | Duration | Age -- | -- | --

[GitHub] activemq-artemis issue #1428: ARTEMIS-1308: Delegate acknowlegde to ClientMe...

2017-08-01 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1428 would be too much to ask you to send a PR on the 1.x branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] activemq-artemis issue #1428: ARTEMIS-1308: Delegate acknowlegde to ClientMe...

2017-07-29 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1428 This is def improvement over the first patch I saw. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] activemq-artemis issue #1428: ARTEMIS-1308: Delegate acknowlegde to ClientMe...

2017-07-29 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1428 This is def a WIP for a possible solution, but made some progress in IRC chat. don't think we are there yet entirely. --- If your project is set up for it, you can reply to

[GitHub] activemq-artemis issue #1428: ARTEMIS-1308: Delegate acknowlegde to ClientMe...

2017-07-28 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1428 How will the ack get to the broker if you don't commit the session? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If