[GitHub] activemq-artemis issue #1987: ARTEMIS-1781 Connector parameters not backward...

2018-04-17 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1987 the only reason I splitted into two commits is because it would be simpler to verify the fix. Again.. thanks a lot for this. ---

[GitHub] activemq-artemis issue #1987: ARTEMIS-1781 Connector parameters not backward...

2018-04-17 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1987 @TomasHofman Kudos.. really nice... i have done some tweaking though.. I'm removing TransportConstantsV2 and adding those properties directly on the Utility.. the

[GitHub] activemq-artemis issue #1987: ARTEMIS-1781 Connector parameters not backward...

2018-04-05 Thread TomasHofman
Github user TomasHofman commented on the issue: https://github.com/apache/activemq-artemis/pull/1987 @clebertsuconic I added my attempt at compatibility test. ---

[GitHub] activemq-artemis issue #1987: ARTEMIS-1781 Connector parameters not backward...

2018-04-03 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1987 @TomasHofman look under master/tests/compatiblity-tests There are a bunch of tests where we mix different versions using classLoading and groovy to avoid syntax

[GitHub] activemq-artemis issue #1987: ARTEMIS-1781 Connector parameters not backward...

2018-04-03 Thread TomasHofman
Github user TomasHofman commented on the issue: https://github.com/apache/activemq-artemis/pull/1987 @clebertsuconic could you point me to where you keep similar tests? So far I have a deal with EAP QE that they would create it for EAP. ---

[GitHub] activemq-artemis issue #1987: ARTEMIS-1781 Connector parameters not backward...

2018-04-03 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1987 It would be nice to have a compatibility test added. ---