Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1592
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145683623
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -1
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145441606
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -67,6 +76,8
Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145438163
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -67,6 +76,8
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145437240
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -67,6 +76,8
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145434452
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -67,6 +76,8
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145407743
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -67,6
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145407343
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,1
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145358049
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +16
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145321323
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +16
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145238929
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +154
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145235982
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +15
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145235939
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +15
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145235737
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +154
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145235758
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +154
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145235736
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +15
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145235145
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +154
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145234734
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +15
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145234463
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +154
Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145232266
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +15
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145232049
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +15
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145231515
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +154
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145231002
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +15
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145231034
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +15
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145230929
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +15
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145230933
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16 +154
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145227520
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -1
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145227400
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -1
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1592
NO-JIRA improve MQTT protocol logging
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis master_work
Alterna
29 matches
Mail list logo