[GitHub] activemq-artemis pull request #2478: ARTEMIS-2210 PagingStore creation is no...

2018-12-24 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2478#discussion_r243866712 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingManagerImpl.java --- @@ -335,19 +335,25 @@ public

[GitHub] activemq-artemis pull request #2478: ARTEMIS-2210 PagingStore creation is no...

2018-12-24 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2478#discussion_r243843391 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingManagerImpl.java --- @@ -335,19 +335,25 @@ public

[GitHub] activemq-artemis pull request #2478: ARTEMIS-2210 PagingStore creation is no...

2018-12-23 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2478 ARTEMIS-2210 PagingStore creation is not properly synchronized In PagingManagerImpl#getPageStore() the operations on the map 'stores' are not synchronzed and it's possible that more