[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245030347 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java --- @@ -0,0 +1,648 @@

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245029912 --- Diff:

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245029854 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ResetableIterator.java --- @@ -0,0 +1,29 @@

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245029745 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java --- @@ -2497,45 +2494,36 @@

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245029528 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java --- @@ -0,0 +1,648 @@

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245014300 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ResetableIterator.java --- @@ -0,0 +1,29 @@ +/* +

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245013090 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java --- @@ -0,0 +1,648 @@

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245011975 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ResetableIterator.java --- @@ -0,0 +1,29 @@

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245012214 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java --- @@ -0,0 +1,648 @@

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245010184 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java --- @@ -0,0 +1,648 @@ +/*

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245009418 --- Diff:

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245009864 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245008661 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java --- @@ -3080,45 +3053,20 @@

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245009338 --- Diff:

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245008000 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java --- @@ -2497,45 +2494,36 @@

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245007330 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java --- @@ -0,0 +1,648 @@

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245007052 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java --- @@ -0,0 +1,648 @@

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245006670 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java --- @@ -0,0 +1,648 @@

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245006519 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumers.java --- @@ -0,0 +1,34 @@ +/*

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r245006326 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Consumer.java --- @@ -21,7 +21,7 @@ import

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r244987340 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java ---

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r244986539 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java ---

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r244986350 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java ---

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r244985399 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ResetableIterator.java --- @@ -0,0 +1,29 @@ +/* +

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r244984864 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java --- @@ -3080,45 +3053,20 @@ private boolean

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r244984274 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java --- @@ -2497,45 +2494,36 @@ private void

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r244982460 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java --- @@ -0,0 +1,648 @@ +/*

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r244980096 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java --- @@ -0,0 +1,648 @@ +/*

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r244979227 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java --- @@ -0,0 +1,648 @@ +/*

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r244979032 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java --- @@ -0,0 +1,648 @@ +/*

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r244978399 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumers.java --- @@ -0,0 +1,34 @@ +/* + *

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2488#discussion_r244976790 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Consumer.java --- @@ -21,7 +21,7 @@ import

[GitHub] activemq-artemis pull request #2488: ARTEMIS-196 Implement Consumer Priority

2019-01-03 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2488 ARTEMIS-196 Implement Consumer Priority Add consumer priority support Includes refactor of consumer iterating in QueueImpl to its own logical class, to be able to