[GitHub] activemq-artemis issue #672: [ARTEMIS-642] Disable slow client reconnecting ...

2016-07-28 Thread bayern39
Github user bayern39 commented on the issue: https://github.com/apache/activemq-artemis/pull/672 @clebertsuconic Hi,Clebert,I have committed a new,I have done as you say, add a check of version ID and don't store the sessionContexts,but the last you sayed "rough the ProtocolManagers

ActiveMQ ARTEMIS-367 MQTT Tests log error checking DLQ

2016-07-28 Thread Lahiru Dilshan
I would like to work on this issue found in this link . I'm new to this and it'll be a great help if i can know

[GitHub] activemq-artemis issue #672: [ARTEMIS-642] Disable slow client reconnecting ...

2016-07-28 Thread bayern39
Github user bayern39 commented on the issue: https://github.com/apache/activemq-artemis/pull/672 @johnament I have fixed the mistake! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] activemq-artemis pull request #677: ARTEMIS-595 additional JSON fixes

2016-07-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/677#discussion_r72632899 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/CoreMessagingProxy.java --- @@

[GitHub] activemq-artemis pull request #676: ARTEMIS-569 correct method spelling

2016-07-28 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/676 ARTEMIS-569 correct method spelling You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work

[GitHub] activemq-artemis pull request #677: ARTEMIS-595 additional JSON fixes

2016-07-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/677#discussion_r72631247 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java ---

[GitHub] activemq-artemis pull request #677: ARTEMIS-595 additional JSON fixes

2016-07-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/677#discussion_r72631347 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java ---

[GitHub] activemq-artemis pull request #677: ARTEMIS-595 additional JSON fixes

2016-07-28 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/677 ARTEMIS-595 additional JSON fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis JSONfixes Alternatively

[GitHub] activemq-artemis issue #641: Update version of netty4

2016-07-28 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/641 Netty just turned around a hotfix release for issues in the 4.0.39.Final release, new version is 4.0.40.Final --- If your project is set up for it, you can reply to this email and have

[GitHub] activemq-artemis pull request #677: ARTEMIS-595 additional JSON fixes

2016-07-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/677#discussion_r72631140 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/JsonUtil.java --- @@ -295,6 +295,13 @@ else if (jsonValue

[GitHub] activemq-artemis pull request #677: ARTEMIS-595 additional JSON fixes

2016-07-28 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/677#discussion_r72633668 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/JsonUtil.java --- @@ -295,6 +295,13 @@ else if (jsonValue ==

[GitHub] activemq pull request #193: [AMQ-6380] Create pooled ConnectionFactories fro...

2016-07-28 Thread cschneider
GitHub user cschneider opened a pull request: https://github.com/apache/activemq/pull/193 [AMQ-6380] Create pooled ConnectionFactories from configs in OSGi You can merge this pull request into a Git repository by running: $ git pull https://github.com/cschneider/activemq

[GitHub] activemq-artemis pull request #678: ARTEMIS-405 more bits of JMX doc

2016-07-28 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/678 ARTEMIS-405 more bits of JMX doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-405

[GitHub] activemq-artemis pull request #677: ARTEMIS-595 additional JSON fixes

2016-07-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/677#discussion_r72635740 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/JsonUtil.java --- @@ -295,6 +295,13 @@ else if (jsonValue

[GitHub] activemq-artemis pull request #677: ARTEMIS-565 additional JSON fixes

2016-07-28 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/677#discussion_r72638984 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/JsonUtil.java --- @@ -295,6 +295,13 @@ else if (jsonValue ==

[GitHub] activemq-artemis pull request #676: ARTEMIS-569 correct method spelling

2016-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/676 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #677: ARTEMIS-565 additional JSON fixes

2016-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/677 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #679: Misc cleanups

2016-07-28 Thread scop
GitHub user scop opened a pull request: https://github.com/apache/activemq-artemis/pull/679 Misc cleanups You can merge this pull request into a Git repository by running: $ git pull https://github.com/scop/activemq-artemis misc Alternatively you can review and apply these

[GitHub] activemq-artemis pull request #680: Null pointer/check related fixes

2016-07-28 Thread scop
GitHub user scop opened a pull request: https://github.com/apache/activemq-artemis/pull/680 Null pointer/check related fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/scop/activemq-artemis npe Alternatively you can review

[GitHub] activemq-artemis pull request #679: Misc cleanups

2016-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/679 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq pull request #192: AMQ-6379 - Add openwire properties for provider ...

2016-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq/pull/192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] activemq-artemis pull request #682: Adding set -e on merge script

2016-07-28 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/682#discussion_r72696319 --- Diff: scripts/merge-PR.sh --- @@ -16,6 +16,8 @@ # specific language governing permissions and limitations # under the License.

[GitHub] activemq-artemis pull request #680: Null pointer/check related fixes

2016-07-28 Thread scop
Github user scop commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/680#discussion_r72696215 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/FileUtil.java --- @@ -63,10 +63,15 @@ public static final boolean

[GitHub] activemq-artemis pull request #683: Miscellaneous little fixes

2016-07-28 Thread scop
GitHub user scop opened a pull request: https://github.com/apache/activemq-artemis/pull/683 Miscellaneous little fixes Most found by skimming what FindBugs has to say. Some more coming later. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #682: Adding set -e on merge script

2016-07-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/682#discussion_r72701056 --- Diff: scripts/merge-PR.sh --- @@ -16,6 +16,8 @@ # specific language governing permissions and limitations # under the License.

[GitHub] activemq-artemis pull request #682: Adding set -e on merge script

2016-07-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/682#discussion_r72701040 --- Diff: scripts/merge-PR.sh --- @@ -16,6 +16,8 @@ # specific language governing permissions and limitations # under the License.

[GitHub] activemq-artemis pull request #683: Miscellaneous little fixes

2016-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/683 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #684: ARTEMIS-565 Dealing with ClassLoading issues on...

2016-07-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/684 If you build and run message-count example without this fix you will see a class not found exception. The server is not loaded worth the appClassLoader (system class loader).

[GitHub] activemq-artemis pull request #682: Adding set -e on merge script

2016-07-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/682#discussion_r72695912 --- Diff: scripts/merge-PR.sh --- @@ -16,6 +16,8 @@ # specific language governing permissions and limitations # under the License.

[GitHub] activemq-artemis issue #684: ARTEMIS-565 Dealing with ClassLoading issues on...

2016-07-28 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/684 What was happening prior to this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72704599 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java --- @@ -387,4

[GitHub] activemq-artemis pull request #682: Adding set -e on merge script

2016-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/682 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #684: ARTEMIS-565 Dealing with ClassLoading issues on...

2016-07-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/684 Will wait for you then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] activemq-artemis issue #684: ARTEMIS-565 Dealing with ClassLoading issues on...

2016-07-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/684 i thought about changing JsonProvider to cache the loaded so this wouldn't be an issue (I could load it under the right class loader once) --- If your project is set up for it, you

[GitHub] activemq-artemis issue #672: [ARTEMIS-642] Disable slow client reconnecting ...

2016-07-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/672 This is much better... now the only thing wrong is the versioning. There's no need to add any fields. When the client connects to the server it will set the versionID when

[GitHub] activemq-artemis issue #684: ARTEMIS-565 Dealing with ClassLoading issues on...

2016-07-28 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/684 If you don't mind, let me take a look over the weekend. This sounds like more of an issue with the geronimo spec jar, which we can get changes into.

Errors compiling Artemis on OS X

2016-07-28 Thread John D. Ament
I'm getting this error trying to compile Artemis. Fails on DTO generation. Tried upgrading to latest Java 8 version as well. This was working fine a couple of days ago. main: [echo] Generating XSD to: /Users/johnament/src/activemq-artemis/artemis-dto/target/schema/org.apache.activemq/dto

[GitHub] activemq-artemis pull request #684: ARTEMIS-565 Dealing with ClassLoading is...

2016-07-28 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/684 ARTEMIS-565 Dealing with ClassLoading issues on managements. Caching … …provider loaded You can merge this pull request into a Git repository by running: $ git pull

Build failed in Jenkins: ActiveMQ-Trunk-Deploy #1660

2016-07-28 Thread Apache Jenkins Server
See Changes: [christopher.l.shannon] https://issues.apache.org/jira/browse/AMQ-6377 [bloommi] AMQ-6379 - Add openwire properties for provider name, provider version, [christopher.l.shannon]

Re: Errors compiling Artemis on OS X

2016-07-28 Thread John D. Ament
For whatever reason, I need to make this change in the schemagen task. Its been fine for a while and this hasn't changed, so I'm not sure whats different. - + John On Thu, Jul 28, 2016 at 7:44 PM John D. Ament wrote: > I'm getting

Re: Errors compiling Artemis on OS X

2016-07-28 Thread Clebert Suconic
I run on Mac and everything is fine for me. What JDK you have ? On Thursday, July 28, 2016, John D. Ament wrote: > For whatever reason, I need to make this change in the schemagen task. Its > been fine for a while and this hasn't changed, so I'm not sure whats >

[GitHub] activemq-artemis issue #684: ARTEMIS-565 Dealing with ClassLoading issues on...

2016-07-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/684 @johnament I wouldn't need this whole thing if this was merged. Just sent the PR: https://github.com/apache/geronimo-specs/pull/4 I"m not sure about the

[GitHub] activemq-artemis issue #684: ARTEMIS-565 Dealing with ClassLoading issues on...

2016-07-28 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/684 Mmmph. So I can fix the spec jar for geronimo, but the problem will persist in the other spec jars, e.g. the same problem happens w/ the RI JAR and the JBoss JAR. Minor

[GitHub] activemq-artemis pull request #682: Adding set -e on merge script

2016-07-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/682#discussion_r72695491 --- Diff: scripts/merge-PR.sh --- @@ -16,6 +16,8 @@ # specific language governing permissions and limitations # under the License.

[GitHub] activemq-artemis pull request #680: Null pointer/check related fixes

2016-07-28 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/680#discussion_r72686371 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/FileUtil.java --- @@ -63,10 +63,15 @@ public static final boolean

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-28 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72686692 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -759,6

[GitHub] activemq-artemis pull request #680: Null pointer/check related fixes

2016-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/680 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-28 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72686789 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java --- @@ -387,4

[GitHub] activemq-artemis pull request #678: ARTEMIS-405 more bits of JMX doc

2016-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/678 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #681: ARTEMIS-565 fix TopicControlUsingJMSTest

2016-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/681 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #682: Adding set -e on merge script

2016-07-28 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/682 Adding set -e on merge script I had some cases where I had pending changes on my local copy and the script silent failed. This will make sure people using this script would

[GitHub] activemq-artemis pull request #682: Adding set -e on merge script

2016-07-28 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/682#discussion_r72686205 --- Diff: scripts/merge-PR.sh --- @@ -16,6 +16,8 @@ # specific language governing permissions and limitations # under the License.

[GitHub] activemq-artemis pull request #681: ARTEMIS-565 fix TopicControlUsingJMSTest

2016-07-28 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/681 ARTEMIS-565 fix TopicControlUsingJMSTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis JSONfixes