[GitHub] activemq-artemis issue #709: ARTEMIS-672 Use sh not bash in scripts

2016-08-10 Thread jdanekrh
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/709 @clebertsuconic I cannot make them run on HP-UX. I am seeing [ERROR] Failed to execute goal org.apache.activemq:artemis-maven-plugin:1.4.0-SNAPSHOT:cli (start0) on project

[GitHub] activemq-artemis issue #709: ARTEMIS-672 Use sh not bash in scripts

2016-08-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/709 @jdanekrh the example script is running zip | dezip... maybe something around that? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] activemq pull request #197: https://issues.apache.org/jira/browse/AMQ-6391

2016-08-10 Thread pdudits
GitHub user pdudits opened a pull request: https://github.com/apache/activemq/pull/197 https://issues.apache.org/jira/browse/AMQ-6391 Test case for multiple connections participating in one phase commit, causing leak in ConnectionStateTracker. Keep all the connections

[GitHub] activemq-artemis issue #709: ARTEMIS-672 Use sh not bash in scripts

2016-08-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/709 @mtaylor This looks nice to me. Can we merge it already? I have been testing it... it\s always working --- If your project is set up for it, you can reply to this email and have

[GitHub] activemq-artemis pull request #712: Artemis 447

2016-08-10 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/712#discussion_r74238033 --- Diff: artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/context/AbstractConnectionContext.java --- @@ -73,6 +76,8 @@

[GitHub] activemq-artemis issue #712: Artemis 447

2016-08-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/712 @mtaylor @grs The script we use to merge will fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] activemq-artemis pull request #709: ARTEMIS-672 Use sh not bash in scripts

2016-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/709 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #712: Artemis 447

2016-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/712 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #712: Artemis 447

2016-08-10 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/712#discussion_r74238129 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/proton/ProtonTest.java --- @@ -211,6 +213,25 @@

[GitHub] activemq-artemis issue #705: ARTEMIS-670 Adding destination creation and del...

2016-08-10 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/705 @clebertsuconic I've update my commit. pls review. Now if you run help it will print look like this: ]$ ./artemis help destination NAME artemis destination -

[GitHub] activemq-artemis pull request #715: Deploying instead of Trying to on logs

2016-08-10 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/715 Deploying instead of Trying to on logs You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis log

[GitHub] activemq-artemis issue #705: ARTEMIS-670 Adding destination creation and del...

2016-08-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/705 it looks cool on the inline help 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis issue #711: ARTEMIS-601 Implementing reload manager on JMS ...

2016-08-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/711 Testsuite passed fine --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] activemq-artemis pull request #711: ARTEMIS-601 Implementing reload manager ...

2016-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/711 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #714: ARTEMIS-677 Support websocket subprotoco...

2016-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/714 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #712: Artemis 447

2016-08-10 Thread mtaylor
Github user mtaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/712#discussion_r74240789 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/proton/ProtonTest.java --- @@ -211,6 +213,25 @@

[GitHub] activemq-artemis issue #714: ARTEMIS-677 Support websocket subprotocol hands...

2016-08-10 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/714 NPE in org.apache.activemq.artemis.tests.unit.core.remoting.impl.netty.NettyAcceptorTest.testStartStop(). --- If your project is set up for it, you can reply to this email and have your

[GitHub] activemq-artemis pull request #712: Artemis 447

2016-08-10 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/712#discussion_r74246549 --- Diff: artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/context/AbstractConnectionContext.java --- @@ -73,6 +76,8 @@ public

[GitHub] activemq-artemis issue #712: Artemis 447

2016-08-10 Thread grs
Github user grs commented on the issue: https://github.com/apache/activemq-artemis/pull/712 @mtaylor sorry, I think that was because I merged rather than rebased when syncing my fork. Will avoid that next time. @clebertsuconic thanks! --- If your project is set up for it,

[GitHub] activemq-artemis issue #709: ARTEMIS-672 Use sh not bash in scripts

2016-08-10 Thread jdanekrh
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/709 @clebertsuconic Were you able to run examples as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] activemq-artemis issue #709: ARTEMIS-672 Use sh not bash in scripts

2016-08-10 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/709 @clebertsuconic yes go ahead and merge, I had a chat with @jdanekrh and it looks like it's working on various platforms. --- If your project is set up for it, you can reply to this email

[GitHub] activemq-artemis pull request #715: Deploying instead of Trying to on logs

2016-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/715 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #716: ARTEMIS-678 refactor log for expiry opti...

2016-08-10 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/716 ARTEMIS-678 refactor log for expiry optimization You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis pull request #716: ARTEMIS-678 refactor log for expiry opti...

2016-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/716 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #705: ARTEMIS-670 Adding destination creation ...

2016-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/705 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #717: Logs, docs and CLI

2016-08-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/717 @johnament nice one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] activemq-artemis pull request #712: Artemis 447

2016-08-10 Thread grs
GitHub user grs opened a pull request: https://github.com/apache/activemq-artemis/pull/712 Artemis 447 You can merge this pull request into a Git repository by running: $ git pull https://github.com/grs/activemq-artemis ARTEMIS-447 Alternatively you can review and apply

[GitHub] activemq-artemis issue #717: Logs, docs and CLI

2016-08-10 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/717 Let me give it a shot.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] activemq-artemis pull request #717: Logs, docs and CLI

2016-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/717 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #717: Logs and docs

2016-08-10 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/717 Logs and docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis log Alternatively you can

[GitHub] activemq-artemis issue #717: Logs, docs and CLI

2016-08-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/717 PLEASE.. do not merge it yet --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] activemq-artemis issue #717: Logs, docs and CLI

2016-08-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/717 sorry.. good to go now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] activemq-artemis pull request #714: ARTEMIS-677 Support websocket subprotoco...

2016-08-10 Thread mtaylor
GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/714 ARTEMIS-677 Support websocket subprotocol handshakes You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemis

[GitHub] activemq-artemis pull request #713: [ARTEMIS-675] incorrect commentary in ex...

2016-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/713 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #712: Artemis 447

2016-08-10 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/712 @grs I'm not sure what happened here, but it seems there's some commits from your local branch or something. Could you squash or resend with just the single commit please. --- If your