[GitHub] activemq-artemis pull request #1594: ARTEMIS-1467 example showing the recomm...

2017-10-18 Thread stanlyDoge
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1594 ARTEMIS-1467 example showing the recommended approach for migrating example showing the recommended approach for migrating messages from ActiveMQ to Artemis You can merge this pull

[GitHub] activemq-artemis issue #1293: ARTEMIS-1194: SOCKS proxy support

2017-10-18 Thread adagys
Github user adagys commented on the issue: https://github.com/apache/activemq-artemis/pull/1293 Rebased 👍 ---

[GitHub] activemq-artemis pull request #1595: ARTEMIS-1466 Upgrade Node.js version to...

2017-10-18 Thread pkralik
GitHub user pkralik opened a pull request: https://github.com/apache/activemq-artemis/pull/1595 ARTEMIS-1466 Upgrade Node.js version to comply with GitBook 3.2.3 You can merge this pull request into a Git repository by running: $ git pull

Re: [VOTE] Apache ActiveMQ 5.15.2

2017-10-18 Thread Robbie Gemmell
On 17 October 2017 at 15:37, Christopher Shannon wrote: > Hi Everyone, > > I have created the ActiveMQ 5.15.2 release and it's ready for a vote. > > The list of resolved issues is here: >

[GitHub] activemq-artemis pull request #1592: NO-JIRA improve MQTT protocol logging

2017-10-18 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1592#discussion_r145358049 --- Diff: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java --- @@ -149,16

Re: [VOTE] Apache ActiveMQ 5.15.2

2017-10-18 Thread Jean-Baptiste Onofré
+1 (binding) Regards JB On Oct 18, 2017, 12:56, at 12:56, Robbie Gemmell wrote: >On 17 October 2017 at 15:37, Christopher Shannon > wrote: >> Hi Everyone, >> >> I have created the ActiveMQ 5.15.2 release and it's ready for a vote. >>

Re: [VOTE] Apache ActiveMQ 5.15.2

2017-10-18 Thread Gary Tully
+1 On Tue, 17 Oct 2017 at 21:49 Timothy Bish wrote: > +1 > > * Checked each archive to License and Notice files > * Validated signatures and checksums > * Ran the binary broker build on linux, checked web console and sent > some messages using Qpid JMS example > * Built

[GitHub] activemq-artemis pull request #1593: ARTEMIS-1463 - added SSL example + docs

2017-10-18 Thread andytaylor
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/1593 ARTEMIS-1463 - added SSL example + docs also added support for anon login https://issues.apache.org/jira/browse/ARTEMIS-1463 You can merge this pull request into a Git

[GitHub] activemq-artemis issue #1534: ARTEMIS-1420 limit non-ssl connection hangs up...

2017-10-18 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/1534 > "Connection readTimeout has occurred.", NETTY_READ_TIMEOUT = "read-timeout-seconds"; private int readTimeout; Would a more descriptive name be better here for the

[GitHub] activemq-artemis issue #1534: ARTEMIS-1420 limit non-ssl connection hangs up...

2017-10-18 Thread stanlyDoge
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1534 @mtaylor Thanks, changed. ---

Re: Time for another ASF board report

2017-10-18 Thread Daniel Kulp
Bruce, > On Oct 18, 2017, at 2:04 PM, Bruce Snyder wrote: > > There was a comment regarding Artemis added to the board report that > mentioned the following: > > 'An embedded web management console was added' > > What embedded web management console is this? Was it

Re: [VOTE] Apache ActiveMQ 5.15.2

2017-10-18 Thread W B D
+1 (non-binding) Upgraded from 5.15.1 to 5.15.2 in our staging environment; no issues, but then again 5.15.1 was also working fine for us. Using the auto transport. Clients tested were an ActiveMQ 5.14.1 Java client and a C# client using NMS ActiveMQ 1.7.2. The NMS client sometimes takes up to 30

[GitHub] activemq-artemis pull request #1597: ARTEMIS-1468 Fix delete address in cons...

2017-10-18 Thread mtaylor
GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/1597 ARTEMIS-1468 Fix delete address in console You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1468

[GitHub] activemq-artemis pull request #1592: NO-JIRA improve MQTT protocol logging

2017-10-18 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1592#discussion_r145407343 --- Diff: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java --- @@

[GitHub] activemq-artemis pull request #1596: ARTEMIS-450 Deadlocked queues over AMQP...

2017-10-18 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1596#discussion_r145416018 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQScheduledComponent.java --- @@ -251,6 +251,9 @@

[GitHub] activemq-artemis pull request #1593: ARTEMIS-1463 - added SSL example + docs

2017-10-18 Thread andytaylor
Github user andytaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1593#discussion_r145416142 --- Diff: examples/features/standard/message-counters/src/main/java/org/apache/activemq/artemis/jms/example/MessageCounterExample.java --- @@

[GitHub] activemq-artemis pull request #1592: NO-JIRA improve MQTT protocol logging

2017-10-18 Thread ppatierno
Github user ppatierno commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1592#discussion_r145434452 --- Diff: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java --- @@ -67,6

[GitHub] activemq-artemis pull request #1596: ARTEMIS-450 Deadlocked queues over AMQP...

2017-10-18 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/1596 ARTEMIS-450 Deadlocked queues over AMQP after too many cancellations You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #1597: ARTEMIS-1468 Fix delete address in cons...

2017-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1597 ---

[GitHub] activemq-artemis pull request #1593: ARTEMIS-1463 - added SSL example + docs

2017-10-18 Thread andytaylor
Github user andytaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1593#discussion_r145415855 --- Diff: examples/features/standard/message-counters/src/main/java/org/apache/activemq/artemis/jms/example/MessageCounterExample.java --- @@

[GitHub] activemq-artemis pull request #1596: ARTEMIS-450 Deadlocked queues over AMQP...

2017-10-18 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1596#discussion_r145424777 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQScheduledComponent.java --- @@ -251,6 +251,9 @@

[GitHub] activemq-artemis issue #1594: ARTEMIS-1467 example showing the recommended a...

2017-10-18 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1594 you could also use export, import? ---

[GitHub] activemq-artemis pull request #1596: ARTEMIS-450 Deadlocked queues over AMQP...

2017-10-18 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1596#discussion_r145408498 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQScheduledComponent.java --- @@ -251,6 +251,9 @@ public

[GitHub] activemq-artemis pull request #1598: ARTEMIS-1469 - Add support for trusting...

2017-10-18 Thread cshannon
GitHub user cshannon opened a pull request: https://github.com/apache/activemq-artemis/pull/1598 ARTEMIS-1469 - Add support for trusting any client certificate Added a new trustAll flag which will support trusting any client keystore when doing testing against a broker. This

[GitHub] activemq-artemis pull request #1592: NO-JIRA improve MQTT protocol logging

2017-10-18 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1592#discussion_r145407743 --- Diff: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java --- @@ -67,6

[GitHub] activemq-artemis pull request #1596: ARTEMIS-450 Deadlocked queues over AMQP...

2017-10-18 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1596#discussion_r145416958 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQScheduledComponent.java --- @@ -251,6 +251,9 @@ public

[GitHub] activemq-artemis issue #1596: ARTEMIS-450 Deadlocked queues over AMQP after ...

2017-10-18 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1596 @franz1981 I'm using an initialDelay = -1 by default now, and added some code around on start. ---

[GitHub] activemq-artemis pull request #1593: ARTEMIS-1463 - added SSL example + docs

2017-10-18 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1593#discussion_r145409876 --- Diff: examples/features/standard/message-counters/src/main/java/org/apache/activemq/artemis/jms/example/MessageCounterExample.java ---

[GitHub] activemq-artemis pull request #1596: ARTEMIS-450 Deadlocked queues over AMQP...

2017-10-18 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1596#discussion_r145411963 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQScheduledComponent.java --- @@ -251,6 +251,9 @@ public

[GitHub] activemq-artemis issue #1592: NO-JIRA improve MQTT protocol logging

2017-10-18 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1592 I just pushed the latest iteration with the suggestion from @franz1981 about using a new method as well as removing the system property and enforcing a hard limit of 256 characters when

Re: Time for another ASF board report

2017-10-18 Thread Bruce Snyder
There was a comment regarding Artemis added to the board report that mentioned the following: 'An embedded web management console was added' What embedded web management console is this? Was it built from the ground up or was it adopted from something else? Bruce On Tue, Oct 10, 2017 at 9:28

[GitHub] activemq-artemis pull request #1595: ARTEMIS-1466 Upgrade Node.js version to...

2017-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1595 ---

[GitHub] activemq-artemis pull request #1596: ARTEMIS-450 Deadlocked queues over AMQP...

2017-10-18 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1596#discussion_r145417351 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQScheduledComponent.java --- @@ -251,6 +251,9 @@ public

[GitHub] activemq-artemis pull request #1596: ARTEMIS-450 Deadlocked queues over AMQP...

2017-10-18 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1596#discussion_r145425664 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQScheduledComponent.java --- @@ -251,6 +251,9 @@ public

[GitHub] activemq-artemis issue #1596: ARTEMIS-450 Deadlocked queues over AMQP after ...

2017-10-18 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1596 @franz1981 lets not waste time.. this is such a small component... you added a new parameter that was clashing with previous usage.. all I'm doing is fix it accordingly to the

[GitHub] activemq-artemis issue #1596: ARTEMIS-450 Deadlocked queues over AMQP after ...

2017-10-18 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1596 @franz1981 It's just that I changed the meaning of getInitialDelay... -1 meaning unset.. and use the previous semantic... the change you did broke some usage.. so I had to have a

[GitHub] activemq-artemis issue #1596: ARTEMIS-450 Deadlocked queues over AMQP after ...

2017-10-18 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1596 @clebertsuconic I do not agree with that: the change I did was validated with tests and the documentation says that when the initial delay isn't specified is defaulted to period, so the

[GitHub] activemq-artemis issue #1596: ARTEMIS-450 Deadlocked queues over AMQP after ...

2017-10-18 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1596 @franz1981 nope.. you broke a test Franz. ---

[GitHub] activemq-artemis pull request #1592: NO-JIRA improve MQTT protocol logging

2017-10-18 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1592#discussion_r145437240 --- Diff: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java --- @@ -67,6 +76,8

[GitHub] activemq-artemis pull request #1592: NO-JIRA improve MQTT protocol logging

2017-10-18 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1592#discussion_r145438163 --- Diff: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java --- @@ -67,6

[GitHub] activemq-artemis pull request #1599: ARTEMIS-1470 - fix console move message

2017-10-18 Thread andytaylor
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/1599 ARTEMIS-1470 - fix console move message https://issues.apache.org/jira/browse/ARTEMIS-1470 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis issue #1596: ARTEMIS-450 Deadlocked queues over AMQP after ...

2017-10-18 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1596 using your own words.. the least astonishment way would be to have the initialDelay nullable (or -1 on this case) I'm fixing what was broken before. ---

[GitHub] activemq-artemis pull request #1596: ARTEMIS-450 Deadlocked queues over AMQP...

2017-10-18 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1596#discussion_r145455314 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQScheduledComponent.java --- @@ -90,7 +90,7 @@ public

[GitHub] activemq-artemis issue #1596: ARTEMIS-450 Deadlocked queues over AMQP after ...

2017-10-18 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1596 your test wasn’t validating semantics. The change is good. ---

[GitHub] activemq-artemis pull request #1592: NO-JIRA improve MQTT protocol logging

2017-10-18 Thread ppatierno
Github user ppatierno commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1592#discussion_r145441606 --- Diff: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java --- @@ -67,6

[GitHub] activemq-artemis issue #1596: ARTEMIS-450 Deadlocked queues over AMQP after ...

2017-10-18 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1596 @clebertsuconic It is not following the [principle of least astonishment](https://en.wikipedia.org/wiki/Principle_of_least_astonishment) from the API (and doc) perspective: if you

[GitHub] activemq-artemis issue #1596: ARTEMIS-450 Deadlocked queues over AMQP after ...

2017-10-18 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1596 @clebertsuconic It is a get of field after a set of the same that is not getting the configured/expected value: it is not what a user could expect. ---

[GitHub] activemq-artemis pull request #1596: ARTEMIS-450 Deadlocked queues over AMQP...

2017-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1596 ---

[GitHub] activemq pull request #262: AMQ-6828: Improvement to python AMQP example.

2017-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq/pull/262 ---

[GitHub] activemq-artemis issue #1598: ARTEMIS-1469 - Add support for trusting any cl...

2017-10-18 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1598 Even though it's only for testing it would still be good to have a little documentation on the option. ---

[GitHub] activemq-artemis pull request #1593: ARTEMIS-1463 - added SSL example + docs

2017-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1593 ---

[GitHub] activemq-artemis pull request #1599: ARTEMIS-1470 - fix console move message

2017-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1599 ---

[GitHub] activemq-artemis issue #1594: ARTEMIS-1467 example showing the recommended a...

2017-10-18 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1594 I believe Clebert is referring to [this tool](https://github.com/apache/activemq-cli-tools) which can be used to export from 5.x and then the resulting XML file can be imported via the