[GitHub] activemq-artemis pull request #1981: ARTEMIS-1749 - missing avariable in Win...

2018-03-29 Thread ingo1121
GitHub user ingo1121 opened a pull request: https://github.com/apache/activemq-artemis/pull/1981 ARTEMIS-1749 - missing avariable in Windows Profile An obvious fix is the missing definition of ARTEMIS_ETC_INSTANCE, in the Windows "artemis.profile.cmd" You can merge this pull

[GitHub] activemq-artemis pull request #1982: JUnit rules to be usable against extern...

2018-03-29 Thread mohamnag
GitHub user mohamnag opened a pull request: https://github.com/apache/activemq-artemis/pull/1982 JUnit rules to be usable against external secured broker as a companion to https://issues.apache.org/jira/browse/ARTEMIS-1778 this will allow using junit rules to be used against an

[GitHub] activemq-artemis pull request #1980: ARTEMIS-1777 Adding Protocol specific i...

2018-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1980 ---

[GitHub] activemq-artemis pull request #1981: ARTEMIS-1749 - missing avariable in Win...

2018-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1981 ---

[GitHub] activemq-artemis pull request #1980: ARTEMIS-1777 Adding Protocol specific i...

2018-03-29 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1980#discussion_r178144362 --- Diff: artemis-distribution/pom.xml --- @@ -102,6 +102,11 @@ artemis-amqp-protocol ${project.version}

[GitHub] activemq-artemis pull request #1980: ARTEMIS-1777 Adding Protocol specific i...

2018-03-29 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1980#discussion_r178144111 --- Diff: artemis-distribution/pom.xml --- @@ -102,6 +102,11 @@ artemis-amqp-protocol ${project.version}

[GitHub] activemq-artemis pull request #1822: ARTEMIS-1653 Allow database tables to b...

2018-03-29 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1822#discussion_r177985094 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -189,17 +187,27 @@

[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...

2018-03-29 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1976 @clebertsuconic This PR now contains all the necessary commits: what we can do now? I prefer to have just one PR with all the related commits in order to trace better why they were

[GitHub] activemq-artemis pull request #1983: ARTEMIS-1749 - Fixes the ssl-enabled-cr...

2018-03-29 Thread ingo1121
GitHub user ingo1121 opened a pull request: https://github.com/apache/activemq-artemis/pull/1983 ARTEMIS-1749 - Fixes the ssl-enabled-crl-mqtt Also, this is a pretty obvious fix. Doesn't quite fix ssl-enabled-dual-authentication , though,, You can merge this pull request into

Board report for April 2018

2018-03-29 Thread Bruce Snyder
It is time once again to submit a report to the ASF board for April. Please take 5 minutes to contribute some of the project activity to the report at the wiki page below: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75977784 This report must be submitted by April 11th. I

[GitHub] activemq-artemis issue #1982: JUnit rules to be usable against external secu...

2018-03-29 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1982 Couple of things related to your commit: 1. The commits should be squashed. 2. The commit message should follow the recommendation from the [Hacking

Re: Thoughts on refactoring the ActiveMQ website

2018-03-29 Thread Bruce Snyder
Did you read what I said in my email? > Everyone should take a look at the gitbook that Mike put together. It's a great first example. Nothing is complete. He is giving us an early preview. Bruce On Thu, Mar 22, 2018 at 11:28 AM, Arthur Naseef wrote: > I pulled down

Re: Thoughts on refactoring the ActiveMQ website

2018-03-29 Thread Arthur Naseef
Yes, I understand. Hope my feedback is constructive. If there are specifics on which feedback would by more helpful, please don’t hesitate to let me know. FYI - just saying the following in an attempt to clarify my point-of-view, not critizing... the goals of this effort are vague for me.

[GitHub] activemq-artemis pull request #1979: ARTEMIS-1776 Asynchronous Flow control ...

2018-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1979 ---

[GitHub] activemq-artemis pull request #1976: ARTEMIS-1771 Porting of JDBC NodeManage...

2018-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1976 ---

[GitHub] activemq-artemis pull request #1974: NO-JIRA browsing messages do not change...

2018-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1974 ---

[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...

2018-03-29 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1976 @clebertsuconic Done, now there is just one commit into this PR :+1: ---

[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...

2018-03-29 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1976 @franz1981 rebase please ---

[GitHub] activemq-artemis pull request #1822: ARTEMIS-1653 Allow database tables to b...

2018-03-29 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1822#discussion_r178098492 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -189,17 +187,27 @@

[GitHub] activemq-artemis pull request #1980: ARTEMIS-1777 Adding Protocol specific i...

2018-03-29 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/1980 ARTEMIS-1777 Adding Protocol specific into producer / consumer / imp You can merge this pull request into a Git repository by running: $ git pull