[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2237#discussion_r209381661
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
---
@@ -711,6 +712,32 @@ public long countMessages(final String filterStr)
throws Exception {
}
}
+ @Override
+ public String countMessagesProperty(final String filter) throws
Exception {
+ checkStarted();
+ clearIO();
+ try {
+ try (LinkedListIterator iterator =
queue.browserIterator()) {
+Map result = new HashMap<>();
+String propertySearch = filter == null ? UNDEFINED : filter;
+try {
+ while (iterator.hasNext()) {
+ MessageReference ref = iterator.next();
+ String messageProperty =
ref.getMessage().getStringProperty(propertySearch);
+ messageProperty = messageProperty == null ? UNDEFINED :
messageProperty;
+ Integer value = result.getOrDefault(messageProperty, 0);
--- End diff --
Should be SimpleString, thats initialized once.
---
[GitHub] activemq-artemis issue #2235: Make JDBC OpenFile Thread Safe
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2235 @mtaylor / @andytaylor no JIRA? ---
[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2237#discussion_r209312787
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
---
@@ -711,6 +712,32 @@ public long countMessages(final String filterStr)
throws Exception {
}
}
+ @Override
+ public String countMessagesProperty(final String filter) throws
Exception {
--- End diff --
Look at FilterImpl.createFilter to create the filter.
---
[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
Github user ArthurFritz commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2237#discussion_r209314996
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
---
@@ -711,6 +712,32 @@ public long countMessages(final String filterStr)
throws Exception {
}
}
+ @Override
+ public String countMessagesProperty(final String filter) throws
Exception {
--- End diff --
In fact it will not filter the messages, but will count the messages for
your property.
In a project I have several properties that I use in selectors, this count
will show me how many messages there are per property variation.
---
[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2237#discussion_r209315364
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
---
@@ -711,6 +712,32 @@ public long countMessages(final String filterStr)
throws Exception {
}
}
+ @Override
+ public String countMessagesProperty(final String filter) throws
Exception {
--- End diff --
Yes but using a filter to do this allows you to do that and more powerful,
and means people can use the same filtering logic theyre used to and is well
tested
---
[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
Github user ArthurFritz commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2237#discussion_r209317077
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
---
@@ -711,6 +712,32 @@ public long countMessages(final String filterStr)
throws Exception {
}
}
+ @Override
+ public String countMessagesProperty(final String filter) throws
Exception {
--- End diff --
There are already counters per filter countMessages (), in this case it
would be more a "group by", without filter, always counting the messages of the
property.
---
[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2237#discussion_r209317084
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
---
@@ -711,6 +712,32 @@ public long countMessages(final String filterStr)
throws Exception {
}
}
+ @Override
+ public String countMessagesProperty(final String filter) throws
Exception {
+ checkStarted();
+ clearIO();
+ try {
+ try (LinkedListIterator iterator =
queue.browserIterator()) {
+Map result = new HashMap<>();
+String propertySearch = filter == null ? UNDEFINED : filter;
+try {
+ while (iterator.hasNext()) {
+ MessageReference ref = iterator.next();
+ String messageProperty =
ref.getMessage().getStringProperty(propertySearch);
--- End diff --
Why only string property
---
[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
Github user ArthurFritz commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2237#discussion_r209317397
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
---
@@ -711,6 +712,32 @@ public long countMessages(final String filterStr)
throws Exception {
}
}
+ @Override
+ public String countMessagesProperty(final String filter) throws
Exception {
+ checkStarted();
+ clearIO();
+ try {
+ try (LinkedListIterator iterator =
queue.browserIterator()) {
+Map result = new HashMap<>();
+String propertySearch = filter == null ? UNDEFINED : filter;
+try {
+ while (iterator.hasNext()) {
+ MessageReference ref = iterator.next();
+ String messageProperty =
ref.getMessage().getStringProperty(propertySearch);
--- End diff --
It may be an object, however its toString will be used
---
[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2237#discussion_r209369043
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
---
@@ -711,6 +712,32 @@ public long countMessages(final String filterStr)
throws Exception {
}
}
+ @Override
+ public String countMessagesProperty(final String filter) throws
Exception {
--- End diff --
Thr point of filter isnt to be the filter currently on thr queue but to
query / filter for this count.
---
[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2237 @ArthurFritz i sent your branch a PR with a number of improvements on this, see here: https://github.com/ArthurFritz/activemq-artemis/pull/1 ---
[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2238 ARTEMIS-2023 Support 1x prefixes for JMS dests created using session In some cases users who migrate from 1.x to 2.x may still want to keep the legacy prefixes for their JMS destinations (i.e. "jms.queue.", "jms.topic.", etc.). This commit adds a boolean on our ConnectionFactory implementation so that it will use the old prefixes when invoking the queue/topic creation methods on the Session implementation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2023 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2238.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2238 commit 2cedb95ccc7078fa3d47ccb3f9b4fd233c86b9f0 Author: Justin Bertram Date: 2018-08-10T02:32:23Z ARTEMIS-2023 Support 1x prefixes for JMS dests created using session In some cases users who migrate from 1.x to 2.x may still want to keep the legacy prefixes for their JMS destinations (i.e. "jms.queue.", "jms.topic.", etc.). This commit adds a boolean on our ConnectionFactory implementation so that it will use the old prefixes when invoking the queue/topic creation methods on the Session implementation. ---
[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2237#discussion_r209369424
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
---
@@ -711,6 +712,32 @@ public long countMessages(final String filterStr)
throws Exception {
}
}
+ @Override
+ public String countMessagesProperty(final String filter) throws
Exception {
+ checkStarted();
+ clearIO();
+ try {
+ try (LinkedListIterator iterator =
queue.browserIterator()) {
+Map result = new HashMap<>();
+String propertySearch = filter == null ? UNDEFINED : filter;
+try {
+ while (iterator.hasNext()) {
+ MessageReference ref = iterator.next();
+ String messageProperty =
ref.getMessage().getStringProperty(propertySearch);
--- End diff --
But it isnt being used as such new objects will be created for no reason.
All you want to do is check if the property exists
As i said doing this with a filter to run over to get the counts will be
more powerful and clea er
---
[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2237#discussion_r209373519
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
---
@@ -63,6 +63,7 @@
public class QueueControlImpl extends AbstractControl implements
QueueControl {
public static final int FLUSH_LIMIT = 500;
+ public static final String UNDEFINED = "*_UNDEFINED_*";
--- End diff --
This isn't needed, if you getobjectproperty and do Object.toString on it,
the java standard representation "null" will return.
---
[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2237#discussion_r209375108
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
---
@@ -711,6 +712,32 @@ public long countMessages(final String filterStr)
throws Exception {
}
}
+ @Override
+ public String countMessagesProperty(final String filter) throws
Exception {
+ checkStarted();
+ clearIO();
+ try {
+ try (LinkedListIterator iterator =
queue.browserIterator()) {
+Map result = new HashMap<>();
+String propertySearch = filter == null ? UNDEFINED : filter;
+try {
+ while (iterator.hasNext()) {
+ MessageReference ref = iterator.next();
+ String messageProperty =
ref.getMessage().getStringProperty(propertySearch);
--- End diff --
You will better calling to get object as then where there maybe properties
that dont actually get stored in the property map but are actually a top level
field it would still return for all. And then you can simply call
Objects.toString on the returned object, this would also then remove the need
for undefined and would return the java normal string representation for null
---
[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2237#discussion_r209386511
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
---
@@ -1781,6 +1781,66 @@ public void testCountMessagesWithInvalidFilter()
throws Exception {
session.deleteQueue(queue);
}
+ @Test
+ public void testCountMessagesPropertyExist() throws Exception {
+ String key = new String("key_group");
+ String valueGroup1 = "group_1";
+ String valueGroup2 = "group_2";
+
+ SimpleString address = RandomUtil.randomSimpleString();
+ SimpleString queue = RandomUtil.randomSimpleString();
+
+ session.createQueue(address, queue, null, false);
+ ClientProducer producer = session.createProducer(address);
+
+ for (int i = 0; i < 100; i++) {
+ ClientMessage msg = session.createMessage(false);
+ if(i % 3 == 0){
--- End diff --
checkstyle , need to space if and curly
---
[GitHub] activemq-artemis pull request #2239: ARTEMIS-2022 Create count messages 'gro...
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2239 ARTEMIS-2022 Create count messages 'group by' this property filter Checking build You can merge this pull request into a Git repository by running: $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-2022 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2239.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2239 commit 259f3f8be9014b79503e1ed0ead8c9598f340ff6 Author: Arthur Fritz Santiago Date: 2018-08-10T14:49:16Z [ARTEMIS-2022] Create count messages 'group by' this property filter commit d7d7f7499cf7ca675f901090e3199ad71bc0f922 Author: Arthur Fritz Santiago Date: 2018-08-10T15:09:32Z [ARTEMIS-2022] Ajust checkstyle commit a01822be0bef5fd09d196a717036819257e280f6 Author: Michael André Pearce Date: 2018-08-10T21:37:26Z ARTEMIS-2022 - Enhancements Fix checkstyle Avoid duplicated logic Ability to filter and group Instantiate SimpleString property key once Get property value via getObjectProprty to ensure all special mapped properties such as in AMQPMessage would return Avoid a custom string to represent null, instead rely on Java's representation "null" by using Objects.toString to get the string value of the property value used to group by. ---
[GitHub] activemq-artemis pull request #2239: ARTEMIS-2022 Create count messages 'gro...
Github user michaelandrepearce closed the pull request at: https://github.com/apache/activemq-artemis/pull/2239 ---
[GitHub] activemq-artemis pull request #2236: [ARTEMIS-2022] Create count messages 'g...
GitHub user ArthurFritz opened a pull request: https://github.com/apache/activemq-artemis/pull/2236 [ARTEMIS-2022] Create count messages 'group by' this property filter Create a new function this is responsibility count messages determined property filter, e return one object in json, where properties to object is value of property and this value is amount messages. Actually in the project have only method count messages of determinate filter, but no has method group messages for respective property. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ArthurFritz/activemq-artemis feature/ARTEMIS-2022 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2236.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2236 commit d758bc01f6082d0a9927c350d443c6a9abaf247d Author: Arthur Fritz Santiago Date: 2018-08-10T14:13:44Z [ARTEMIS-2022] Create count messages 'group by' this property filter ---
[GitHub] activemq-artemis pull request #2236: [ARTEMIS-2022] Create count messages 'g...
Github user ArthurFritz closed the pull request at: https://github.com/apache/activemq-artemis/pull/2236 ---
[GitHub] activemq-artemis issue #2236: [ARTEMIS-2022] Create count messages 'group by...
Github user ArthurFritz commented on the issue: https://github.com/apache/activemq-artemis/pull/2236 Alter destination feature. ---
[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
GitHub user ArthurFritz opened a pull request: https://github.com/apache/activemq-artemis/pull/2237 [ARTEMIS-2022] Create count messages 'group by' this property filter Create a new function this is responsibility count messages determined property filter, e return one object in json, where properties to object is value of property and this value is amount messages. Actually in the project have only method count messages of determinate filter, but no has method group messages for respective property. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ArthurFritz/activemq-artemis feature/ARTEMIS-2022 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2237.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2237 commit 259f3f8be9014b79503e1ed0ead8c9598f340ff6 Author: Arthur Fritz Santiago Date: 2018-08-10T14:49:16Z [ARTEMIS-2022] Create count messages 'group by' this property filter ---
[GitHub] activemq-artemis issue #2235: Make JDBC OpenFile Thread Safe
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2235 I will push -f without this commit.. it should have had a JIRA ---
[ANNOUNCE] Apache ActiveMQ 5.15.5 Released
Hi everyone, The ActiveMQ team is pleased to announce that Apache ActiveMQ 5.15.5 has been released. A list of issues resolved in this release is available here: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210=12343307 The Wiki page for the release is here: http://activemq.apache.org/activemq-5155-release.html A big thanks to everyone who contributed to this release.
[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2237 This should probably filter using the selectors logic, rather than some seperate logic, so the fiktering expectations are the same. ---
[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2237#discussion_r209312103
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
---
@@ -711,6 +712,32 @@ public long countMessages(final String filterStr)
throws Exception {
}
}
+ @Override
+ public String countMessagesProperty(final String filter) throws
Exception {
--- End diff --
Sould parse this to a filter and then later do message match filter check.
---
Re: OpenWire Version 2 is not the latest version
The openwire generator is executed by the activemq-client project when the " openwire-generate" build profile is enabled and the "antrun:run" goal is executed (according to the comments in the pom): mvn -P openwire-generate antrun:run This runs a complex script that appears to ultimately boil down to the following process: - Scan all java files in the activemq-client src folder - For all of the files that contain the comment "openwire:marshaller": - Generate a class with the same name plus the suffix *Marshaller* - Place the generated class in the packace org.apache.activemq.openwire.v Looking through the code, it appears that all of the sources that feed this process are in the org.apache.activemq.command package. Note this same process is used to generate C++ and C# code - at least, I see references to such. For more details of the process itself, see the activemq-openwire-generator project. JavaGeneratorTask is the main class. Art On Thu, Aug 9, 2018 at 7:40 PM, Andreas Junius wrote: > Thanks Tim. It appears that the code is generated from some groovy > scripts, the javadocs says "NOTE!: This file is auto generated - do > not modify! if you need to make a change, please see the modify the > groovy scripts in the under src/gram/script and then use maven > openwire:generate to regenerate this file." > > I got the source via > https://git-wip-us.apache.org/repos/asf/activemq.git and I can't find > those scripts there. I found older ones here: > https://svn.apache.org/repos/asf/activemq/tags/activemq-4. > 0.2/activemq-core/src/gram/script/ > but this version (4.0.2) seems to be the last one that contains the > groovy scripts. Does anyone know where the actual source of truth is > for the OpenWire protocol code? > > Cheers, > Andreas > > > > >Your best source of documentation on the protocol is the code itself, > >that will be the ultimate source of truth. The latest version if I > >recall correctly is v12. Most of the code for the protocol is in the > >activemq-client module. > > > >-- > >Tim Bish > > > On Thu, Aug 9, 2018 at 1:08 PM, andreas.junius [via ActiveMQ] > wrote: > > Hi, > > > > This page > > http://activemq.apache.org/openwire-version-2-specification.html > > claims that "OpenWire Version 2 is not the latest version". It links > > to another page that shows a table that lists configuration parameters > > but none of the "additional fields in the OpenWire commands" promised > > on the page that linked to it. > > > > My question: what is the latest version of OpenWire and where can I > > find a complete and authoritative specification? > > > > Cheers, > > Andreas > > > > > > > > If you reply to this email, your message will be added to the discussion > > below: > > http://activemq.2283324.n4.nabble.com/OpenWire-Version-2- > is-not-the-latest-version-tp4742252.html > > To unsubscribe from ActiveMQ - Dev, click here. > > NAML >
[GitHub] activemq-artemis issue #2236: [ARTEMIS-2022] Create count messages 'group by...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2236 2.6.x is bug fixes only... this has to go on master. ---
[GitHub] activemq-artemis issue #2236: [ARTEMIS-2022] Create count messages 'group by...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2236 even if it was going on 2.6.x, we first send to master, than cherry-pick into 2.6.x ---
[GitHub] activemq-artemis issue #2235: Make JDBC OpenFile Thread Safe
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2235 will leave it as it is. ---
[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2237#discussion_r209381476
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
---
@@ -711,6 +712,32 @@ public long countMessages(final String filterStr)
throws Exception {
}
}
+ @Override
+ public String countMessagesProperty(final String filter) throws
Exception {
+ checkStarted();
+ clearIO();
+ try {
+ try (LinkedListIterator iterator =
queue.browserIterator()) {
+Map result = new HashMap<>();
--- End diff --
Counter should be long, not integer
---
[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 @michaelandrepearce good point! I will need to modify it because my solution do not create any ByteBuffer at all (or will dispose it immediately with Asyncio) and the test proposed won't work as it is ---
[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 @clebertsuconic I think that using a near-to-deprecation feature to solve the issue can be avoided: https://github.com/franz1981/activemq-artemis/tree/mmap_ro_2_read_journal It is a POC that I need @morefuntang feedback to see if it solves the issue (and it could be applied to ASYNCIO probably) by saving entirely any `ByteBuffer` allocation while reading journal files. ---
[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 @franz1981 , @morefuntang provided a testcase to reproduce the issue, i note on your branch you havent copied the test, to prove your alternative change also would fix the issue. Could i suggest you add the same test case and raise a PR ---
[GitHub] activemq-artemis issue #2232: ARTEMIS-1482 Enhance test to ensure len check ...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2232 Itâs already on 2.6.x ---
[GitHub] activemq-artemis pull request #2235: Make JDBC OpenFile Thread Safe
GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/2235 Make JDBC OpenFile Thread Safe You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemis OpenFileSync Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2235.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2235 commit f92d7213c1c0e8cd5957625228c9e43a5793028a Author: Martyn Taylor Date: 2018-08-01T16:54:35Z Make OpenFile Thread Safe ---
[GitHub] activemq-artemis issue #2232: ARTEMIS-1482 Enhance test to ensure len check ...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2232 So we have no idea of the cause, it is a consumer so we think its a producer where producee maybe on older version. It happend 4 times since monday our app team said ---
[GitHub] activemq-artemis pull request #2235: Make JDBC OpenFile Thread Safe
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2235 ---
[GitHub] activemq-artemis issue #2232: ARTEMIS-1482 Enhance test to ensure len check ...
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2232 @michaelandrepearce How did they do this? It's really only legitimate if the SimpleString is encoded incorrectly? i.e. Set the first 4 bytes as something like Integer.MAX. Other checks such as large message size should catch this earlier in the chain. ---
[GitHub] activemq-artemis issue #2232: ARTEMIS-1482 Enhance test to ensure len check ...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2232 @mtaylor i giggle, its like there are forces out there that just know, literally came into work today, and one of our app teams just experienced this issue this morning... least i know whats the issue :) ---
[GitHub] activemq-artemis issue #2232: ARTEMIS-1482 Enhance test to ensure len check ...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2232 @clebertsuconic can this be ported to the 2.6.x branch? ---
Re: HEADS-UP ActiveMQ Artemis 2.6.3 to be cut Friday the 10th
I will have to postpone to Monday... I have started working on a compatibility issue between 1.5 and 2.x that I want to make sure before we release. Meanwhile: I have cut a master git report, where I added a XREF of commits on 2.6.x this is a current list I just cut of master versus 2.6.x, starting at the mergebase between 2.6.x and master: https://clebertsuconic.github.io/2.6.x-gap.html ^^ This will be helpful to show any missing commits between the two branches. if anyone sees anything missing on 2.6.x let me know please. On Wed, Aug 8, 2018 at 10:45 AM Clebert Suconic wrote: > > I have been cherry-picking everything that makes sense from master into > 2.6.x... > > I want to have a release cut on Friday/10th. I will start cutting it > on Thurstday the 9th afternoon so the vote is sent Friday Morning (US > EST time) > > If you are aware of any blockers for the 2.6.x.. please let me know. > > -- > Clebert Suconic -- Clebert Suconic
