Github user onlyMIT closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2493
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2490
@gemmellr thanks for review, if you could recheck the AMQPSessionCallback
for me, to make sure i understood you.
As for the Openwire test case, this was a simple port
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246135542
--- Diff:
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246135697
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java
AMQP 1.0 with transactional retirement would partly support my requirements but
I still need the keys as I don’t want to load the complete queue. Also,
transactional retirement associates a message outcome (settled/rejected) with a
tx. Since this is built on top of the Core API, there must be
Github user onlyMIT commented on the issue:
https://github.com/apache/activemq-artemis/pull/2493
The test is correct.can close the jira and pull request
---
I agree. Messaging and Database patterns are very different, with
different optimizations and considerations.
That's why folks often hear me repeat a part of a Jeff Genender's
presentation - "don't use ActiveMQ as a message store".
Messaging is about moving messages as quickly as possible
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2491#discussion_r246123082
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java
---
@@ -117,14
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246128551
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpReceiverPriorityTest.java
---
A big thank you to both Jean-Baptiste Onofré and Michael André Pearce for
contributing to this report! Thanks for taking the time to outline some of
the activities on the project guys!
I will submit the report today to the ASF board for next week's meeting.
Bruce
On Sun, Dec 30, 2018 at 7:00 PM
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246128143
--- Diff:
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246127864
--- Diff:
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246132135
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/QueueConsumerPriorityTest.java
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246140041
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpReceiverPriorityTest.java
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246140214
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpReceiverPriorityTest.java
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246135818
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/ConsumerPriorityTest.java
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246140306
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpReceiverPriorityTest.java
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246133832
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/ConsumerPriorityTest.java
---
Perhaps what Andreas is looking is different. Supporting his API
(Streams) on top of the broker, and instead of using internal APIs
using an established API?
The current contract we have on the broker is based on the messages
where you can call message.individualAck or message.ack (The protocol
Hi,
JMS with selectors and tx as well as AMQP with tx association of individual
messages is supported so there must already be some kind of random queue
access. May be it is just not exposed?
Regards
Andreas
> Am 08.01.2019 um 18:22 schrieb Christopher Shannon
> :
>
> Random access queues
Github user onlyMIT commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2491#discussion_r246247094
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java
---
@@ -117,14
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
@qihongxu big thanks for all the effort on this!!
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2492
It is correct that the first commit is related to ARTEMIS-2144?
---
GitHub user CNNJYB opened a pull request:
https://github.com/apache/activemq-artemis/pull/2492
ARTEMIS- why the position remains unchanged if ignored is set to true
I am a bit confused about this, When CursorIterator:next is called during
queue depage, if ignored is set to
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
FYI: we are working to fix the CI machines now so I won't be able ATM to
run any job on it :(
I hope to have the CI machines up and running soon to continue :+1:
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2467#discussion_r245960681
--- Diff:
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2491#discussion_r246075935
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java
---
@@ -117,14
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2491
The test code is correct. The state kept in an unclean session includes the
subscriptions which is why the test doesn't create a subscription before trying
to receive the message. If the
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2493
The test is correct. Creating a subscription before attempting to receive
the message defeats the point of the test as the test is ensuring that the
session is clean (i.e. no previous
Random access queues don't make sense for a message broker and is not
supported. Based on your use case Artemis or any message broker does not
sound like the correct product.
It sounds like you need something like one of the many key/value stores
that exist. (you can search around and see what's
Github user CNNJYB commented on the issue:
https://github.com/apache/activemq-artemis/pull/2492
> This had a specific purpose so we ignore deleted or completed pages, so
we shouldnt be getting the message position.
>
> As per comment in code.
>
> ```
> //
Github user onlyMIT commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2491#discussion_r246095670
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java
---
@@ -117,14
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2467#discussion_r246058995
--- Diff:
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2492
This had a specific purpose so we ignore deleted or completed pages.
As per comment in code.
// any deleted or complete page will be ignored on the
Hi,
we have a sub project that currently runs within SwiftMQ as a plugin and uses
SwiftMQ’s Swiftlet API to communicate with the internal components. I’m
currently evaluating to port it to Artemis where it should run as a broker
plugin. If that is possible with reasonable effort, we intend to
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
@qihongxu @michaelandrepearce
I'm running now a CI job: it will take some time, but when it will be fine
I will merge this :+1:
@qihongxu After all the relevant bits re paging
Github user CNNJYB commented on the issue:
https://github.com/apache/activemq-artemis/pull/2492
> It is correct that the first commit is related to ARTEMIS-2144?
Branch is not latest. Now updated.
---
GitHub user onlyMIT opened a pull request:
https://github.com/apache/activemq-artemis/pull/2493
ARTEMIS-2223 when a new consumer is created, no subscription is called.
In the 'MQTTTest.testCleanSession()' test method, when a new consumer is
created, no subscription is
Github user onlyMIT commented on the issue:
https://github.com/apache/activemq-artemis/pull/2491
@jbertram I think I found out why your solution passed the testï¼ your
test was constructed on a wrong test code. the solution your provided, after I
tested it with the revised test
Github user qihongxu commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> @qihongxu @michaelandrepearce
> I'm running now a CI job: it will take some time, but when it will be
fine I will merge this
> @qihongxu After all the relevant
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245973668
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpReceiverPriorityTest.java
---
@@ -0,0
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245968414
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/ConsumerPriorityTest.java
---
@@ -0,0
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245955337
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
---
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245973707
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpReceiverPriorityTest.java
---
@@ -0,0
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245953999
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
---
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245965929
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java
---
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245972322
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/QueueConsumerPriorityTest.java
---
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245974624
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpReceiverPriorityTest.java
---
@@ -0,0
48 matches
Mail list logo
