[GitHub] asfgit closed pull request #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

2019-01-14 Thread GitBox
asfgit closed pull request #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@activemq.apache.org

[GitHub] clebertsuconic commented on issue #2497: ARTEMIS-2228 Check message size sent over management API

2019-01-14 Thread GitBox
clebertsuconic commented on issue #2497: ARTEMIS-2228 Check message size sent over management API URL: https://github.com/apache/activemq-artemis/pull/2497#issuecomment-454073161 I agree with @michaelandrepearce here.. why not just convert it to large message. I think the

[GitHub] asfgit closed pull request #2484: ARTEMIS-2216 Use a specific executor for pageSyncTimer

2019-01-14 Thread GitBox
asfgit closed pull request #2484: ARTEMIS-2216 Use a specific executor for pageSyncTimer URL: https://github.com/apache/activemq-artemis/pull/2484 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@activemq.apache.org

[GitHub] clebertsuconic commented on a change in pull request #2497: ARTEMIS-2228 Check message size sent over management API

2019-01-14 Thread GitBox
clebertsuconic commented on a change in pull request #2497: ARTEMIS-2228 Check message size sent over management API URL: https://github.com/apache/activemq-artemis/pull/2497#discussion_r247625597 ## File path:

[GitHub] franz1981 commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

2019-01-14 Thread GitBox
franz1981 commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454093850 @qihongxu Both the changes have been merged ie if you want to perform some tests to check if is working as expected

[GitHub] michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

2019-01-14 Thread GitBox
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454180317 @franz1981 added the tests i owed you. Sorry took some time, had the weekend off.

[GitHub] clebertsuconic opened a new pull request #2498: ARTEMIS-2228 Large Messages over Management

2019-01-14 Thread GitBox
clebertsuconic opened a new pull request #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498 This is an automated message from the Apache Git Service. To respond to

[GitHub] clebertsuconic commented on issue #2497: ARTEMIS-2228 Check message size sent over management API

2019-01-14 Thread GitBox
clebertsuconic commented on issue #2497: ARTEMIS-2228 Check message size sent over management API URL: https://github.com/apache/activemq-artemis/pull/2497#issuecomment-454188027 @gaohoward / @michaelandrepearce look into #2498 please? it's a lot simpler there.

[GitHub] clebertsuconic commented on issue #2497: ARTEMIS-2228 Check message size sent over management API

2019-01-14 Thread GitBox
clebertsuconic commented on issue #2497: ARTEMIS-2228 Check message size sent over management API URL: https://github.com/apache/activemq-artemis/pull/2497#issuecomment-454173953 @gaohoward I pulled your branch and fixed it here.

[GitHub] qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

2019-01-14 Thread GitBox
qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454254479 > @qihongxu Both the changes have been merged ie if you want to perform some tests to check if is working as

[GitHub] qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

2019-01-14 Thread GitBox
qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454254479 > @qihongxu Both the changes have been merged ie if you want to perform some tests to check if is working as

[GitHub] gaohoward commented on issue #2497: ARTEMIS-2228 Check message size sent over management API

2019-01-14 Thread GitBox
gaohoward commented on issue #2497: ARTEMIS-2228 Check message size sent over management API URL: https://github.com/apache/activemq-artemis/pull/2497#issuecomment-454248859 @michaelandrepearce @clebertsuconic OK thanks guys, I agree with you. I think #2498 is fine.

[GitHub] qihongxu commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

2019-01-14 Thread GitBox
qihongxu commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454254479 > @qihongxu Both the changes have been merged ie if you want to perform some tests to check if is working as expected

[GitHub] CNNJYB commented on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

2019-01-14 Thread GitBox
CNNJYB commented on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2250#issuecomment-454247122 @franz1981 I mean that it's same with ARTEMIS-1996(SequentialFileFactory may cause

[GitHub] qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

2019-01-14 Thread GitBox
qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454254479 > @qihongxu Both the changes have been merged ie if you want to perform some tests to check if is working as

[GitHub] michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management

2019-01-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498#discussion_r247781204 ## File path:

[GitHub] franz1981 commented on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

2019-01-14 Thread GitBox
franz1981 commented on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2250#issuecomment-454285382 @CNNJYB in this case it is wanted: compaction was leaking buffers big as as the

[GitHub] franz1981 edited a comment on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

2019-01-14 Thread GitBox
franz1981 edited a comment on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2250#issuecomment-454285382 @CNNJYB in this case it is wanted: compaction was leaking buffers big as the

[GitHub] michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management

2019-01-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498#discussion_r247781204 ## File path:

[GitHub] michaelandrepearce commented on issue #2497: ARTEMIS-2228 Check message size sent over management API

2019-01-14 Thread GitBox
michaelandrepearce commented on issue #2497: ARTEMIS-2228 Check message size sent over management API URL: https://github.com/apache/activemq-artemis/pull/2497#issuecomment-453943016 Surely if its large message it should then just convert and be treated as a large message

[GitHub] franz1981 edited a comment on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

2019-01-14 Thread GitBox
franz1981 edited a comment on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2250#issuecomment-453982469 @CNNJYB Paging (write side) is using thread pool provided by file factory,

[GitHub] franz1981 commented on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

2019-01-14 Thread GitBox
franz1981 commented on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2250#issuecomment-453982469 @CNNJYB Paging (write side) is using thread pool provided by file factory, while

[GitHub] CNNJYB commented on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

2019-01-14 Thread GitBox
CNNJYB commented on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2250#issuecomment-453976444 @franz1981 Why not include the same optimizations while reading and writing the page

[GitHub] franz1981 edited a comment on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

2019-01-14 Thread GitBox
franz1981 edited a comment on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2250#issuecomment-453982469 @CNNJYB Paging (write side) is using thread pool provided by file factory,