[GitHub] activemq-artemis pull request #839: ARTEMIS-793 Improvement to OSGi integrat...

2016-10-13 Thread clebertsuconic 
Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/839#discussion_r83347252
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/storage/FileStorageConfiguration.java
 ---
@@ -29,7 +29,7 @@
 
@Override
public StoreType getStoreType() {
-  return StoreType.DATABASE;
--- End diff --

nice catch!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #844: ARTEMIS-799 Fix issues with the AMQP Dur...

2016-10-13 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/844


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #843: ARTEMIS-800: Add + pattern to the MQTT pubsub e...

2016-10-13 Thread atoulme 
Github user atoulme commented on the issue:

https://github.com/apache/activemq-artemis/pull/843
  
Thanks for rerunning the build! The build shows success:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Questions around contribution via pull request

2016-10-13 Thread Antoine Toulme 
Thank you, I will file a JIRA.

> On Oct 13, 2016, at 1:09 PM, Martyn Taylor  wrote:
> 
> Hi Antoine,
> 
> We try to ensure there's a JIRA for each commit (unless it's a trivial
> change), the JIRA number is usually added at the beginning of every commit
> message, you can see the git log for examples of this.
> 
> To get started we have a hacking guide with some information:
> https://activemq.apache.org/artemis/docs/1.4.0/hacking-guide/ 
> 
> 
> The PR looks good, so I'm not sure what's caused the tests to time out,
> this does happens from time to time, I've restarted it.
> 
> Thanks
> Martyn
> 
> 
> 
> 
> 
> 
> 
> On Thu, Oct 13, 2016 at 6:50 PM, Antoine Toulme  >
> wrote:
> 
>> Pardon me as this is my first attempted contribution to the project.
>> 
>> I am trying to contribute a small change to the example showing pub/sub
>> with MQTT.
>> 
>> I would like to know more about the contribution process and if I broke
>> any rules.
>> 
>> I also saw that the jenkins build testing my change timed out. Is that
>> expected? Should I rerun the test?
>> 
>> Finally, would you like me to file a jira for this? How do I go about that?
>> 
>> Any help is very welcome. I can also meet via IRC or hangout to speed
>> things up.
>> 
>> Here is the pull request:
>> https://github.com/apache/activemq-artemis/pull/843 <
>> https://github.com/apache/activemq-artemis/pull/843 
>> >
>> 
>> Cheers,
>> 
>> Antoine

[GitHub] activemq-artemis pull request #837: ARTEMIS-792 Add additional tests for AMQ...

2016-10-13 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/837


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Questions around contribution via pull request

2016-10-13 Thread Martyn Taylor 
Hi Antoine,

We try to ensure there's a JIRA for each commit (unless it's a trivial
change), the JIRA number is usually added at the beginning of every commit
message, you can see the git log for examples of this.

To get started we have a hacking guide with some information:
https://activemq.apache.org/artemis/docs/1.4.0/hacking-guide/

The PR looks good, so I'm not sure what's caused the tests to time out,
this does happens from time to time, I've restarted it.

Thanks
Martyn







On Thu, Oct 13, 2016 at 6:50 PM, Antoine Toulme 
wrote:

> Pardon me as this is my first attempted contribution to the project.
>
> I am trying to contribute a small change to the example showing pub/sub
> with MQTT.
>
> I would like to know more about the contribution process and if I broke
> any rules.
>
> I also saw that the jenkins build testing my change timed out. Is that
> expected? Should I rerun the test?
>
> Finally, would you like me to file a jira for this? How do I go about that?
>
> Any help is very welcome. I can also meet via IRC or hangout to speed
> things up.
>
> Here is the pull request:
> https://github.com/apache/activemq-artemis/pull/843 <
> https://github.com/apache/activemq-artemis/pull/843>
>
> Cheers,
>
> Antoine
>
>
>

Questions around contribution via pull request

2016-10-13 Thread Antoine Toulme 
Pardon me as this is my first attempted contribution to the project.

I am trying to contribute a small change to the example showing pub/sub with 
MQTT.

I would like to know more about the contribution process and if I broke any 
rules.

I also saw that the jenkins build testing my change timed out. Is that 
expected? Should I rerun the test?

Finally, would you like me to file a jira for this? How do I go about that?

Any help is very welcome. I can also meet via IRC or hangout to speed things up.

Here is the pull request:
https://github.com/apache/activemq-artemis/pull/843 


Cheers,

Antoine

[GitHub] activemq-artemis issue #843: Example showing how to use + in topics

2016-10-13 Thread atoulme 
Github user atoulme commented on the issue:

https://github.com/apache/activemq-artemis/pull/843
  
The check was aborted. I will reach out to the Apache ActiveMQ maintainers 
on the mailing list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #844: ARTEMIS-799 Fix issues with the AMQP Dur...

2016-10-13 Thread tabish121 
GitHub user tabish121 opened a pull request:

https://github.com/apache/activemq-artemis/pull/844

ARTEMIS-799 Fix issues with the AMQP Durable Topic Subscription model

Fixes several issues found in the handling of durable topic
subscriptions (test cases added).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-799

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/844.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #844


commit 1f8e2ed5b0bdaf40a76e45b544ce7156c025d7c9
Author: Timothy Bish 
Date:   2016-10-12T21:33:08Z

ARTEMIS-799 Fix issues with the AMQP Durable Topic Subscription model

Fixes several issues found in the handling of durable topic
subscriptions (test cases added).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #842: NPE fixes

2016-10-13 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/842


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #839: ARTEMIS-793 Improvement to OSGi integrat...

2016-10-13 Thread clebertsuconic 
Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/839#discussion_r83230546
  
--- Diff: 
artemis-server-osgi/src/main/java/org/apache/activemq/artemis/osgi/OsgiBroker.java
 ---
@@ -1,223 +1,252 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.activemq.artemis.osgi;
-
-import java.io.File;
-import java.lang.management.ManagementFactory;
-import java.util.ArrayList;
-import java.util.Dictionary;
-import java.util.Enumeration;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.Hashtable;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
-
-import org.apache.activemq.artemis.api.core.Interceptor;
-import org.apache.activemq.artemis.api.core.TransportConfiguration;
-import org.apache.activemq.artemis.core.config.FileDeploymentManager;
-import org.apache.activemq.artemis.core.config.impl.FileConfiguration;
-import 
org.apache.activemq.artemis.core.remoting.impl.netty.TransportConstants;
-import org.apache.activemq.artemis.core.server.ActiveMQComponent;
-import org.apache.activemq.artemis.core.server.ActiveMQServer;
-import 
org.apache.activemq.artemis.jms.server.config.impl.FileJMSConfiguration;
-import 
org.apache.activemq.artemis.spi.core.protocol.ProtocolManagerFactory;
-import 
org.apache.activemq.artemis.spi.core.security.ActiveMQJAASSecurityManager;
-import org.osgi.framework.BundleContext;
-import org.osgi.framework.ServiceRegistration;
-import org.osgi.service.component.ComponentContext;
-import org.osgi.service.component.annotations.Activate;
-import org.osgi.service.component.annotations.Component;
-import org.osgi.service.component.annotations.ConfigurationPolicy;
-import org.osgi.service.component.annotations.Deactivate;
-import org.osgi.util.tracker.ServiceTracker;
-
-@SuppressWarnings({"unchecked", "rawtypes"})
-@Component(configurationPid = "org.apache.activemq.artemis", 
configurationPolicy = ConfigurationPolicy.REQUIRE)
-public class OsgiBroker {
-
-   private String name;
-   private String configurationUrl;
-   private String rolePrincipalClass;
-   private Map components;
-   private Map registrations;
-   private ServiceTracker tracker;
-
-   @Activate
-   public void activate(ComponentContext cctx) throws Exception {
-  final BundleContext context = cctx.getBundleContext();
-  final Dictionary properties = cctx.getProperties();
-  configurationUrl = getMandatory(properties, "config");
-  name = getMandatory(properties, "name");
-  rolePrincipalClass = (String) properties.get("rolePrincipalClass");
-  String domain = getMandatory(properties, "domain");
-  ActiveMQJAASSecurityManager security = new 
ActiveMQJAASSecurityManager(domain);
-  if (rolePrincipalClass != null) {
- security.setRolePrincipalClass(rolePrincipalClass);
-  }
-  String brokerInstance = null;
-  String karafDataDir = System.getProperty("karaf.data");
-  if (karafDataDir != null) {
- brokerInstance = karafDataDir + "/artemis/" + name;
-  }
-
-  // todo if we start to pullout more configs from the main config 
then we
-  // should pull out the configuration objects from factories if 
available
-  FileConfiguration configuration = new FileConfiguration();
-  if (brokerInstance != null) {
- configuration.setBrokerInstance(new File(brokerInstance));
-  }
-  FileJMSConfiguration jmsConfiguration = new FileJMSConfiguration();
-
-  FileDeploymentManager fileDeploymentManager = new 
FileDeploymentManager(configurationUrl);
-  
fileDeploymentManager.addDeployable(configuration).addDeployable(jmsConfiguration).readConfiguration();
-
-  components = fileDeploymentManager.buildService(security,