[GitHub] activemq-artemis pull request #1451: a few fixes

[clebertsuconic]

GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/1451

a few fixes



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis 
scheduled-component

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1451.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1451


commit f293ff522961e3cf71600e79a89c8421db49d49b
Author: Clebert Suconic 
Date:   2017-08-09T00:30:39Z

ARTEMIS-1308 Removing start/endcall around commit

this issue many warning around the testsuite around MessageListeners
it's valid to call the commit from a different thread on this case.

commit 4e6033ea21ea98aadacb9b7d241dc2c8af0a64a8
Author: Clebert Suconic 
Date:   2017-08-08T20:00:01Z

ARTEMIS-1334 Scheduled component shouldn't be synchronized

commit af8246d739cd996e43a42dbfd3d3cdde89b1fa89
Author: Clebert Suconic 
Date:   2017-08-09T00:38:26Z

NO-JIRA Adding large message failover test around duplicates

commit 8933b0060351ec00242920885f6b189ea96e4de7
Author: Clebert Suconic 
Date:   2017-08-09T02:39:20Z

ARTEMIS-1333 SendACK listener message loss (adding test)

next commit should have the fix.
this is to make it easy to confirm the fix by people looking.

commit 9e1721e2a0b257af10047fca4b7915be74e664e0
Author: Clebert Suconic 
Date:   2017-08-09T02:48:25Z

ARTEMIS-1333 SendACK listener fix

commit 75abedf928941b4a46ee986a12180d11d7ba8a8a
Author: Clebert Suconic 
Date:   2017-08-09T02:55:11Z

Revert "NO-JIRA Adding large message failover test around duplicates"

This reverts commit af8246d739cd996e43a42dbfd3d3cdde89b1fa89.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1447: ARTEMIS-1328 Improving direct delivery check

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1447
  
@clebertsuconic only query i have 

was why this change?
-   public static final int CHECK_QUEUE_SIZE_PERIOD = 100;
+   public static final int CHECK_QUEUE_SIZE_PERIOD = 1000;



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1448: ARTEMIS-1328 Improving direct delivery ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1448


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1447: ARTEMIS-1328 Improving direct delivery ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1447


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1441: NO-JIRA Updates to management.md doc [WIP]

[jdanekrh]

Github user jdanekrh commented on the issue:

https://github.com/apache/activemq-artemis/pull/1441
  
Sorry, have missed your yesterday's comment. Unless nobody is taking issue 
with it, then yes. I can do Web Console related doc update in new PR later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1441: NO-JIRA Updates to management.md doc [W...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1441


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1450: ARTEMIS-1332 - Always return a response to the...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1450
  
@cshannon ahaaa!!! thanks a lot... you just saved me a task ! 👍 
Someone reported me an issue at Red Hat.. I think this is the cause.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1449: [ARTEMIS-1310] SASL GSSAPI support

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1449


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1449
  
@gtully I will update proton and qpid-jms on a different commit
and rebase this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1449
  
@tabish121 Oh.. I see


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1450: ARTEMIS-1332 - Always return a response...

[cshannon]

GitHub user cshannon opened a pull request:

https://github.com/apache/activemq-artemis/pull/1450

ARTEMIS-1332 - Always return a response to the client on session

metadata add

This will make sure that if there is an ActiveMQException thrown the
client will get notified and not hang.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1332

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1450.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1450


commit 2cd3d5948675ccb550a87067bffbf74f1169043d
Author: Christopher L. Shannon (cshannon) 
Date:   2017-08-08T17:09:03Z

ARTEMIS-1332 - Always return a response to the client on session
metadata add

This will make sure that if there is an ActiveMQException thrown the
client will get notified and not hang.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1447: ARTEMIS-1328 Improving direct delivery check

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1447
  
this is now ready...

@michaelandrepearce since you've looked.. mind looking again?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support

[tabish121]

Github user tabish121 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1449
  
It looks to me like the third commit updates to the released bits.  Maybe 
squash the commits?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1449
  
@gtully if they are in maven central, can't we just use the released bits 
then?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support

[gtully]

Github user gtully commented on the issue:

https://github.com/apache/activemq-artemis/pull/1449
  
The new proton-j and qpid-jms deps are in maven central. 
W.r.t to the tests check failing, some unrelated permissions issue with 
temp dir creation seems to be the root cause of them all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1447: ARTEMIS-1328 Improving direct delivery check

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1447
  
Please.. don't merge this.. I'm changing this around.. will send another 
message when it's ok.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1449
  
@gtully  Impressive work here! 👍 🥇 

just a question... qpid-jms has been already issued a vote.. it should be 
passed by tomorrow. wouldn't be worth to merge this tomorrow after it's 
released?

I had already issued a heads-up on the dev list, we could release this as 
soon as that is released.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1449: [ARTEMIS-1310] SASL GSSAPI support

[gtully]

GitHub user gtully opened a pull request:

https://github.com/apache/activemq-artemis/pull/1449

[ARTEMIS-1310] SASL GSSAPI support

update to proton-j 0.20.0 and qpid-jms 0.24.0

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gtully/activemq-artemis sasl-gssapi

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1449.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1449


commit d4a281ed049acfa11b489ed43a06ba57669d7588
Author: gtully 
Date:   2017-07-28T15:02:32Z

[ARTEMIS-1310] add amqp sasl gssapi mechanism support

delegate to the jdk saslServer. Allow acceptor configuration of supported 
mechanismis; saslMechanisms=
and allow login config scope for krb5 to be configured via 
saslLoginConfigScope=x

commit 1496b8c463eec9fbe385a8c9e4be7e9141018454
Author: gtully 
Date:   2017-08-02T11:19:07Z

[ARTEMIS-1310] [ARTEMIS-1264] consolidate configuration to require login 
configuration scope

commit b551f9ea978eaf0607cd7b8c1567cc13d06031c8
Author: gtully 
Date:   2017-08-02T14:05:50Z

[ARTEMIS-1310] require mechanism to be explicitly enabled




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1428: ARTEMIS-1308: Make acknowlegde in AcitveMQMess...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1428
  
nice job on this one... no regressions whatsoever.. I even ran some outer 
tests on this.. compatibility kit and other stuff.. nice job!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1428: ARTEMIS-1308: Make acknowlegde in Acitv...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1428


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1447: ARTEMIS-1328 Improving direct delivery ...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1447#discussion_r131907760
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ---
@@ -664,7 +664,7 @@ public void addTail(final MessageReference ref, final 
boolean direct) {
if (intermediateMessageReferences.isEmpty() && 
messageReferences.isEmpty() && !pageIterator.hasNext() && 
!pageSubscription.isPaging()) {
   // We must block on the executor to ensure any async 
deliveries have completed or we might get out of order
   // deliveries
-  if (flushExecutor() && flushDeliveriesInTransit()) {
+  if (internalFlushExecutor(500, false) && 
flushDeliveriesInTransit()) {
--- End diff --

I will change this to no wait at all. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1445: ARTEMIS-1327 - Support checked exceptions in A...

[cshannon]

Github user cshannon commented on the issue:

https://github.com/apache/activemq-artemis/pull/1445
  
@clebertsuconic - This looks good to me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1447: ARTEMIS-1328 Improving direct delivery ...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1447#discussion_r131832623
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ---
@@ -664,7 +664,7 @@ public void addTail(final MessageReference ref, final 
boolean direct) {
if (intermediateMessageReferences.isEmpty() && 
messageReferences.isEmpty() && !pageIterator.hasNext() && 
!pageSubscription.isPaging()) {
   // We must block on the executor to ensure any async 
deliveries have completed or we might get out of order
   // deliveries
-  if (flushExecutor() && flushDeliveriesInTransit()) {
+  if (internalFlushExecutor(500, false) && 
flushDeliveriesInTransit()) {
--- End diff --

Why 500 why not 100, if the issue was previously it was taking too long 
surely we want this as small as safely possible?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---