[GitHub] activemq-artemis issue #1913: ARTEMIS-1715 Disable to remove a divert from h...

2018-03-06 Thread stanlyDoge
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1913 @clebertsuconic Done ---

Fwd: ActiveMq Artemis crashes when large amqp messages need are delivered

2018-03-06 Thread Michael André Pearce
@ClebertCould this be a blocker for release?Just sending it to the dev mail list incase it got missed in the users.Begin forwarded message:From: andi welchlin Date: 6 March 2018 at 09:08:39 GMTTo: us...@activemq.apache.orgSubject: ActiveMq Artemis crashes when large amqp me

Re: [HEADS-UP] 2.5.0 release some time next week... (after wed)

2018-03-06 Thread Michael André Pearce
@Clebert Someone in the user threads has raised what looks like a blocker if it’s real. Something to do with large messages and broker crashing with 2.5.0-SNAPSHOTz Have you seen it? Sent from my iPhone > On 2 Mar 2018, at 23:42, Clebert Suconic wrote: > > If you have anything in mind that

[GitHub] activemq-artemis issue #1913: ARTEMIS-1715 Disable to remove a divert from h...

2018-03-06 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1913 @michaelandrepearce is this good to merge? (the PR check failure is probably not related). @stanlyDoge if you could please rebase to have a re-run? ---

Re: [DISCUSS] Artemis Docker Image

2018-03-06 Thread Clebert Suconic
It would be nice to have a direction from Apache Foundation on Containers. I will reach to infra tomorrow or the day after (since I planned to do an Artemis release tomorrow) @Victor: It would be nice to make your work official here... would appreciate any help if we can move this forward. On Mo

[GitHub] activemq-artemis pull request #1822: ARTEMIS-1653 Allow database tables to b...

2018-03-06 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1822#discussion_r172699944 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -109,7 +109,7 @@

[GitHub] activemq-artemis issue #1822: ARTEMIS-1653 Allow database tables to be creat...

2018-03-06 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1822 @franz1981 ok to merge this? ---

[GitHub] activemq-artemis pull request #1866: ARTEMIS-1660: Remove oracle12 autoincre...

2018-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1866 ---

[GitHub] activemq-artemis pull request #1857: ARTEMIS-1669 JMS message is not receive...

2018-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1857 ---

[GitHub] activemq-artemis pull request #1935: ARTEMIS-1198 add listAllSessionsAsJSON ...

2018-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1935 ---

[GitHub] activemq-artemis pull request #1928: ARTEMIS-1722 Don't copy message bytes u...

2018-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1928 ---

[GitHub] activemq-artemis pull request #1935: ARTEMIS-1198 add listAllSessionsAsJSON ...

2018-03-06 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1935 ARTEMIS-1198 add listAllSessionsAsJSON mgmnt method You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMI

[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...

2018-03-06 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1928 @tabish121 I'm actually running tests... leave it with me ---

[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...

2018-03-06 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1928 Need @clebertsuconic to give it a look ---

[GitHub] activemq-artemis issue #1919: ARTEMIS-1723 Migrate AMQP C# examples to the c...

2018-03-06 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1919 I ran the PR build locally and it passed. Previous failures were spurious and not related to the PR. ---

[GitHub] activemq-artemis pull request #1934: Couple of small fixes

2018-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1934 ---

[GitHub] activemq-artemis pull request #1919: ARTEMIS-1723 Migrate AMQP C# examples t...

2018-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1919 ---

[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...

2018-03-06 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1928 If we want this in 2.5 I think we should merge it today. ---

[GitHub] activemq-artemis pull request #1933: ARTEMIS-1731 Support offline validation

2018-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1933 ---

[GitHub] activemq-artemis issue #1933: ARTEMIS-1731 Support offline validation

2018-03-06 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1933 @jbertram I see.. nice it was caught before the release... I'm merging it... @obfischer if you have a better way and still solve this issue.. I'm open for it

[GitHub] activemq-artemis issue #1933: ARTEMIS-1731 Support offline validation

2018-03-06 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1933 From the [JIRA](https://issues.apache.org/jira/browse/ARTEMIS-1731), "...starting Artemis fails when the server running broker has no Internet access." ---

[GitHub] activemq-artemis pull request #1934: NO-JIRA ignore exception when deleting ...

2018-03-06 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1934 NO-JIRA ignore exception when deleting temp queue You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_w

[GitHub] activemq-artemis issue #1933: ARTEMIS-1731 Support offline validation

2018-03-06 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1933 @michaelandrepearce I thought the right way to do this was through using the actual HTTP location. and have tools to cache it somehow. In what scenario this is failing? on d

[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...

2018-03-06 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1928 @franz1981 I've updated this PR with changes to the common path based on your suggestions to me over on my fork. Thanks for the review and ideas, even better now. ---

[GitHub] activemq-artemis pull request #1929: ARTEMIS-1728 Reclaim memory when page c...

2018-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1929 ---

[GitHub] activemq-artemis issue #1933: ARTEMIS-1731 Support offline validation

2018-03-06 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1933 Please feel free to submit and alternative approach ---

[GitHub] activemq-artemis issue #1933: ARTEMIS-1731 Support offline validation

2018-03-06 Thread obfischer
Github user obfischer commented on the issue: https://github.com/apache/activemq-artemis/pull/1933 I wouldn't change the `schemaLocation` directly as it is actual a bad practice. Dependending on the XML processor catalog files should be used. In most cases the API of the XML processor

[GitHub] activemq-artemis pull request #1933: ARTEMIS-1731 Support offline validation

2018-03-06 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/1933 ARTEMIS-1731 Support offline validation Copy in https://www.w3.org/2005/08/xml.xsd so validation of broker.xml works offline. You can merge this pull request into a Git reposi

[GitHub] activemq-artemis pull request #1931: ARTEMIS-1719 fix threadleakrule after N...

2018-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1931 ---

[GitHub] activemq-artemis pull request #1932: ARTEMIS-1661 Support offline validation

2018-03-06 Thread michaelandrepearce
Github user michaelandrepearce closed the pull request at: https://github.com/apache/activemq-artemis/pull/1932 ---

[GitHub] activemq-artemis pull request #1932: ARTEMIS-1661 Support offline validation

2018-03-06 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/1932 ARTEMIS-1661 Support offline validation Copy in https://www.w3.org/2005/08/xml.xsd so validation of broker.xml works offline. You can merge this pull request into a Git reposi

[GitHub] activemq-artemis issue #1918: ARTEMIS-1722 Reduce pooled Netty ByteBuf usage

2018-03-06 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1918 I'm closing this one and helping @tabish121 to validate https://github.com/apache/activemq-artemis/pull/1928, that is 100% the best approach, because it avoid completly the copy in the c

[GitHub] activemq-artemis pull request #1918: ARTEMIS-1722 Reduce pooled Netty ByteBu...

2018-03-06 Thread franz1981
Github user franz1981 closed the pull request at: https://github.com/apache/activemq-artemis/pull/1918 ---

[GitHub] activemq-artemis pull request #1913: ARTEMIS-1715 Disable to remove a divert...

2018-03-06 Thread stanlyDoge
Github user stanlyDoge commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1913#discussion_r172447340 --- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js --- @@ -96,6 +96,9 @@ var ARTEMIS = (function(ARTEMIS) {

[GitHub] activemq-artemis pull request #1913: ARTEMIS-1715 Disable to remove a divert...

2018-03-06 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1913#discussion_r172446748 --- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js --- @@ -96,6 +96,9 @@ var ARTEMIS = (function(ARTEMI

[GitHub] activemq-artemis pull request #1913: ARTEMIS-1715 Disable to remove a divert...

2018-03-06 Thread stanlyDoge
Github user stanlyDoge commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1913#discussion_r172446094 --- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js --- @@ -96,6 +96,9 @@ var ARTEMIS = (function(ARTEMIS) {