[GitHub] activemq-artemis issue #1913: ARTEMIS-1715 Disable to remove a divert from h...

[stanlyDoge]

Github user stanlyDoge commented on the issue:

https://github.com/apache/activemq-artemis/pull/1913
  
@clebertsuconic Done


---

Fwd: ActiveMq Artemis crashes when large amqp messages need are delivered

[Michael André Pearce]

@ClebertCould this be a blocker for release?Just sending it to the dev mail list incase it got missed in the users.Begin forwarded message:From: andi welchlin Date: 6 March 2018 at 09:08:39 GMTTo: us...@activemq.apache.orgSubject: ActiveMq Artemis crashes when large amqp messages need are deliveredReply-To: us...@activemq.apache.orgHello,I tested Artemis as a stanalone broker (the current snapshot 2.5.0).One program sent a 100MB amqp message to a queue in the broker. This could be done.But while the message was delivered to a subscriber Artemis crashed.The queue was defined like this:        awe.test.queue  true      And I set global size to 1000 MB:  1000MbWhen I restarted the broker and connected the subscriber it crashed, again.Since the log output is large I attached a file to this mail. The end of the output looks like this:    at java.lang.Object.wait(Native Method)    -  waiting on java.lang.ref.ReferenceQueue$Lock@773bc0c1    at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:143)    at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:164)    at java.lang.ref.Finalizer$FinalizerThread.run(Finalizer.java:209)"Reference Handler" Id=2 WAITING on java.lang.ref.Reference$Lock@3e627566    at java.lang.Object.wait(Native Method)    -  waiting on java.lang.ref.Reference$Lock@3e627566    at java.lang.Object.wait(Object.java:502)    at java.lang.ref.Reference.tryHandlePending(Reference.java:191)    at java.lang.ref.Reference$ReferenceHandler.run(Reference.java:153)===End Thread dump ***I tested the same setup with a QPID C++ broker. It had no problems even with much larger messages.Kind Regards,Andreas
2018-03-06 09:48:44,990 INFO  [org.apache.activemq.artemis.core.server] 
AMQ221007: Server is now live
2018-03-06 09:48:44,991 INFO  [org.apache.activemq.artemis.core.server] 
AMQ221001: Apache ActiveMQ Artemis Message Broker version 2.5.0-SNAPSHOT 
[0.0.0.0, nodeID=0d3faab0-211b-11e8-89f1-080027683f03] 
2018-03-06 09:48:45,298 INFO  
[org.apache.activemq.hawtio.branding.PluginContextListener] Initialized 
activemq-branding plugin
2018-03-06 09:48:45,414 INFO  
[org.apache.activemq.hawtio.plugin.PluginContextListener] Initialized 
artemis-plugin plugin
2018-03-06 09:48:45,922 INFO  [io.hawt.HawtioContextListener] Initialising 
hawtio services
2018-03-06 09:48:45,947 INFO  [io.hawt.system.ConfigManager] Configuration will 
be discovered via system properties
2018-03-06 09:48:45,952 INFO  [io.hawt.jmx.JmxTreeWatcher] Welcome to hawtio 
1.5.5 : http://hawt.io/ : Don't cha wish your console was hawt like me? ;-)
2018-03-06 09:48:45,958 INFO  [io.hawt.jmx.UploadManager] Using file upload 
directory: /home/andreas/brokers/artemis/broker-config-new-25/tmp/uploads
2018-03-06 09:48:46,003 INFO  [io.hawt.web.AuthenticationFilter] Starting 
hawtio authentication filter, JAAS realm: "activemq" authorized role(s): "amq" 
role principal classes: 
"org.apache.activemq.artemis.spi.core.security.jaas.RolePrincipal"
2018-03-06 09:48:46,058 INFO  [io.hawt.web.JolokiaConfiguredAgentServlet] 
Jolokia overridden property: [key=policyLocation, 
value=file:/home/andreas/brokers/artemis/broker-config-new-25/etc/jolokia-access.xml]
2018-03-06 09:48:46,107 INFO  [io.hawt.web.RBACMBeanInvoker] Using MBean 
[hawtio:type=security,area=jmx,rank=0,name=HawtioDummyJMXSecurity] for role 
based access control
2018-03-06 09:48:46,343 INFO  [io.hawt.system.ProxyWhitelist] Initial proxy 
whitelist: [localhost, 127.0.0.1, 10.0.2.15, 10.43.4.239, 
andreas-VirtualBox.dev.quo]
2018-03-06 09:48:46,667 INFO  [org.apache.activemq.artemis] AMQ241001: HTTP 
Server started at http://localhost:8161
2018-03-06 09:48:46,667 INFO  [org.apache.activemq.artemis] AMQ241002: Artemis 
Jolokia REST API available at http://localhost:8161/console/jolokia
2018-03-06 09:48:46,667 INFO  [org.apache.activemq.artemis] AMQ241004: Artemis 
Console available at http://localhost:8161/console
2018-03-06 09:50:57,635 WARN  [org.apache.activemq.artemis.core.server] 
AMQ222061: Client connection failed, clearing up resources for session 
6c34e6ea-211b-11e8-a083-080027683f03
2018-03-06 09:50:57,642 WARN  [org.apache.activemq.artemis.core.server] 
AMQ222107: Cleared up resources for session 6c34e6ea-211b-11e8-a083-080027683f03
2018-03-06 09:53:44,074 ERROR [org.apache.activemq.artemis.core.server] 
AMQ224079: The process for the virtual machine will be killed, as component 
QueueImpl[name=test.awe.queue, postOffice=PostOfficeImpl 
[server=ActiveMQServerImpl::serverUUID=0d3faab0-211b-11e8-89f1-080027683f03], 
temp=false]@2f7c18fd is not responsive
2018-03-06 09:53:44,219 WARN  [org.apache.activemq.artemis.core.server] 
AMQ222199: Thread dump: 
***

Re: [HEADS-UP] 2.5.0 release some time next week... (after wed)

[Michael André Pearce]

@Clebert

Someone in the user threads has raised what looks like a blocker if it’s real. 

Something to do with large messages and broker crashing with 2.5.0-SNAPSHOTz

Have you seen it?

Sent from my iPhone

> On 2 Mar 2018, at 23:42, Clebert Suconic  wrote:
> 
> If you have anything in mind that you consider a blocking.
> 
> That’s the idea of the heads up.  My expectation was the examples.  But if
> you want to request another change, like be PR pending you have that I need
> to work on ? :)
> 
> 
> Let me know if you have anything in mind that is a blocker.
> 
> On Fri, Mar 2, 2018 at 12:46 AM MichaelAndrePearce <
> michael.andre.pea...@me.com> wrote:
> 
>> yes a list of blocking tasks, so that we can all focus on those if needed.
>> It
>> sounded like there were a few examples, but it seems like you have that in
>> hand already.
>> 
>> 
>> 
>> --
>> Sent from:
>> http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
>> 
> -- 
> Clebert Suconic

[GitHub] activemq-artemis issue #1913: ARTEMIS-1715 Disable to remove a divert from h...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1913
  
@michaelandrepearce is this good to merge? (the PR check failure is 
probably not related).

@stanlyDoge if you could please rebase to have a re-run?


---

Re: [DISCUSS] Artemis Docker Image

[Clebert Suconic]

It would be nice to have a direction from Apache Foundation on Containers.

I will reach to infra tomorrow or the day after (since I planned to do
an Artemis release tomorrow)

@Victor: It would be nice to make your work official here... would
appreciate any help if we can move this forward.

On Mon, Mar 5, 2018 at 2:17 AM, Victor  wrote:
> I have been maintaining a docker image for quite a while:
> https://hub.docker.com/r/vromero/activemq-artemis/ (> 100k pulls)
> It does work, its fairly configurable, supports Ubuntu and Alpine (big deal
> for the docker community) and I'm happy to make changes if anyone feels
> there is area for improvement.
>
> This said, we kinda already had this discussion, see thread I started back
> in 11/7/16: *Contributing to the Apache Docker Account*.
> But things were rather confusing regarding that Apache docker account back
> then.
>
> I was mostly talking to John D. Ament, that seemed pretty knowledgeable
> about the account and about what was expected.
> John if you are reading, perhaps you could let us know how things are right
> now in that regard?
>
>
>
> 2018-03-01 11:20 GMT-08:00 Clebert Suconic :
>
>> On Thu, Mar 1, 2018 at 12:08 PM, Arthur Naseef  wrote:
>> > I know how to create a docker image, and do so with a maven build.
>> >
>> > And getting an image into a registry isn't too hard.  That's the "docker
>> > push" command.  I suspect the docker-maven-plugin may be able to do that
>> as
>> > part of a build.
>> >
>> > The part I don't know is how it can be published to a central docker
>> > registry.  May be as simple as setting up an account on the central
>> server.
>>
>>
>> Yes.. that's the thing I'm wondering. I was wondering if there was an
>> apache account we could use. or if we would need to create an account
>> for activemq.
>>
>> >
>> > As for making it part of the release - I think it would be great to have
>> a
>> > public docker image updated on every release.  However, I wouldn't want
>> to
>> > make it part of the main Artemis build (i.e. "mvn clean install" from the
>> > activemq-artemis.git root) since the main deliverable from Apache
>> projects
>> > is the source, and requiring everyone who builds Artemis to have docker
>> and
>> > build the image seems like overkill.
>>
>>
>> That's what I expected. I was just wondering if there was an apache
>> precedent on that. Docker becomes a binary distribution on that sense.
>>



-- 
Clebert Suconic

[GitHub] activemq-artemis pull request #1822: ARTEMIS-1653 Allow database tables to b...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1822#discussion_r172699944
  
--- Diff: 
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
 ---
@@ -109,7 +109,7 @@ public void stop() throws SQLException {
protected abstract void createSchema() throws SQLException;
 
protected final void createTable(String... schemaSqls) throws 
SQLException {
-  createTableIfNotExists(connection, sqlProvider.getTableName(), 
schemaSqls);
+  createTableIfNotExists(sqlProvider.getTableName(), schemaSqls);
--- End diff --

easier to ask than reading the code :)


Why removing this parameter here?


(sorry if I'm lazy.. I have a bunch of other PRs to check.. so it was 
easier to ask).


---

[GitHub] activemq-artemis issue #1822: ARTEMIS-1653 Allow database tables to be creat...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1822
  
@franz1981 ok to merge this?


---

[GitHub] activemq-artemis pull request #1866: ARTEMIS-1660: Remove oracle12 autoincre...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1866


---

[GitHub] activemq-artemis pull request #1857: ARTEMIS-1669 JMS message is not receive...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1857


---

[GitHub] activemq-artemis pull request #1935: ARTEMIS-1198 add listAllSessionsAsJSON ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1935


---

[GitHub] activemq-artemis pull request #1928: ARTEMIS-1722 Don't copy message bytes u...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1928


---

[GitHub] activemq-artemis pull request #1935: ARTEMIS-1198 add listAllSessionsAsJSON ...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1935

ARTEMIS-1198 add listAllSessionsAsJSON mgmnt method



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1198

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1935.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1935


commit 868bb5e2adc655db73513e9408ef012031cfc84d
Author: Justin Bertram 
Date:   2018-03-06T20:17:42Z

ARTEMIS-1198 add listAllSessionsAsJSON mgmnt method




---

[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1928
  
@tabish121 I'm actually running tests... leave it with me


---

[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...

[tabish121]

Github user tabish121 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1928
  
Need @clebertsuconic to give it a look 


---

[GitHub] activemq-artemis issue #1919: ARTEMIS-1723 Migrate AMQP C# examples to the c...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1919
  
I ran the PR build locally and it passed. Previous failures were spurious 
and not related to the PR.


---

[GitHub] activemq-artemis pull request #1934: Couple of small fixes

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1934


---

[GitHub] activemq-artemis pull request #1919: ARTEMIS-1723 Migrate AMQP C# examples t...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1919


---

[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1928
  
If we want this in 2.5 I think we should merge it today.


---

[GitHub] activemq-artemis pull request #1933: ARTEMIS-1731 Support offline validation

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1933


---

[GitHub] activemq-artemis issue #1933: ARTEMIS-1731 Support offline validation

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1933
  
@jbertram  I see.. nice it was caught before the release...


I'm merging it...

@obfischer  if you have a better way and still solve this issue.. I'm open 
for it.


---

[GitHub] activemq-artemis issue #1933: ARTEMIS-1731 Support offline validation

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1933
  
From the [JIRA](https://issues.apache.org/jira/browse/ARTEMIS-1731), 
"...starting Artemis fails when the server running broker has no Internet 
access."


---

[GitHub] activemq-artemis pull request #1934: NO-JIRA ignore exception when deleting ...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1934

NO-JIRA ignore exception when deleting temp queue



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis master_work

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1934.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1934


commit f81609c14998b86a450ccd64ebaf8e4e77024772
Author: Justin Bertram 
Date:   2018-03-06T17:29:24Z

NO-JIRA ignore exception when deleting temp queue




---

[GitHub] activemq-artemis issue #1933: ARTEMIS-1731 Support offline validation

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1933
  
@michaelandrepearce I thought the right way to do this was through using 
the actual HTTP location. and have tools to cache it somehow.

In what scenario this is failing? on deploy on master, when running behing 
a firewal? or when using an external tool for this?


---

[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...

[tabish121]

Github user tabish121 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1928
  
@franz1981 I've updated this PR with changes to the common path based on 
your suggestions to me over on my fork.  Thanks for the review and ideas, even 
better now.  


---

[GitHub] activemq-artemis pull request #1929: ARTEMIS-1728 Reclaim memory when page c...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1929


---

[GitHub] activemq-artemis issue #1933: ARTEMIS-1731 Support offline validation

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1933
  
Please feel free to submit and alternative approach


---

[GitHub] activemq-artemis issue #1933: ARTEMIS-1731 Support offline validation

[obfischer]

Github user obfischer commented on the issue:

https://github.com/apache/activemq-artemis/pull/1933
  
I wouldn't change the `schemaLocation` directly as it is actual a bad 
practice. Dependending on the XML processor catalog files should be used. In 
most cases the API of the XML processor allows you to handle such things in a 
cleaner way.


---

[GitHub] activemq-artemis pull request #1933: ARTEMIS-1731 Support offline validation

[michaelandrepearce]

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1933

ARTEMIS-1731 Support offline validation

Copy in https://www.w3.org/2005/08/xml.xsd so validation of broker.xml 
works offline.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1731

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1933.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1933


commit 055c51d6b1eba2ecdc665138e6545f2c75c67349
Author: Michael André Pearce 
Date:   2018-03-06T09:58:12Z

ARTEMIS-1731 Support offline validation

Copy in https://www.w3.org/2005/08/xml.xsd so validation of broker.xml 
works offline.




---

[GitHub] activemq-artemis pull request #1931: ARTEMIS-1719 fix threadleakrule after N...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1931


---

[GitHub] activemq-artemis pull request #1932: ARTEMIS-1661 Support offline validation

[michaelandrepearce]

Github user michaelandrepearce closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1932


---

[GitHub] activemq-artemis pull request #1932: ARTEMIS-1661 Support offline validation

[michaelandrepearce]

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1932

ARTEMIS-1661 Support offline validation

Copy in https://www.w3.org/2005/08/xml.xsd so validation of broker.xml 
works offline.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1661

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1932.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1932


commit 970b354b05e46b4225ca75c8e1fed8c510af01f8
Author: Justin Bertram 
Date:   2018-03-05T21:12:23Z

ARTEMIS-1661 Support offline validation

Copy in https://www.w3.org/2005/08/xml.xsd so validation of broker.xml 
works offline.




---

[GitHub] activemq-artemis issue #1918: ARTEMIS-1722 Reduce pooled Netty ByteBuf usage

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1918
  
I'm closing this one and helping @tabish121 to validate 
https://github.com/apache/activemq-artemis/pull/1928, that is 100% the best 
approach, because it avoid completly the copy in the common case


---

[GitHub] activemq-artemis pull request #1918: ARTEMIS-1722 Reduce pooled Netty ByteBu...

[franz1981]

Github user franz1981 closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1918


---

[GitHub] activemq-artemis pull request #1913: ARTEMIS-1715 Disable to remove a divert...

[stanlyDoge]

Github user stanlyDoge commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1913#discussion_r172447340
  
--- Diff: 
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js ---
@@ -96,6 +96,9 @@ var ARTEMIS = (function(ARTEMIS) {
  .when('/artemis/deleteAddress', {
templateUrl: ARTEMIS.templatePath + 'deleteAddress.html'
  })
+ .when('/artemis/deleteDivert', {
--- End diff --

Well, it shows page without such button. But I agree it would be better to 
hide this button in "toolbar". I will take a look at this.


---

[GitHub] activemq-artemis pull request #1913: ARTEMIS-1715 Disable to remove a divert...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1913#discussion_r172446748
  
--- Diff: 
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js ---
@@ -96,6 +96,9 @@ var ARTEMIS = (function(ARTEMIS) {
  .when('/artemis/deleteAddress', {
templateUrl: ARTEMIS.templatePath + 'deleteAddress.html'
  })
+ .when('/artemis/deleteDivert', {
--- End diff --

Then the consoles should hide the button, if divert is selected.


---

[GitHub] activemq-artemis pull request #1913: ARTEMIS-1715 Disable to remove a divert...

[stanlyDoge]

Github user stanlyDoge commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1913#discussion_r172446094
  
--- Diff: 
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js ---
@@ -96,6 +96,9 @@ var ARTEMIS = (function(ARTEMIS) {
  .when('/artemis/deleteAddress', {
templateUrl: ARTEMIS.templatePath + 'deleteAddress.html'
  })
+ .when('/artemis/deleteDivert', {
--- End diff --

Current behaviour is this: user has divert selected and wants to remove it. 
So he click on Delete. But hawtio console does not recognize divert and tries 
to remove address at which the divert is created.


---