Re: JsonUtil.truncate() unexpected behavior

2022-11-23 Thread Jan Šmucr
Thank you for your responses.

I changed my code to work around that. I just didn't expect such behavior. I 
think I'll just add some Javadoc to both methods so that it's a bit more 
obvious.

Jan


Dne 23. 11. 2022 21:14 napsal uživatel Justin Bertram :
As Robbie noted, this is expected. However, that doesn't mean it has to be
that way. If you think it should be changed please open a Jira and outline
a use-case where nulls make sense and empty strings don't.


Justin

On Wed, Nov 23, 2022 at 7:44 AM Robbie Gemmell 
wrote:

> I guess its expected in so far as it was done deliberately:
> https://github.com/apache/activemq-artemis/pull/3948
>
>
> On Wed, 23 Nov 2022 at 13:01, Jan Šmucr 
> wrote:
> >
> > Hello.
> >
> > I’ve been using the Message.toPropertyMap() function and recently I’ve
> discovered that it does not preserve null values, as they get replaced by
> an empty string in JsonUtil.truncate(). I understand that it’s not possible
> to put null values into maps, but on the other hand, they are supported in
> JSON and there’s quite a difference between null and "". And the
> toPropertyMap function doc states clearly: “…useful when encoding to JSON”.
> >
> > Is this an expected behavior? I can work around that, but should I?
> >
> > Jan
> >
>
>



Re: JsonUtil.truncate() unexpected behavior

2022-11-23 Thread Justin Bertram
As Robbie noted, this is expected. However, that doesn't mean it has to be
that way. If you think it should be changed please open a Jira and outline
a use-case where nulls make sense and empty strings don't.


Justin

On Wed, Nov 23, 2022 at 7:44 AM Robbie Gemmell 
wrote:

> I guess its expected in so far as it was done deliberately:
> https://github.com/apache/activemq-artemis/pull/3948
>
>
> On Wed, 23 Nov 2022 at 13:01, Jan Šmucr 
> wrote:
> >
> > Hello.
> >
> > I’ve been using the Message.toPropertyMap() function and recently I’ve
> discovered that it does not preserve null values, as they get replaced by
> an empty string in JsonUtil.truncate(). I understand that it’s not possible
> to put null values into maps, but on the other hand, they are supported in
> JSON and there’s quite a difference between null and "". And the
> toPropertyMap function doc states clearly: “…useful when encoding to JSON”.
> >
> > Is this an expected behavior? I can work around that, but should I?
> >
> > Jan
> >
>
>


[HEADS-UP] Artemis 2.27.1 next week

2022-11-23 Thread Clebert Suconic
I'm in vacation mode this week, so I will cut a release next week...


if anyone is available to cut it this week, please feel free to do it
before me? Otherwise I will do it on monday.


I will do some review on pending PRs on monday.. or if you can merge
what's ready already.. that would be a great help.

-- 
Clebert Suconic


Re: JsonUtil.truncate() unexpected behavior

2022-11-23 Thread Robbie Gemmell
I guess its expected in so far as it was done deliberately:
https://github.com/apache/activemq-artemis/pull/3948


On Wed, 23 Nov 2022 at 13:01, Jan Šmucr  wrote:
>
> Hello.
>
> I’ve been using the Message.toPropertyMap() function and recently I’ve 
> discovered that it does not preserve null values, as they get replaced by an 
> empty string in JsonUtil.truncate(). I understand that it’s not possible to 
> put null values into maps, but on the other hand, they are supported in JSON 
> and there’s quite a difference between null and "". And the toPropertyMap 
> function doc states clearly: “…useful when encoding to JSON”.
>
> Is this an expected behavior? I can work around that, but should I?
>
> Jan
>


JsonUtil.truncate() unexpected behavior

2022-11-23 Thread Jan Šmucr
Hello.

I’ve been using the Message.toPropertyMap() function and recently I’ve 
discovered that it does not preserve null values, as they get replaced by an 
empty string in JsonUtil.truncate(). I understand that it’s not possible to put 
null values into maps, but on the other hand, they are supported in JSON and 
there’s quite a difference between null and "". And the toPropertyMap function 
doc states clearly: “…useful when encoding to JSON”.

Is this an expected behavior? I can work around that, but should I?

Jan