[GitHub] activemq-artemis issue #2025: ARTEMIS-1815 adding exclusive-queue example
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/2025 @clebertsuconic , Thanks Clebert. ---
[GitHub] activemq-artemis pull request #2025: ARTEMIS-1815 adding exclusive-queue exa...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/2025 ARTEMIS-1815 adding exclusive-queue example To highlight the new exclusive queue functionality, add "exclusive-queue" example. see contained examples/features/standard/exclusive-queue/readme.md for more details. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis exclusive_queue_example Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2025.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2025 commit 24442f8a63588f78b4a617a2d4a0c1cbfcc0bcb4 Author: Pat Fox <pat.g.fox@...> Date: 2018-04-17T14:22:10Z ARTEMIS-1815 adding exclusive-queue example ---
[GitHub] activemq-artemis pull request #2017: ARTEMIS-1809 adding example of mapping ...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/2017 ARTEMIS-1809 adding example of mapping ActiveMQ 5.x Virtual Topic consumers see contained examples/protocols/openwire/virtual-topic-mapping/readme.md for details. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis virtualTopic-mapping-example Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2017.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2017 commit 39a8e8265c2956f63fc45e97aff5a03e2576bada Author: Pat Fox <pat.g.fox@...> Date: 2018-04-15T19:22:26Z ARTEMIS-1809 adding example of mapping ActiveMQ 5.x Virtual Topic consumers ---
[GitHub] activemq-artemis issue #1817: ARTEMIS-1623 add logging codes to LoggingActiv...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1817 Hi @jbertram, this is followup to #1796, does this address your points on that PR? Thanks Pat ---
[GitHub] activemq-artemis issue #1817: ARTEMIS-1623 add logging codes to LoggingActiv...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1817 @michaelandrepearce Thanks Mike ---
[GitHub] activemq-artemis pull request #1817: ARTEMIS-1623 add logging codes to Loggi...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1817 ARTEMIS-1623 add logging codes to LoggingActiveMQServerPlugin - added LoggingActiveMQServerPluginLogger to follow logging pattern - clarified DEBUG Level usage in doc This is a follow up PR to #1796 You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis log_codes_logging_plugin Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1817.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1817 commit 3879d1b62acd65aa78368780d49d42ea80f8f28a Author: Pat Fox <pat.g.fox@...> Date: 2018-01-24T08:09:08Z ARTEMIS-1623 add logging codes to LoggingActiveMQServerPlugin ---
[GitHub] activemq-artemis issue #1796: ARTEMIS-1623 ActiveMQServerPlugin impl for log...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1796 @clebertsuconic no problem Clebert. I will create a new PR when I have those pending things completed. ---
[GitHub] activemq-artemis issue #1796: ARTEMIS-1623 ActiveMQServerPlugin impl for log...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1796 @clebertsuconic There was some outstanding improvements suggested by @jbertram @michaelandrepearce (above) on this PR that I have not finish yet. Can I just open a new PR for those improvement when I have them completed? I should have them done in the next day or so. Sorry, for any confusion this has caused. ---
[GitHub] activemq-artemis issue #1796: ARTEMIS-1623 ActiveMQServerPlugin impl for log...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1796 I still had to do the suggested changes we discussed :( Sorry I did not think the would be merged yet. I hope to get those changes pushed to the PR in the next day or so. ---
[GitHub] activemq-artemis issue #1796: ARTEMIS-1623 ActiveMQServerPlugin impl for log...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1796 @jbertram , @michaelandrepearce Thanks for reviewing this PR. I will try to implement all the above suggestions. on the DEBUG vs. INFO I will make it clearer in the docs; there is a before/after on most of the plugin events . For INFO I log a slightly reduced log in the "after" point. For DEBUG I log a more detailed entry before and after. I will try to follow the established pattern for the LOG codes; create an interface LoggingActiveMQServerPluginLogger that extends the BasicLogger. It there any restriction on the 2 digit Logger Code I use - I think "83" is the last number currently used so I guess "84" would be ok? Or is there a pattern to choosing that value? ---
[GitHub] activemq-artemis pull request #1796: ARTEMIS-1623 ActiveMQServerPlugin impl ...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1796 ARTEMIS-1623 ActiveMQServerPlugin impl for logging various broker events Similar concept to the ActiveMQ 5.x loggingBrokerPlugin. Commit includes: - plugin impl - tests using byteman for checking logging with AMQP, CORE and Openwire - doc on how to configure plugin For configuration details please see broker-plugins.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis logging_brokerplugin Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1796.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1796 commit 941a87cd4843c7a2ec3fee117d702450dc4efb85 Author: Pat Fox <pat.g.fox@...> Date: 2018-01-06T13:06:39Z ARTEMIS-1623 ActiveMQServerPlugin impl for logging various broker events Similiar concept to the ActiveMQ 5.x loggingBrokerPlugin ---
[GitHub] activemq-artemis issue #1696: NO-JIRA fixed minor regression and broken test...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1696 Thanks @michaelandrepearce , @mtaylor ---
[GitHub] activemq-artemis issue #1696: NO-JIRA fixed minor regression and broken test...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1696 - added in @michaelandrepearce commit to the PR - fixed a few minor check style infringements - added testing to exercise some of the sorting code I did not squash the commits as I wanted to keep the commit history to show multiple contributors. ---
[GitHub] activemq-artemis issue #1696: NO-JIRA fixed minor regression and broken test...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1696 @michaelandrepearce Thanks Mike, I updated the PR with your commit. I will do a test run tonight on the new PR. ---
[GitHub] activemq-artemis issue #1696: NO-JIRA fixed minor regression and broken test...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1696 - reverted JSON fields to origin names before #1628 - updated *.js to reflect field name reverts. ---
[GitHub] activemq-artemis issue #1696: NO-JIRA fixed minor regression and broken test...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1696 Hi @RaiSaurabh, great work on #1628. One minor point, the JSON field name changes as part of that PR causes a test to fail. That sparked the conversation above with Mike. It is not a problem, I am currently updating this PR to change back to the original names. I just wanted to check if there was a "real" requirement for these field name changes, perhaps I am overlooking it. Thanks in advance. ---
[GitHub] activemq-artemis issue #1696: NO-JIRA fixed minor regression and broken test...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1696 @michaelandrepearce Thanks Mike, I agree about the field names in the JSON objects; IMHO they are really part of the external interface so should not be changed unless there is a very good reason. I will try to revert all names changed in #1628 and update this PR. ---
[GitHub] activemq-artemis pull request #1696: NO-JIRA fixed minor regression and brok...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1696 NO-JIRA fixed minor regression and broken tests in ActiveMQServerControlImpl fixed minor regression and broken tests due to refactor in ARTEMIS-1364 You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis fix_regression Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1696.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1696 commit 7a11a6063429a329c170f125c5da0be250d1ea1e Author: Pat Fox <pat.g@gmail.com> Date: 2017-12-07T19:49:25Z NO-JIRA fixed minor regression and broken tests in ActiveMQServerControlImpl ---
[GitHub] activemq-artemis pull request #1686: ARTEMIS-1534 added openwire logging (tr...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1686 ARTEMIS-1534 added openwire logging (trace level) to log openwire commands that are received/sent by the broker. This is similar to the CORE protocol packet level logging in org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java and org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis openwire_logging Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1686.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1686 commit 813f5b459f465effa75883f37e851550c2132adc Author: Pat Fox <pat.g@gmail.com> Date: 2017-12-02T11:10:38Z ARTEMIS-1534 added openwire logging (trace level) to log openwire commands that are received/sent by the broker ---
[GitHub] activemq-artemis issue #1675: ARTEMIS-1526 NullpointerException in ActiveMQS...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1675 seems there were changed introduced yesterday - I will need to pick these up retest & push again. ---
[GitHub] activemq-artemis pull request #1665: ARTEMIS-1520 add connection ID to the t...
Github user pgfox commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1665#discussion_r153641817
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java
---
@@ -656,17 +672,15 @@ private void addResendPacket(Packet packet) {
resendCache.add(packet);
if (logger.isTraceEnabled()) {
- logger.trace("ChannelImpl::addResendPacket adding packet " +
packet + " stored commandID=" + firstStoredCommandID + " possible commandIDr="
+ (firstStoredCommandID + resendCache.size()));
+ logger.trace("RemotingConnectionID=" + (connection == null ?
"NULL" : connection.getID()) + " ChannelImpl::addResendPacket adding packet " +
packet + " stored commandID=" + firstStoredCommandID + " possible commandIDr="
+ (firstStoredCommandID + resendCache.size()));
}
}
private void clearUpTo(final int lastReceivedCommandID) {
final int numberToClear = 1 + lastReceivedCommandID -
firstStoredCommandID;
if (logger.isTraceEnabled()) {
- logger.trace("ChannelImpl::clearUpTo lastReceived commandID=" +
lastReceivedCommandID +
- " first commandID=" + firstStoredCommandID +
- " number to clear " + numberToClear);
+ logger.trace("RemotingConnectionID=" + (connection == null ?
"NULL" : connection.getID()) + " ChannelImpl::clearUpTo lastReceived
commandID=" + lastReceivedCommandID + " first commandID=" +
firstStoredCommandID + " number to clear " + numberToClear);
--- End diff --
@clebertsuconic Thanks Clebert. I will try to avoid those long lines in the
future.
---
[GitHub] activemq-artemis pull request #1675: ARTEMIS-1526 NullpointerException in Ac...
Github user pgfox commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1675#discussion_r153590458
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerView.java
---
@@ -45,7 +45,7 @@ public Class getClassT() {
@Override
public JsonObjectBuilder toJson(ServerConsumer consumer) {
ServerSession session =
server.getSessionByID(consumer.getSessionID());
- JsonObjectBuilder obj = JsonLoader.createObjectBuilder().add("id",
toString(consumer.sequentialID())).add("session",
toString(session.getName())).add("clientID",
toString(session.getRemotingConnection().getClientID())).add("user",
toString(session.getUsername())).add("protocol",
toString(session.getRemotingConnection().getProtocolName())).add("queue",
toString(consumer.getQueue().getName())).add("queueType",
toString(consumer.getQueue().getRoutingType()).toLowerCase()).add("address",
toString(consumer.getQueue().getAddress().toString())).add("localAddress",
toString(session.getRemotingConnection().getTransportConnection().getLocalAddress())).add("remoteAddress",
toString(session.getRemotingConnection().getTransportConnection().getRemoteAddress())).add("creationTime",
new Date(consumer.getCreationTime()).toString());
+ JsonObjectBuilder obj = JsonLoader.createObjectBuilder().add("id",
toString(consumer.sequentialID())).add("session", (session == null ? "" :
toString(session.getName(.add("clientID", (session == null ? "" :
toString(session.getRemotingConnection().getClientID(.add("user", (session
== null ? "" : toString(session.getUsername(.add("protocol", (session ==
null ? "" :
toString(session.getRemotingConnection().getProtocolName(.add("queue",
toString(consumer.getQueue().getName())).add("queueType",
toString(consumer.getQueue().getRoutingType()).toLowerCase()).add("address",
toString(consumer.getQueue().getAddress().toString())).add("localAddress",
(session == null ? "" :
toString(session.getRemotingConnection().getTransportConnection().getLocalAddress(.add("remoteAddress",
(session == null ? "" :
toString(session.getRemotingConnection().getTransportConnection().getRemoteAddress(.add("creationTime",
new Date(consumer.getCreationTime()).toString());
--- End diff --
@clebertsuconic sure will do
---
[GitHub] activemq-artemis pull request #1675: ARTEMIS-1526 NullpointerException in Ac...
Github user pgfox commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1675#discussion_r153589625
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerView.java
---
@@ -45,7 +45,7 @@ public Class getClassT() {
@Override
public JsonObjectBuilder toJson(ServerConsumer consumer) {
ServerSession session =
server.getSessionByID(consumer.getSessionID());
- JsonObjectBuilder obj = JsonLoader.createObjectBuilder().add("id",
toString(consumer.sequentialID())).add("session",
toString(session.getName())).add("clientID",
toString(session.getRemotingConnection().getClientID())).add("user",
toString(session.getUsername())).add("protocol",
toString(session.getRemotingConnection().getProtocolName())).add("queue",
toString(consumer.getQueue().getName())).add("queueType",
toString(consumer.getQueue().getRoutingType()).toLowerCase()).add("address",
toString(consumer.getQueue().getAddress().toString())).add("localAddress",
toString(session.getRemotingConnection().getTransportConnection().getLocalAddress())).add("remoteAddress",
toString(session.getRemotingConnection().getTransportConnection().getRemoteAddress())).add("creationTime",
new Date(consumer.getCreationTime()).toString());
+ JsonObjectBuilder obj = JsonLoader.createObjectBuilder().add("id",
toString(consumer.sequentialID())).add("session", (session == null ? "" :
toString(session.getName(.add("clientID", (session == null ? "" :
toString(session.getRemotingConnection().getClientID(.add("user", (session
== null ? "" : toString(session.getUsername(.add("protocol", (session ==
null ? "" :
toString(session.getRemotingConnection().getProtocolName(.add("queue",
toString(consumer.getQueue().getName())).add("queueType",
toString(consumer.getQueue().getRoutingType()).toLowerCase()).add("address",
toString(consumer.getQueue().getAddress().toString())).add("localAddress",
(session == null ? "" :
toString(session.getRemotingConnection().getTransportConnection().getLocalAddress(.add("remoteAddress",
(session == null ? "" :
toString(session.getRemotingConnection().getTransportConnection().getRemoteAddress(.add("creationTime",
new Date(consumer.getCreationTime()).toString());
--- End diff --
@clebertsuconic originally my thought was to get as much info as possible
for the consumer but your suggestion makes more sense as that consumer will
also be closed, so there is no real point in displaying the available data.
I will update/test and push it again
Thanks
Pat
---
[GitHub] activemq-artemis pull request #1675: ARTEMIS-1526 NullpointerException in Ac...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1675 ARTEMIS-1526 NullpointerException in ActiveMQServerControl.listConsumers() race condition between listConsumers() and client closing a Session . Avoid NullPointerException and return empty strings for JSON attributes associated with that Session. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis listConsumer_race Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1675.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1675 commit 51cea804aaf79372eb88e3541a2b1b2bb0b7f594 Author: Pat Fox <pat.g@gmail.com> Date: 2017-11-26T14:00:23Z ARTEMIS-1526 race condition between listConsumers() and closing a Session. Avoid NullPointerException and return empty strings for Json attributes associated with that Session. ---
[GitHub] activemq-artemis pull request #1669: ARTEMIS-1524 avoid null pointer due to ...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1669 ARTEMIS-1524 avoid null pointer due to race condition in listAddresses() The listAddresses() retrieves the list of addresses and then retrieves the detail of each one to build the Json representation. If the deleteAddress() occurs between getting the list of addresses and retrieving the details - a NullPointerException is thrown. If address is deleted, ignore that address and continue through the list. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis listAddress_race Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1669.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1669 commit 8a1b00cb3e99039ca7d34249b3320c0c09d11423 Author: Pat Fox <pat.g@gmail.com> Date: 2017-11-24T13:12:00Z ARTEMIS-1524 avoid null pointer due to race condition in listAddresses(). If address is deleted, ignore that address and continue ---
[GitHub] activemq-artemis pull request #1668: ARTEMIS-1522 add date to timestamp in l...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1668 ARTEMIS-1522 add date to timestamp in logs Currently the date can derived from the log file prefix but in scenarios where you are only seeing snippets of log files or these log files are being manipulated later; it makes it much easier if the date is printed with the log entry. I understand people want to reduce log space but adding the date would avoid any potential ambiguity. current format `` 11:56:49,051 INFO [org.apache.activemq.artemis.core.server] AMQ221007: Server is now live `` Suggested new format `` 2017-11-24 15:24:11,803 INFO [org.apache.activemq.artemis.core.server] AMQ221007: Server is now live `` You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis date_format Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1668.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1668 commit ee035afa07c4544a45ff840321a500dc5153002a Author: Pat Fox <pat.g@gmail.com> Date: 2017-11-24T14:08:40Z ARTEMIS-1522 add date to timestamp in logs ---
[GitHub] activemq-artemis pull request #1665: ARTEMIS-1520 add connection ID to the t...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1665 ARTEMIS-1520 add connection ID to the trace logging for reading/writing packets. This helps correlate the packets read/written to an individual tcp connection By setting `` logger.org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.level=TRACE logger.org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.level=TRACE `` The output will contain an association between RemotingConnectionID and the local/remote tcp connection. Also, logging for the packets received and sent will have RemotingConnectionID associated making it easier to track the interaction on an individual connection. `` RemotingConnectionImpl created: RemotingConnectionImpl [ID=2a27fbff, clientID=null, nodeID=e3635a94-d036-11e7-8bca-a860b60c8b30, transportConnection=org.apache.activemq.artemis.core.remoting.impl.netty.NettyServerConnection@460561df[ID=2a27fbff, local= /127.0.0.1:61616, remote=/127.0.0.1:55729]] ... RemotingConnectionID=2a27fbff handling packet PACKET(CreateSessionMessage)[type=30, channelID=1, packetObject=CreateSessionMessage, autoCommitAcks=false, ... RemotingConnectionID=2a27fbff Sending packet nonblocking PACKET(SessionBindingQueryResponseMessage_V4)[type=-15, channelID=11, `` You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis connection_logging Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1665.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1665 commit 6f785de3d8afdf26da3cb56309b07e5b21feec32 Author: Pat Fox <pat.g@gmail.com> Date: 2017-11-13T19:03:17Z ARTEMIS-1520 add connection ID to the trace logging output dealing with reading/writing packets. This helps correlate the packets read/written to an individual tcp connection ---
[GitHub] activemq-artemis issue #1643: ARTEMIS-1502 added addressMemorySize and pagin...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1643 Thanks @mtaylor. I will close this PR as it is the wrong approach, maybe followup later with another PR. ---
[GitHub] activemq-artemis pull request #1643: ARTEMIS-1502 added addressMemorySize an...
Github user pgfox closed the pull request at: https://github.com/apache/activemq-artemis/pull/1643 ---
[GitHub] activemq-artemis pull request #1642: NO-JIRA - minor updates to sample, so i...
Github user pgfox commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1642#discussion_r149118258 --- Diff: examples/features/standard/large-message/src/main/resources/jndi.properties --- @@ -16,5 +16,5 @@ # under the License. java.naming.factory.initial=org.apache.activemq.artemis.jndi.ActiveMQInitialContextFactory -connectionFactory.ConnectionFactory=tcp://localhost:61616 +connectionFactory.ConnectionFactory=tcp://localhost:61616?minLargeMessageSize=10240 --- End diff -- Thanks @clebertsuconic :) ---
[GitHub] activemq-artemis pull request #1642: NO-JIRA - minor updates to sample, so i...
Github user pgfox commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1642#discussion_r149115107 --- Diff: examples/features/standard/large-message/src/main/resources/jndi.properties --- @@ -16,5 +16,5 @@ # under the License. java.naming.factory.initial=org.apache.activemq.artemis.jndi.ActiveMQInitialContextFactory -connectionFactory.ConnectionFactory=tcp://localhost:61616 +connectionFactory.ConnectionFactory=tcp://localhost:61616?minLargeMessageSize=10240 --- End diff -- Thanks @clebertsuconic . In the comments in LargeMessageExample.java it mentions the following. `` // Step 3. Perform a lookup on the Connection Factory. This ConnectionFactory has a special attribute set on // it. // Messages with more than 10K are considered large `` I think it is good to have a sample of how to set the config on the url to show syntax, in case a customer wants to change the default for whatever reason. ---
[GitHub] activemq-artemis issue #1643: ARTEMIS-1502 added addressMemorySize and pagin...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1643 @mtaylor I changed ActiveMQServerControlImpl#listAddresses(java.lang.String, int, int) to use `` server.getManagementService().getResources(AddressControl.class) `` rather than call `` server.getPostOffice().getAddresses() `` It was easier to get the memorySize and paging info from the AddressControl. It seems to work fine but just wondering if it is a bad idea as you avoided it initially? thanks Pat ---
[GitHub] activemq-artemis pull request #1643: ARTEMIS-1502 added addressMemorySize an...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1643 ARTEMIS-1502 added addressMemorySize and paging info to addresslist You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis address_view_changes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1643.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1643 commit d6d55afe1895212fe2123a395c184d04651c35ed Author: Pat Fox <pat.g@gmail.com> Date: 2017-11-05T13:03:58Z ARTEMIS-1502 added addressMemorySize and paging info to ActiveMQServerControl.listAddresses() and webconsole ---
[GitHub] activemq-artemis pull request #1642: NO-JIRA - minor updates to sample, so i...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1642 NO-JIRA - minor updates to sample, so it works as described in comments The LargeMessageExample was not working as described in docs: - FILESIZE was set to 1 MiB instead of 2 GiB I had a look at the previous change to FILE_SIZE and my guess is the change was included in a commit as an oversight. Please let me know if the file size was meant to be reduced and I will modify the PR to reflect that. - ?minLargeMessageSize=10240 was omitted from URL. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis large_message_example Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1642.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1642 commit 86b8a92e5fa8fede771ea07a47e186657dad4694 Author: Pat Fox <pat.g@gmail.com> Date: 2017-11-04T17:18:30Z NO-JIRA - minor updates to sample, so it works as described in comments ---
[GitHub] activemq-artemis pull request #1637: NO-JIRA minor typo in doc'd config samp...
Github user pgfox closed the pull request at: https://github.com/apache/activemq-artemis/pull/1637 ---
[GitHub] activemq-artemis issue #1637: NO-JIRA minor typo in doc'd config sample
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1637 @clebertsuconic thanks Clebert ... will close it now. ---
[GitHub] activemq-artemis pull request #1637: NO-JIRA minor typo in doc'd config samp...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1637 NO-JIRA minor typo in doc'd config sample You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis config_transport_doc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1637.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1637 commit fcf4f3e79ae5ed8f44b664a6800b29662404156f Author: Pat Fox <pat.g@gmail.com> Date: 2017-11-03T12:05:10Z NO-JIRA minor typo in doc'd config sample ---
[GitHub] activemq-artemis pull request #1557: NO-JIRA minor typos in console
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1557 NO-JIRA minor typos in console minor typos that showed on the console You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis console_typos Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1557.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1557 commit fa75d393d37f1bd12d1113d66ac0e74f6f3c1b04 Author: Pat Fox <pat.g@gmail.com> Date: 2017-09-27T06:48:30Z NO-JIRA minor typos in console ---
[GitHub] activemq-artemis issue #1543: ARTEMIS-1436 update CLI StatQueue to allow gre...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1543 add the greater_than/less_than only the filter objects of *.js that have numeric values to filter by ---
[GitHub] activemq-artemis issue #1543: ARTEMIS-1436 update CLI StatQueue to allow gre...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1543 @mtaylor sure, will give that go. ---
[GitHub] activemq-artemis issue #1543: NO-JIRA update StatQueue to allow greater_than...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1543 sure, will do that, thanks @clebertsuconic ---
[GitHub] activemq-artemis issue #1549: ARTEMIS-1433 adding AddressMemoryUsage()/Addre...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1549 @jbertram I have added getAddressMessageUsage as an attribute; in worst case scenario, if many clients constantly refresh their mBean view, this could result in a high number of globalSizeBytes.get(). If I understand correctly globalSizeBytes is on a critical path for the PostOffice.processRoute(). I don't think this change should impact the critical path or have any side effects . ---
[GitHub] activemq-artemis pull request #1549: ARTEMIS-1433 adding AddressMemoryUsage(...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1549 ARTEMIS-1433 adding AddressMemoryUsage()/AddressMemoryUsagePercentage() expose the total amount of memory used by the Addresses on the broker and express it as a percentage of the global-max-size limit. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis memory_used Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1549.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1549 commit 4f0a7067beac484c41b4ae5a59532115124cbe04 Author: Pat Fox <pat.g@gmail.com> Date: 2017-09-22T08:54:07Z ARTEMIS-1433 adding AddressMemoryUsage() and AddressMemoryUsagePercentage() to ActiveMQServerControl ---
[GitHub] activemq-artemis pull request #1543: NO-JIRA update StatQueue to allow GREAT...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1543 NO-JIRA update StatQueue to allow GREATER_THAN/LESS_THAN operations You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis statQueue_update Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1543.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1543 commit 5fba30521a62f3b57396b8b678a6e96f09255bba Author: Pat Fox <pat.g@gmail.com> Date: 2017-09-19T14:45:07Z NO-JIRA update StatQueue to allow GREATER_THAN/LESS_THAN comparison ---
[GitHub] activemq-artemis pull request #1541: ARTEMIS-1423 numeric filtering for Acti...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1541 ARTEMIS-1423 numeric filtering for ActiveMQServerControl.listQueues() This also applies to listAddresses()/listSessions() Also to add GREATER_THAN and LESS_THAN operations, this allows the listQueues() to support queries such as "Message_Count GREATER_THAN 1000" or "Consumer_Count LESS_THAN 2" - When LESS_THAN or GREATER_THAN is used with a String column, nothing is matched. - When CONTAINS is applied to a numeric column nothing is matched. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis numeric_filter_alternat Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1541.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1541 commit 12f37427e409dbe50db5b7cd9fa2f0fa69633039 Author: Pat Fox <pat.g@gmail.com> Date: 2017-09-15T17:49:01Z ARTEMIS-1423 adding numeric filtering for ActiveMQServerControl.listQueues()/listAddresses()/listSessions() ---
[GitHub] activemq-artemis pull request #1526: NO-JIRA add unit tests for ActiveMQServ...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1526 NO-JIRA add unit tests for ActiveMQServerControl listAddresses() unit tests for ActiveMQServerControl listAddresses() and listConsumers() You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis unit_test_list_ops Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1526.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1526 commit 94a6d11f8e18698376f6d4a18bad5cb1fc442dcd Author: Pat Fox <pat.g@gmail.com> Date: 2017-09-08T09:22:34Z NO-JIRA add unit tests for ActiveMQServerControl listAddresses() and listConsumers() ---
[GitHub] activemq-artemis issue #1503: NO-JIRA added unit test to exercise ActiveMQSe...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1503 @clebertsuconic sorry about that. I will fix that up and push this again thanks Pat ---
[GitHub] activemq-artemis issue #1506: ARTEMIS-1384 adding CLI command (stat) to disp...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1506 changed to ``` ./artemis queue stat ... ``` ---
[GitHub] activemq-artemis issue #1506: ARTEMIS-1384 adding CLI command (qstat) to dis...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1506 @clebertsuconic hi Clebert, perhaps I am missing something; I am already extending from AbstractAction. AbstractAction extends from ConnectionAbstract. So I seem to be getting all the connectionAbstract goodness and staying with established pattern. It does ask for the user/password if not supplied as you mentions. thanks Pat ---
[GitHub] activemq-artemis issue #1506: ARTEMIS-1384 adding CLI command (qstat) to dis...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1506 @jbertram Thanks Justin. I will move it under the queue group as you suggested. ---
[GitHub] activemq-artemis issue #1506: ARTEMIS-1384 adding CLI command (qstat) to dis...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1506 Updated to filter on any of the columns returned ``` $ ./artemis qstat --user admin --password admin --field ADDRESS --operation EQUALS --value test500 |NAME |ADDRESS |CONSUMER_COUNT |MESSAGE_COUNT |MESSAGES_ADDED |DELIVERING_COUNT |MESSAGES_ACKED | |test500 |test500 |0 |1000 |1000 |0|0 | ``` --queueName=X can still be used as a shortcut to filter by "NAME that contains String X" ``` $ ./artemis qstat --user admin --password admin --queueName test |NAME |ADDRESS |CONSUMER_COUNT |MESSAGE_COUNT |MESSAGES_ADDED |DELIVERING_COUNT |MESSAGES_ACKED | |test500 |test500 |0 |1000 |1000 |0|0 | |test501 |test501 |0 |50 |50 |0|0 | |test502 |test502 |0 |75 |75 |0|0 | |test503 |test503 |0 |90 |90 |0|0 | |test504 |test504 |0 |200 |200|0|0 | ``` ---
[GitHub] activemq-artemis pull request #1506: ARTEMIS-1384 adding CLI command (qstat)...
Github user pgfox commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1506#discussion_r136872715
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/QueueStats.java
---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.cli.commands;
+
+import io.airlift.airline.Command;
+import io.airlift.airline.Option;
+import org.apache.activemq.artemis.api.core.JsonUtil;
+import org.apache.activemq.artemis.api.core.client.ClientMessage;
+import org.apache.activemq.artemis.api.core.management.ManagementHelper;
+
+import javax.json.JsonArray;
+import javax.json.JsonObject;
+import java.util.HashMap;
+
+@Command(name = "qstat", description = "prints out basic stats associated
with queues. Output includes " + "CONSUMERS (number of consumers), " +
"MESSAGES (current message count on the queue, including scheduled, paged and
in-delivery messages), " + "ADDED (messages added to the queue), " +
"DELIVERING (messages broker is currently delivering to consumer(s)), " +
"ACKED (messages acknowledged from the consumer(s))."
+
+)
+public class QueueStats extends AbstractAction {
+
+ public static final String NAME_FIELD = "name";
+ public static final String ADDRESS_FIELD = "address";
+ public static final String CONSUMER_COUNT_FIELD = "consumerCount";
+ public static final String MESSAGE_COUNT_FIELD = "messageCount";
+ public static final String MESSAGES_ADDED_FIELD = "messagesAdded";
+ public static final String DELIVERING_COUNT_FIELD = "deliveringCount";
+ public static final String MESSAGES_ACKED_FIELD = "messagesAcked";
+
+ @Option(name = "--queueName", description = "display queue stats for
queue(s) with names containing this string, " + "omitting this option will
return stats for all queues (until maxRows are reached).")
+ private String queueName;
+
+ @Option(name = "--exactMatch", description = "display queue stats for
queue(s) with this exact name. " + "Default is false.")
+ private boolean exactMatch = false;
+
+ @Option(name = "--maxRows", description = "max number of queues
displayed. Default is 50")
+ private int maxRows = 50;
+
+ //easier for testing
+ public void setQueueName(String queueName) {
+ this.queueName = queueName;
+ }
+
+ public void setExactMatch(boolean exactMatch) {
+ this.exactMatch = exactMatch;
+ }
+
+ public void setMaxRows(int maxRows) {
+ this.maxRows = maxRows;
+ }
+
+ public void setUser(String user) {
+ this.user = user;
+ }
+
+ public void setPassword(String password) {
+ this.password = password;
+ }
+
+ @Override
+ public Object execute(ActionContext context) throws Exception {
+ super.execute(context);
+ String filter = createFilter(queueName, exactMatch);
+
+ if (verbose) {
+ context.out.println("queueName='" + queueName + "'");
+ context.out.println("maxRows='" + maxRows + "'");
+ context.out.println("exactMatch='" + exactMatch + "'");
+ context.out.println("filter='" + filter + "'");
+ }
+
+ printStats(context, filter, maxRows);
+ return null;
+ }
+
+ private void printStats(final ActionContext context, final String
filter, int maxRows) throws Exception {
+ performCoreManagement(new ManagementCallback() {
+ @Override
+ public void setUpInvocation(ClientMessage message) throws
Exception {
+ManagementHelper.putOperationInvocatio
[GitHub] activemq-artemis pull request #1506: ARTEMIS-1384 adding CLI command (qstat)...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1506 ARTEMIS-1384 adding CLI command (qstat) to display basic queue stats simple CLI command that displays minimal/basic stats for a queue by using the ActiveMQServerControl.listQueues(). An example of the output below ``` $ ./artemis qstat --user admin --password admin --queueName Test |QUEUE NAME |ADDRESS NAME |CONSUMERS |MESSAGES |ADDED|DELIVERING |ACKED| |Test1|Test1|0 |0 |1000 |0 |1000 | |Test12 |Test12 |0 |1000 |1000 |0 |0| |Test124 |Test124 |0 |1000 |1000 |0 |0| ``` You can also search for an exact match (or display info for all queues if no queueName specified. ``` $ ./artemis qstat --user admin --password admin --queueName Test1 --exactMatch |QUEUE NAME |ADDRESS NAME |CONSUMERS |MESSAGES |ADDED|DELIVERING |ACKED| |Test1|Test1|0 |0 |1000 |0 |1000 | ``` I wanted to keep the info displayed relatively small as it is just intended as a "quick check" - these are the columns I use the most, in the corresponding activemq 5.x dstat command. thanks Pat You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis queue_stats Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1506.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1506 commit 38a1543b91fa6437cdcfb5c94316c81d3831eb5a Author: Pat Fox <pat.g@gmail.com> Date: 2017-09-01T23:29:04Z ARTEMIS-1384 adding CLI command (qstat) to display basic queue stats --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1503: NO-JIRA added unit test to exercise Act...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1503 NO-JIRA added unit test to exercise ActiveMQServerControl.listQueues() You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis list_queues_test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1503.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1503 commit 436083dce64e142f3349eade92803c95c67278d1 Author: Pat Fox <pat.g@gmail.com> Date: 2017-09-01T14:52:56Z NO-JIRA added unit test to exercise ActiveMQServerControl.listQueues() --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1500: ARTEMIS-1381 add JMX operation removeAl...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1500 ARTEMIS-1381 add JMX operation removeAllMessages() to the queue it would be good to add a removeAllMessages() JMX operation to clear all messages from the queue, to make it a little more intuitive in various JMX browsers (such as jconsole) adding an new method to the external facing QueueControl interface, AFAIK that should not break anything. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis removeAllMessages Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1500.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1500 commit 96f46ba9dce4cfb44eec0c69a5a4f46d31095afb Author: Pat Fox <pat.g@gmail.com> Date: 2017-08-31T21:33:29Z ARTEMIS-1381 add JMX operation removeAllMessages() to the queue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1488: ARTEMIS-1370 - consumer command, does n...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1488 ARTEMIS-1370 - consumer command, does not offer a ClientID command line⦠⦠arg You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis consumer_command_clientID Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1488.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1488 commit 8e5e20de0dc04515f17388148dd77404009d5192 Author: Pat Fox <pat.g@gmail.com> Date: 2017-08-23T10:02:26Z ARTEMIS-1370 consumer command, does not offer a ClientID command line arg --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1474: NO-JIRA removed out of date info regard...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1474 NO-JIRA removed out of date info regarding jms queue specific config minor doc update to remove out of date info regarding jms queue configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis doc_update_core_bridge Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1474.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1474 commit e3c58aec83f9752ce5c66a1089f08e486e8df35b Author: Pat Fox <pat.g@gmail.com> Date: 2017-08-19T10:55:28Z NO-JIRA removed out of date info regarding jms queue specific config --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1453: minor update to log message in browser command
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1453 @clebertsuconic @michaelandrepearce Sure, your suggested changes should be in the pull request now. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1453: minor update to log message in browser ...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1453 minor update to log message in browser command You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis log_message_update Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1453.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1453 commit 2f6e4c5491d95696e0e141e16149c1b88a399698 Author: Pat Fox <pat.g@gmail.com> Date: 2017-08-09T16:28:27Z minor update to log message in browse command --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1424: fixed some minor typos in description w...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1424 fixed some minor typos in description within option annotations You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis cli_desc_typos Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1424.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1424 commit 4edb750165a8d8c27e4126e3e5b0ed0a321c40f7 Author: Pat Fox <pat.g@gmail.com> Date: 2017-07-28T13:00:59Z fixed some minor typos in cli description annotations --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #905: added unit test for setting the user and passwo...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/905 @jbertram, as you suggested, enabled security on the test broker and add a role to ensure credentials passed with connection. Also enabled the default user to ensure existing tests passed without modification - I was trying to keep a small footprint. Thanks Pat --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #905: added unit test for setting the user and passwo...
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/905 @jbertram sure, I will give that a go --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #905: added unit test for setting the user and...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/905 added unit test for setting the user and password in the uri for tcp ⦠â¦transport, used in JNDI. Could not find an example in the existing unit tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis user_password_url_jndi Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/905.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #905 commit 47a6882e156357abf97969aafc2c076e82c32dab Author: Pat Fox <p...@redhat.com> Date: 2016-12-07T13:22:20Z added unit test for setting the user and password in the uri for tcp transport, used in JNDI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #553: Doc minor updates
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/553 Doc minor updates 2 minor alterations to the docs - I think these are correct from my testing. Best Regards Pat You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis doc_minor_updates Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/553.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #553 commit 29411d85731adb554e3a6467a6c01ca8f9575eee Author: Pat Fox <p...@redhat.com> Date: 2016-06-02T16:03:51Z changed doc to reflect examples usage - using connector-name attribute got the following exception, - 'AMQ214019: Invalid configuration: org.xml.sax.SAXParseException; cvc-type.3.1.1: Element 'connector-ref' is a simple type, so it cannot have attributes, excepting those whose namespace name is identical to 'http://www.w3.org/2001/XMLSchema-instance' and whose [local name] is one of 'type', 'nil', 'schemaLocation' or 'noNamespaceSchemaLocation'. However, the attribute, 'connector-name' was found.' commit 20259b2eab6ab0a2aa8418a7e31f4e1ec0cbdcca Author: Pat Fox <p...@redhat.com> Date: 2016-06-02T16:06:31Z added missing detail to warning statement --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: a few tiny doc typos
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/530 a few tiny doc typos some minor doc typo fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis minor_doc_typos Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/530.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #530 commit 8d482bbc0dc60d59dd911908d29f4ee838d57d83 Author: Pat Fox <p...@redhat.com> Date: 2016-05-23T15:40:42Z a few tiny doc typos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: adding 2 links to the examples chap...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/528 adding 2 links to the examples chapter added 2 links to the example chapter which were omitted Best Regards Pat You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis fixing_links Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/528.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #528 commit ceb2c32ba184fba73dd2391e7709357dc948df89 Author: Pat Fox <p...@redhat.com> Date: 2016-05-20T16:06:01Z adding 2 links to the examples chapter --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: fixing typo in doc link
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/527 fixing typo in doc link You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq-artemis doc_link_update Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/527.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #527 commit 4c1e8745cc6d158afad6c7cfb4208e8baeaa85ab Author: Pat Fox <p...@redhat.com> Date: 2016-05-19T21:27:43Z fixing typo in doc link --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq pull request: AMQ-5318: JDBC store; commit called on conn...
GitHub user pgfox opened a pull request: https://github.com/apache/activemq/pull/43 AMQ-5318: JDBC store; commit called on connection that uses autocommit during deleteAllMessages issue reported at AMQ-5318 You can merge this pull request into a Git repository by running: $ git pull https://github.com/pgfox/activemq jdbcAutoCommitCheck Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq/pull/43.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #43 commit 5a52536e409eae5dfae69ddb03e2dfa31112f90c Author: pgf pat.g@gmail.com Date: 2014-08-09T14:27:40Z added a check for autocommit before calling commit when dropping and creating tables + test case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
