[GitHub] activemq-artemis issue #1983: ARTEMIS-1749 - Fixes the ssl-enabled-crl-mqtt

[ingo1121]

Github user ingo1121 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1983
  
Hi!

Sorry for the mess with the git tree!

 

I have some question, though: 

 

1.  What is your normal build procedure? On my fork, I’ve made a Jenkins 
job, that just does a ”mvn install” ob the root directory; no profiles or 
anything. Is that reasonable?
2.  I tried to make a ”full example” integration test; by running 
”mvn -Pexamples verify” on the examples directory. Unfortuatly it quickly 
runs out of steam (both on Windows and RHEL). Is this something that should be 
fixed? Should I register a JIRA? I notice that a lot of Java processes are left 
behind…

 

Regards

Ingemar

 

 

Från: clebertsuconic  
Skickat: den 3 april 2018 00:52
Till: apache/activemq-artemis 
Kopia: ingo1121 ; Mention 
Ämne: Re: [apache/activemq-artemis] ARTEMIS-1749 - Fixes the 
ssl-enabled-crl-mqtt (#1983)

 

I fixed it.. but your PR was way too messed up. if I had merged your 
merges.. we would have created a mess on master. please no merge commits on PRs.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub 
 , 
or mute the thread 

 .  

 




---

[GitHub] activemq-artemis issue #1983: ARTEMIS-1749 - Fixes the ssl-enabled-crl-mqtt

[ingo1121]

Github user ingo1121 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1983
  
Been absent on vacation. Back now. Sorry if i messed up the revision-tree!

 Anyway, now the examples in Windows is, is far as I can judge, consistent 
with examples on RHEL7. 


---

[GitHub] activemq-artemis issue #1983: ARTEMIS-1749 - Fixes the ssl-enabled-crl-mqtt

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1983
  
@ingo1121 actually I'm reverting this PR. These examples are not running 
after your change. I shouldn't have merged it in the first place


---

[GitHub] activemq-artemis issue #1983: ARTEMIS-1749 - Fixes the ssl-enabled-crl-mqtt

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1983
  
I fixed it.. but your PR was way too messed up. if I had merged your 
merges.. we would have created a mess on master. please no merge commits on PRs.


---

[GitHub] activemq-artemis issue #1983: ARTEMIS-1749 - Fixes the ssl-enabled-crl-mqtt

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1983
  
@ingo1121 can you please do these following commands?

```sh
git pull --rebase upstream master
git push origin -f
```


---