[GitHub] activemq-artemis issue #2089: ARTEMIS-1866: Make Quorum vote result wait tim...

2018-05-17 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 @RaiSaurabh In addition, I have notived the both `ReplicaPolicy` and `ReplicatedPolicy` have `quorumVoteWait` mutable and not final, while they are not supposed to change that value

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866: Make Quorum vote result wait tim...

2018-05-17 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 @RaiSaurabh We have an [hacking guide](https://activemq.apache.org/artemis/docs/latest/hacking-guide/code.html) that explain: > When you commit your changes you will need to

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866: Make Quorum vote result wait tim...

2018-05-17 Thread RaiSaurabh
Github user RaiSaurabh commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 @franz1981 I have updated it. Refer the image ![image](https://user-images.githubusercontent.com/22483381/40176581-795ca33a-59f9-11e8-9209-6c66da5c286c.png) ---

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866: Make Quorum vote result wait tim...

2018-05-17 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 @RaiSaurabh I can't see any changes on the commit message or am I reading the old one? ---

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866: Make Quorum vote result wait tim...

2018-05-17 Thread RaiSaurabh
Github user RaiSaurabh commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 @franz1981 I have updated the code as per your suggestion and also updated the commit message same as the PR. Could you please review. ---